public_git
/
democratic-csi
mirror of https://github.com/democratic-csi/democratic-csi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

better logging/documentation around breaking change introduced 

Signed-off-by: Travis Glenn Hansen <travisghansen@yahoo.com>
This commit is contained in:
Travis Glenn Hansen 2022-03-03 11:54:20 -07:00
parent 43c0b332a5
commit 761a73e771
4 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
CHANGELOG.md
View File

@ -1,10 +1,19 @@
# v1.5.4
Released 2022-03-03
- more descriptive error message for breaking changes introduced in `v1.5.3`
# v1.5.3 # v1.5.3
Released 2022-03-02 Released 2022-03-02
- support for running `freenas-iscsi` and `freenas-nfs` sudo-less (see #151) - support for running `freenas-iscsi` and `freenas-nfs` `sudo`-less (see #151)
- more robust chown / chmod logic for all zfs drivers - BREAKING CHANGE for `freenas-nfs`, if set `datasetPermissionsUser` and
- all for setting extent comment/description in `freenas-iscsi` and `datasetPermissionsGroup` must be numeric user/group IDs, alpha values such
as `root` and `wheel` will no longer work
- more robust `chown` / `chmod` logic for all zfs drivers
- allow for setting extent comment/description in `freenas-iscsi` and
`freenas-api-iscsi` (see #158) `freenas-api-iscsi` (see #158)
# v1.5.2 # v1.5.2

4
examples/freenas-nfs.yaml
View File

@ -51,8 +51,8 @@ zfs:
datasetEnableQuotas: true datasetEnableQuotas: true
datasetEnableReservation: false datasetEnableReservation: false
datasetPermissionsMode: "0777" datasetPermissionsMode: "0777"
datasetPermissionsUser: root datasetPermissionsUser: 0
datasetPermissionsGroup: wheel datasetPermissionsGroup: 0
#datasetPermissionsAcls: #datasetPermissionsAcls:
#- "-m everyone@:full_set:allow" #- "-m everyone@:full_set:allow"
#- "-m u:kube:full_set:allow" #- "-m u:kube:full_set:allow"

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "democratic-csi", "name": "democratic-csi",
"version": "1.5.3", "version": "1.5.4",
"description": "kubernetes csi driver framework", "description": "kubernetes csi driver framework",
"main": "bin/democratic-csi", "main": "bin/democratic-csi",
"scripts": { "scripts": {

4
src/driver/freenas/ssh.js
View File

@ -1757,7 +1757,7 @@ class FreeNASSshDriver extends ControllerZfsBaseDriver {
if (String(user).match(/^[0-9]+$/) == null) { if (String(user).match(/^[0-9]+$/) == null) {
throw new GrpcError( throw new GrpcError(
grpc.status.FAILED_PRECONDITION, grpc.status.FAILED_PRECONDITION,
`datasetPermissionsUser must be numeric: ${user}` `BREAKING CHANGE since v1.5.3! datasetPermissionsUser must be numeric: ${user} is invalid`
); );
} }
perms.uid = Number(user); perms.uid = Number(user);
@ -1768,7 +1768,7 @@ class FreeNASSshDriver extends ControllerZfsBaseDriver {
if (String(group).match(/^[0-9]+$/) == null) { if (String(group).match(/^[0-9]+$/) == null) {
throw new GrpcError( throw new GrpcError(
grpc.status.FAILED_PRECONDITION, grpc.status.FAILED_PRECONDITION,
`datasetPermissionsGroup must be numeric: ${group}` `BREAKING CHANGE since v1.5.3! datasetPermissionsGroup must be numeric: ${group} is invalid`
); );
} }
perms.gid = Number(group); perms.gid = Number(group);