From 537497470df809b6bcd1d5ffd919676ac2b85a23 Mon Sep 17 00:00:00 2001 From: Bartosz Fenski Date: Thu, 9 Feb 2023 17:53:21 +0100 Subject: [PATCH] warning about removing / commenting out detachedSnapshotsDatasetParentName option --- examples/freenas-api-iscsi.yaml | 1 + examples/freenas-api-nfs.yaml | 1 + examples/freenas-api-smb.yaml | 1 + examples/freenas-iscsi.yaml | 1 + examples/freenas-nfs.yaml | 1 + examples/freenas-smb.yaml | 1 + examples/zfs-generic-iscsi.yaml | 1 + examples/zfs-generic-nfs.yaml | 1 + examples/zfs-generic-smb.yaml | 1 + 9 files changed, 9 insertions(+) diff --git a/examples/freenas-api-iscsi.yaml b/examples/freenas-api-iscsi.yaml index 210cfed..5871bcf 100644 --- a/examples/freenas-api-iscsi.yaml +++ b/examples/freenas-api-iscsi.yaml @@ -42,6 +42,7 @@ zfs: datasetParentName: tank/k8s/b/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tanks/k8s/b/snaps # "" (inherit), lz4, gzip-9, etc zvolCompression: diff --git a/examples/freenas-api-nfs.yaml b/examples/freenas-api-nfs.yaml index 97b8a53..1ec960e 100644 --- a/examples/freenas-api-nfs.yaml +++ b/examples/freenas-api-nfs.yaml @@ -37,6 +37,7 @@ zfs: datasetParentName: tank/k8s/a/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tank/k8s/a/snaps datasetEnableQuotas: true datasetEnableReservation: false diff --git a/examples/freenas-api-smb.yaml b/examples/freenas-api-smb.yaml index a8e0a84..9d13cef 100644 --- a/examples/freenas-api-smb.yaml +++ b/examples/freenas-api-smb.yaml @@ -42,6 +42,7 @@ zfs: datasetParentName: tank/k8s/a/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tank/k8s/a/snaps datasetEnableQuotas: true datasetEnableReservation: false diff --git a/examples/freenas-iscsi.yaml b/examples/freenas-iscsi.yaml index 0370d9f..a2de43f 100644 --- a/examples/freenas-iscsi.yaml +++ b/examples/freenas-iscsi.yaml @@ -51,6 +51,7 @@ zfs: datasetParentName: tank/k8s/b/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tanks/k8s/b/snaps # "" (inherit), lz4, gzip-9, etc zvolCompression: diff --git a/examples/freenas-nfs.yaml b/examples/freenas-nfs.yaml index 352c85c..3ed9ec4 100644 --- a/examples/freenas-nfs.yaml +++ b/examples/freenas-nfs.yaml @@ -47,6 +47,7 @@ zfs: datasetParentName: tank/k8s/a/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tank/k8s/a/snaps datasetEnableQuotas: true datasetEnableReservation: false diff --git a/examples/freenas-smb.yaml b/examples/freenas-smb.yaml index 8a2ed4d..8124e17 100644 --- a/examples/freenas-smb.yaml +++ b/examples/freenas-smb.yaml @@ -53,6 +53,7 @@ zfs: datasetParentName: tank/k8s/a/vols # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tank/k8s/a/snaps datasetEnableQuotas: true datasetEnableReservation: false diff --git a/examples/zfs-generic-iscsi.yaml b/examples/zfs-generic-iscsi.yaml index b4f6aee..2aaf5d0 100644 --- a/examples/zfs-generic-iscsi.yaml +++ b/examples/zfs-generic-iscsi.yaml @@ -31,6 +31,7 @@ zfs: datasetParentName: tank/k8s/test # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tanks/k8s/test-snapshots # "" (inherit), lz4, gzip-9, etc diff --git a/examples/zfs-generic-nfs.yaml b/examples/zfs-generic-nfs.yaml index e068c29..7b6a2d2 100644 --- a/examples/zfs-generic-nfs.yaml +++ b/examples/zfs-generic-nfs.yaml @@ -31,6 +31,7 @@ zfs: datasetParentName: tank/k8s/test # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tanks/k8s/test-snapshots datasetEnableQuotas: true diff --git a/examples/zfs-generic-smb.yaml b/examples/zfs-generic-smb.yaml index db60cf3..cbc8f8f 100644 --- a/examples/zfs-generic-smb.yaml +++ b/examples/zfs-generic-smb.yaml @@ -32,6 +32,7 @@ zfs: datasetParentName: tank/k8s/test # do NOT make datasetParentName and detachedSnapshotsDatasetParentName overlap # they may be siblings, but neither should be nested in the other + # do NOT comment this option out even if you don't plan to use snapshots, just leave it with dummy value detachedSnapshotsDatasetParentName: tanks/k8s/test-snapshots datasetEnableQuotas: true