Minor changes

.devcontainer/devcontainer.json

@@ -14,7 +14,7 @@
 	// "forwardPorts": [],
 
 	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "npm install",
+	"postCreateCommand": "/bin/bash .devcontainer/postCreate.sh",
 
 	// Configure tool-specific properties.
 	"customizations": {

.devcontainer/postCreate.sh

@@ -0,0 +1,12 @@
+#!/bin/env bash
+
+npm install
+
+git clone https://github.com/kubernetes-csi/csi-test /tmp/csi-test
+pushd /tmp/csi-test 
+make
+sudo cp /tmp/csi-test/cmd/csi-sanity/csi-sanity /usr/local/bin
+popd
+rm -rf /tmp/csi-test
+
+sudo apt update

.github/workflows/main.yml

@@ -191,7 +191,7 @@ jobs:
       max-parallel: 1
       matrix:
         config:
-          - zfs-generic/iscsi-pcs.yaml
+          #- zfs-generic/iscsi-pcs.yaml # TODO: enable this once the server is setup
           - zfs-generic/iscsi-targetcli.yaml
           - zfs-generic/nfs.yaml
           - zfs-generic/smb.yaml

CONTRIBUTING.md

@@ -29,6 +29,11 @@ To use the devcontainer:
 3. Click "Reopen in Container" when prompted
 4. Start coding with pre-configured environment
 
+> [!Note]
+> For `iSCSI` it's mandatory to use the Vagrant VM, due to the need of a kernel driver.
+> However for other tests the container is probably enough. It's possible to run the `dev/run.sh`
+> as explained below in the devcontainer and see if it's possible, before spinning up a full VM.
+
 #### 2. System Testing with Vagrant
 
 Vagrant provides a full virtual machine environment for: