From 857358e736f371b92c6f4d544e39ebe1b77c751d Mon Sep 17 00:00:00 2001 From: Sameer Naik Date: Wed, 15 Feb 2017 11:55:57 +0530 Subject: [PATCH 1/2] config: move default config var to Dockerfile --- bitnami/codeigniter/Dockerfile | 5 +++++ bitnami/codeigniter/docker-compose.yml | 2 -- bitnami/codeigniter/rootfs/app-entrypoint.sh | 6 ------ 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/bitnami/codeigniter/Dockerfile b/bitnami/codeigniter/Dockerfile index 8bf6b753331f..9918309aa2ca 100644 --- a/bitnami/codeigniter/Dockerfile +++ b/bitnami/codeigniter/Dockerfile @@ -26,6 +26,11 @@ RUN bitnami-pkg install codeigniter-3.1.3-0 --checksum 5d653ed41a2bf4f78818f5cb2 COPY rootfs / +ENV MARIADB_USER="root" \ + MARIADB_HOST="mariadb" \ + MARIADB_PORT="3306" \ + CODEIGNITER_PROJECT_NAME="myapp" + WORKDIR /app EXPOSE 8000 diff --git a/bitnami/codeigniter/docker-compose.yml b/bitnami/codeigniter/docker-compose.yml index ceade6488dd7..f1e60be4d7dd 100644 --- a/bitnami/codeigniter/docker-compose.yml +++ b/bitnami/codeigniter/docker-compose.yml @@ -2,8 +2,6 @@ version: '2' services: myapp: image: bitnami/codeigniter:latest - environment: - - CODEIGNITER_PROJECT_NAME= ports: - '8000:8000' volumes: diff --git a/bitnami/codeigniter/rootfs/app-entrypoint.sh b/bitnami/codeigniter/rootfs/app-entrypoint.sh index 0fd9e314c84b..e743836348c5 100755 --- a/bitnami/codeigniter/rootfs/app-entrypoint.sh +++ b/bitnami/codeigniter/rootfs/app-entrypoint.sh @@ -1,12 +1,6 @@ #!/bin/bash set -e -# Set default values -export MARIADB_USER=${MARIADB_USER:-"root"} -export MARIADB_HOST=${MARIADB_HOST:-"mariadb"} -export MARIADB_PORT=${MARIADB_PORT:-"3306"} -export CODEIGNITER_PROJECT_NAME=${CODEIGNITER_PROJECT_NAME:-"myapp"} - PROJECT_DIRECTORY=/app/$CODEIGNITER_PROJECT_NAME DEPLOY="$@" From 728d7933a55d22711ba5910d3889664a11be0605 Mon Sep 17 00:00:00 2001 From: Sameer Naik Date: Wed, 15 Feb 2017 12:14:23 +0530 Subject: [PATCH 2/2] entrypoint: remove references to `entrypoint.sh` from base image --- bitnami/codeigniter/Dockerfile | 9 +-------- bitnami/codeigniter/rootfs/app-entrypoint.sh | 13 ++++++------- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/bitnami/codeigniter/Dockerfile b/bitnami/codeigniter/Dockerfile index 9918309aa2ca..487e28c3c5c8 100644 --- a/bitnami/codeigniter/Dockerfile +++ b/bitnami/codeigniter/Dockerfile @@ -1,11 +1,4 @@ -## BUILDING -## (from project root directory) -## $ docker build -t bitnami/bitnami-docker-codeigniter . -## -## RUNNING -## $ docker run -p 8000:8000 bitnami/bitnami-docker-codeigniter - -FROM gcr.io/stacksmith-images/minideb:jessie-r8 +FROM gcr.io/stacksmith-images/minideb:jessie-r9 MAINTAINER Bitnami diff --git a/bitnami/codeigniter/rootfs/app-entrypoint.sh b/bitnami/codeigniter/rootfs/app-entrypoint.sh index e743836348c5..45e5df10e9df 100755 --- a/bitnami/codeigniter/rootfs/app-entrypoint.sh +++ b/bitnami/codeigniter/rootfs/app-entrypoint.sh @@ -1,13 +1,12 @@ -#!/bin/bash -set -e +#!/bin/bash -e +. /opt/bitnami/base/functions + +print_welcome_page +check_for_updates & PROJECT_DIRECTORY=/app/$CODEIGNITER_PROJECT_NAME DEPLOY="$@" -log () { - echo -e "\033[0;33m$(date "+%H:%M:%S")\033[0;37m ==> $1." -} - nami restart mariadb echo "Starting application ..." @@ -23,4 +22,4 @@ if [ "$1" == "php" -a "$2" == "-S" ] ; then DEPLOY="$@ -t $PROJECT_DIRECTORY" fi -exec /entrypoint.sh $DEPLOY +exec tini -- $DEPLOY