mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-09-30 03:01:21 +02:00
The scheduler's concurrent-dispatch tests failed on CI and passed locally, on a commit that touched nothing but a text file. Six tests in tests/unit/test_scheduler_concurrent_dispatch.py went red with every queue item logged as "Status set to 'printing'" and four of them read back as "pending", alongside "cannot commit transaction - SQL statements in progress" and a PrintArchive that could not be refreshed. The fixtures built their farm on sqlite+aiosqlite:///:memory:, and SQLAlchemy backs an in-memory SQLite with a StaticPool: one DBAPI connection handed to every session, with nothing keeping them apart. That was harmless while check_queue awaited its uploads inline, because only one session was ever live at a time. Under the refillable upload pool the uploads run as concurrent background tasks with a session each, so their transactions interleave on that single connection - a sibling session's close() rolls back another's flushed-but-uncommitted UPDATE, and a commit() landing while another session still holds a cursor raises the commit error above. Whether the interleaving lands badly comes down to core count and interpreter version, which is why a 30-core box on 3.13 stayed green and a 4-vCPU runner on 3.11 did not. The four fixtures now put the database in the test's own tmp_path, which gets an AsyncAdaptedQueuePool and a connection per session - what the application itself runs with (_resolve_pool_kwargs in backend/app/core/database.py: pool_size 20, max_overflow 200). So the harness is being brought in line with production rather than having its assertions relaxed; nothing in the scheduler changes, and the concurrency under test was correct throughout. Checked against the failure mode rather than against a green run: an isolated repro of the same shape - six writer sessions and one reader session closing mid-transaction - yields all-pending on the in-memory engine and all-printing on a file. The new risk is real SQLite write contention on one file, so the file was run twelve times pinned to two cores with no failures and no lock errors. tests/unit/test_scheduler_busy_reasons_3018.py carries the same harness on an in-memory engine, but dispatches to a single printer, so it has no second session to race; left as is.