mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-09-30 11:12:35 +02:00
maziggy
82d329d85c
When running multiple virtual printers with different access codes on separate bind IPs, FTP connections were always routed to the wrong VP. Root cause: the iptables REDIRECT rule (990→9990) rewrites the destination IP to the incoming interface's primary address. With Linux's weak host model (arp_filter=0), packets for secondary IPs arrive on the primary interface, and REDIRECT sends them all to the first VP's FTP server. MQTT was unaffected because port 8883 had no redirect. Fix: FTP server now binds directly to port 990 (standard implicit FTPS), eliminating the iptables redirect entirely. Requires CAP_NET_BIND_SERVICE (already set in the systemd service file and Docker image). Also removed a global asyncio set_exception_handler() in the MQTT server that was overwritten by each VP instance, causing spurious "Unhandled exception in client_connected_cb" errors on startup. Changes: - FTP_PORT: 9990 → 990 (ftp_server.py) - Removed set_exception_handler() from MQTT server - Updated Dockerfile, docker-compose.yml port mappings - Deprecated --redirect-990 in install script - Updated wiki: removed iptables instructions for all platforms - Added migration guide (docs/migration-vp-ftp-port.md) - Added unit tests for port constant and no-global-state invariant
52 lines
2.0 KiB
YAML
52 lines
2.0 KiB
YAML
services:
|
|
bambuddy:
|
|
image: ghcr.io/maziggy/bambuddy:latest
|
|
build: .
|
|
# Usage:
|
|
# docker compose up -d → pulls pre-built image from ghcr.io
|
|
# docker compose up -d --build → builds locally from source
|
|
container_name: bambuddy
|
|
# Run as current user to avoid permission issues with mounted volumes
|
|
# Override with: PUID=$(id -u) PGID=$(id -g) docker compose up -d
|
|
user: "${PUID:-1000}:${PGID:-1000}"
|
|
#
|
|
# Proxy mode: allow binding to port 990 (FTP) as non-root user.
|
|
# Without this, the FTP proxy silently fails and sending prints won't work.
|
|
cap_add:
|
|
- NET_BIND_SERVICE
|
|
#
|
|
# LINUX: Use host mode for printer discovery and camera streaming
|
|
network_mode: host
|
|
#
|
|
# macOS/WINDOWS: Docker Desktop doesn't support host mode.
|
|
# Comment out "network_mode: host" above and uncomment "ports:" below.
|
|
# Note: Printer discovery won't work - add printers manually by IP.
|
|
#ports:
|
|
# - "${PORT:-8000}:8000"
|
|
# - "3000:3000" # Virtual printer bind/detect
|
|
# - "3002:3002" # Virtual printer bind/detect
|
|
# - "8883:8883" # Virtual printer MQTT
|
|
# - "990:990" # Virtual printer FTP control
|
|
# - "50000-50100:50000-50100" # Virtual printer FTP passive data
|
|
volumes:
|
|
- bambuddy_data:/app/data
|
|
- bambuddy_logs:/app/logs
|
|
#
|
|
# Share virtual printer certs with native installation
|
|
# This ensures the slicer only needs to trust one CA certificate.
|
|
- ./virtual_printer:/app/data/virtual_printer
|
|
environment:
|
|
- TZ=${TZ:-Europe/Berlin}
|
|
# Port BamBuddy runs on (default: 8000)
|
|
# Usage: PORT=8080 docker compose up -d
|
|
- PORT=${PORT:-8000}
|
|
# Virtual printer: Set to the Docker host's IP when using bridge mode (ports:).
|
|
# Required for FTP passive mode to work behind NAT.
|
|
# Example: VIRTUAL_PRINTER_PASV_ADDRESS=192.168.1.100
|
|
#- VIRTUAL_PRINTER_PASV_ADDRESS=
|
|
restart: unless-stopped
|
|
|
|
volumes:
|
|
bambuddy_data:
|
|
bambuddy_logs:
|