mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-10-03 20:56:18 +02:00
Backfill 276 missing translations across fr / it / ja / pt-BR so all
8 shipped locales now match en. Most gaps come from features that
landed with en+de+zh translations only:
- login.resetPassword.* (12 × 3): fr, it, ja
- printers.firmwareModal.* (7 × 4): all locales
- settings.spoolbuddy.* (~40 × 3, plus 18 in ja): admin device-
control block (unregister / reboot / shutdown / update /
restart confirms)
- spoolbuddy.settings.* (13 × 4): kiosk backend & auth + diagnostics
- virtualPrinter.archiveNameSource.* (4 × 4): from this release
Also fixes 27 ja and 1 fr placeholder-name mismatches that silently
broke interpolation at runtime — e.g. printers.activeNozzle used
{{side}} while the runtime passes nozzle, and several keys had
{{count}} dropped entirely so the value would never render.
Drop the STRICT / info two-tier machinery from check-i18n-parity.mjs:
en is the reference, every other locale is checked identically,
any drift fails CI. The previous tier was just deferred policy, no
real distinction.
All 8 locales now sit at 4492 leaves. Parity script, i18n test suite
(11 tests), and full frontend build all green.
208 lines
8.2 KiB
JavaScript
208 lines
8.2 KiB
JavaScript
// Verifies parity across locale files (en / zh-CN / zh-TW):
|
|
// 1. Leaf-key sets are identical
|
|
// 2. Each leaf's {{placeholder}} set is identical
|
|
// 3. Plural suffixes: every en key ending in _plural / _one / _other must
|
|
// exist in every other locale, and other locales must not introduce an
|
|
// _one key that en does not have.
|
|
// Malformed input (missing `export default`, parse errors, non-string leaves,
|
|
// unsupported property kinds) fails loudly instead of silently passing the gate.
|
|
// Exits 1 with a diagnostic report on any failure, else exits 0.
|
|
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import url from 'node:url';
|
|
|
|
const scriptDir = path.dirname(url.fileURLToPath(import.meta.url));
|
|
const frontendDir = path.resolve(scriptDir, '..');
|
|
const localesDir = path.join(frontendDir, 'src/i18n/locales');
|
|
const tsPath = path.join(frontendDir, 'node_modules/typescript/lib/typescript.js');
|
|
|
|
const tsModule = await import(url.pathToFileURL(tsPath).href);
|
|
const ts = tsModule.default ?? tsModule;
|
|
|
|
function collectLeaves(node, prefix, leaves) {
|
|
if (!ts.isObjectLiteralExpression(node)) return;
|
|
for (const prop of node.properties) {
|
|
if (!ts.isPropertyAssignment(prop)) {
|
|
console.error(
|
|
`Unsupported property kind ${ts.SyntaxKind[prop.kind]} at "${prefix}" ` +
|
|
`(locale files must use plain \`key: value\` assignments — no spread, shorthand, methods, or accessors).`,
|
|
);
|
|
process.exit(1);
|
|
}
|
|
let name;
|
|
if (ts.isIdentifier(prop.name)) name = prop.name.text;
|
|
else if (ts.isStringLiteral(prop.name) || ts.isNoSubstitutionTemplateLiteral(prop.name)) name = prop.name.text;
|
|
else if (ts.isComputedPropertyName(prop.name)) {
|
|
console.error(`ComputedPropertyName not allowed in locale file at path "${prefix}"`);
|
|
process.exit(1);
|
|
} else {
|
|
console.error(`Unsupported property-name kind ${ts.SyntaxKind[prop.name.kind]} at "${prefix}"`);
|
|
process.exit(1);
|
|
}
|
|
const p = prefix ? `${prefix}.${name}` : name;
|
|
if (ts.isObjectLiteralExpression(prop.initializer)) {
|
|
collectLeaves(prop.initializer, p, leaves);
|
|
} else {
|
|
const value = extractStringValue(prop.initializer, p);
|
|
leaves.set(p, value);
|
|
}
|
|
}
|
|
}
|
|
|
|
function extractStringValue(node, keyPath) {
|
|
if (ts.isStringLiteral(node) || ts.isNoSubstitutionTemplateLiteral(node)) return node.text;
|
|
if (ts.isTemplateExpression(node)) {
|
|
let out = node.head.text;
|
|
for (const span of node.templateSpans) {
|
|
out += '${' + span.expression.getText() + '}';
|
|
out += span.literal.text;
|
|
}
|
|
return out;
|
|
}
|
|
console.error(
|
|
`Non-string leaf at "${keyPath}" (kind=${ts.SyntaxKind[node.kind]}): ${node.getText()}\n` +
|
|
`Locale files must only contain string or template literals as leaf values.`,
|
|
);
|
|
process.exit(1);
|
|
}
|
|
|
|
function loadLocale(filePath) {
|
|
const src = fs.readFileSync(filePath, 'utf8');
|
|
const sf = ts.createSourceFile(filePath, src, ts.ScriptTarget.Latest, true);
|
|
if (sf.parseDiagnostics && sf.parseDiagnostics.length > 0) {
|
|
console.error(`${filePath}: ${sf.parseDiagnostics.length} parse error(s):`);
|
|
for (const d of sf.parseDiagnostics.slice(0, 10)) {
|
|
const msg = typeof d.messageText === 'string' ? d.messageText : d.messageText.messageText;
|
|
const { line, character } = sf.getLineAndCharacterOfPosition(d.start ?? 0);
|
|
console.error(` ${line + 1}:${character + 1} ${msg}`);
|
|
}
|
|
process.exit(1);
|
|
}
|
|
const leaves = new Map();
|
|
let foundExport = false;
|
|
ts.forEachChild(sf, (n) => {
|
|
if (ts.isExportAssignment(n)) {
|
|
foundExport = true;
|
|
collectLeaves(n.expression, '', leaves);
|
|
}
|
|
});
|
|
if (!foundExport) {
|
|
console.error(`${filePath}: no \`export default\` found — locale files must use \`export default { ... }\`.`);
|
|
process.exit(1);
|
|
}
|
|
if (leaves.size === 0) {
|
|
console.error(`${filePath}: \`export default\` resolved to zero leaves — file is empty or not a nested object.`);
|
|
process.exit(1);
|
|
}
|
|
return leaves;
|
|
}
|
|
|
|
const placeholderRe = /\{\{[^{}]+\}\}/g;
|
|
|
|
// Pure comparison logic, exported so tests can verify each failure mode
|
|
// without going through file IO or the TypeScript parser.
|
|
// Input: locales = { code: Map<leafKey, leafString> } (must contain 'en')
|
|
// Output: { failed, reports: Array<{ label, items }> }
|
|
export function compareLocales(locales) {
|
|
if (!locales.en) throw new Error("compareLocales requires a locales.en entry");
|
|
const reports = [];
|
|
const add = (label, items) => {
|
|
if (items.length) reports.push({ label, items });
|
|
};
|
|
|
|
const enKeys = new Set(locales.en.keys());
|
|
|
|
// Check 1: key set equality
|
|
for (const [code, map] of Object.entries(locales)) {
|
|
if (code === 'en') continue;
|
|
const keys = new Set(map.keys());
|
|
const missing = [...enKeys].filter((k) => !keys.has(k)).sort();
|
|
const extra = [...keys].filter((k) => !enKeys.has(k)).sort();
|
|
add(`${code}: missing keys vs en`, missing);
|
|
add(`${code}: extra keys vs en`, extra);
|
|
}
|
|
|
|
// Check 2: placeholder set equality per leaf
|
|
for (const [code, map] of Object.entries(locales)) {
|
|
if (code === 'en') continue;
|
|
const mismatches = [];
|
|
for (const [key, enValue] of locales.en) {
|
|
const otherValue = map.get(key);
|
|
if (otherValue === undefined) continue;
|
|
const enPlaceholders = new Set((enValue.match(placeholderRe) ?? []));
|
|
const otherPlaceholders = new Set((otherValue.match(placeholderRe) ?? []));
|
|
const missingPh = [...enPlaceholders].filter((p) => !otherPlaceholders.has(p));
|
|
const extraPh = [...otherPlaceholders].filter((p) => !enPlaceholders.has(p));
|
|
if (missingPh.length || extraPh.length) {
|
|
mismatches.push(`${key}: en=${[...enPlaceholders].join(',') || '∅'} vs ${code}=${[...otherPlaceholders].join(',') || '∅'}`);
|
|
}
|
|
}
|
|
add(`${code}: placeholder mismatch vs en`, mismatches);
|
|
}
|
|
|
|
// Check 3: plural suffix presence + reverse _one guard
|
|
for (const [code, map] of Object.entries(locales)) {
|
|
if (code === 'en') continue;
|
|
const pluralIssues = [];
|
|
for (const key of enKeys) {
|
|
if (key.endsWith('_plural') && !map.has(key)) pluralIssues.push(`missing _plural key: ${key}`);
|
|
if (key.endsWith('_one') && !map.has(key)) pluralIssues.push(`missing _one key: ${key}`);
|
|
if (key.endsWith('_other') && !map.has(key)) pluralIssues.push(`missing _other key: ${key}`);
|
|
}
|
|
for (const key of map.keys()) {
|
|
if (key.endsWith('_one') && !enKeys.has(key)) {
|
|
pluralIssues.push(`unexpected _one not present in en: ${key}`);
|
|
}
|
|
}
|
|
add(`${code}: plural key mismatch`, pluralIssues);
|
|
}
|
|
|
|
return { failed: reports.length > 0, reports };
|
|
}
|
|
|
|
// en is the reference locale; every other locale discovered in the locales
|
|
// directory is checked identically and a drift in any of them fails CI.
|
|
// Skip file IO / process.exit when imported as a library (e.g. from tests).
|
|
const isMainModule = import.meta.url === url.pathToFileURL(process.argv[1] ?? '').href;
|
|
if (isMainModule) {
|
|
const discovered = fs
|
|
.readdirSync(localesDir)
|
|
.filter((f) => f.endsWith('.ts'))
|
|
.map((f) => f.slice(0, -3))
|
|
.sort();
|
|
if (!discovered.includes('en')) {
|
|
console.error(`No en.ts found in ${localesDir} — cannot run parity check without a reference locale.`);
|
|
process.exit(1);
|
|
}
|
|
const codes = ['en', ...discovered.filter((c) => c !== 'en')];
|
|
const locales = Object.fromEntries(
|
|
codes.map((c) => [c, loadLocale(path.join(localesDir, `${c}.ts`))]),
|
|
);
|
|
|
|
const MAX_REPORT = 20;
|
|
const { reports } = compareLocales(locales);
|
|
|
|
if (reports.length) {
|
|
console.error(`\n=== Locale parity failures (en is the reference) ===`);
|
|
for (const { label, items } of reports) {
|
|
console.error(`\n[${label}] (${items.length})`);
|
|
items.slice(0, MAX_REPORT).forEach((i) => console.error(` ${i}`));
|
|
if (items.length > MAX_REPORT) console.error(` ... and ${items.length - MAX_REPORT} more`);
|
|
}
|
|
}
|
|
|
|
console.log('\nLocale leaf counts:');
|
|
for (const [code, map] of Object.entries(locales)) {
|
|
const tier = code === 'en' ? 'ref' : 'locale';
|
|
console.log(` ${code.padEnd(6)} ${String(map.size).padEnd(6)} [${tier}]`);
|
|
}
|
|
|
|
if (reports.length > 0) {
|
|
console.error(`\n❌ i18n parity check failed.`);
|
|
process.exit(1);
|
|
}
|
|
const others = codes.filter((c) => c !== 'en');
|
|
console.log(`\n✓ All locales in parity with en (${others.join(' / ')}).`);
|
|
}
|