Files
bambuddy/backend/app/services/camera_fanout.py
T
maziggy 1e3ad697f2 fix(#1089): camera stream fan-out broadcaster
Most Bambu Lab printers only allow one concurrent camera connection, but
  GET /printers/{id}/camera/stream opened a fresh upstream per viewer.
  Two browser tabs → second viewer fails or kicks the first off.

  New MjpegBroadcaster (services/camera_fanout.py) owns one upstream per
  printer and fans MJPEG chunks out to N subscribers. 5 s grace window
  absorbs tab refreshes without reconnecting. Bounded subscriber queues
  drop frames for slow viewers rather than blocking the broadcaster.

  Audit-pass fixes:
  - _stream_start_times set with setdefault() so stream_uptime reflects
    the shared upstream's age, not the most-recent viewer's
  - subscribe() retried once on RuntimeError to close a tiny grace race
  - unsubscribe() returns post-removal count atomically so the detach log
    no longer races with concurrent leavers

  Permission gates unchanged; broadcaster has no FastAPI surface.

  Tests: 13 broadcaster unit tests + 2 integration tests on /camera/stop.
  External-camera path untouched.
2026-04-25 09:56:45 +02:00

281 lines
11 KiB
Python

"""MJPEG fan-out broadcaster for camera streams.
Most Bambu Lab printers only allow one concurrent camera connection: the
RTSP socket on X1/H2/P2 models, the chamber-image socket on port 6000 on
A1/P1 models. Without fan-out, opening a second viewer either fails or
kicks the first viewer off — see issue #1089.
This module owns a single upstream connection per printer and pushes each
frame to N independent subscriber queues. New viewers tap the existing
upstream; no new printer connection is opened. When the last subscriber
leaves, the upstream is torn down after a short grace window so that a
quick page refresh or second-tab open does not pay a reconnect.
"""
from __future__ import annotations
import asyncio
import logging
from collections.abc import AsyncGenerator, Awaitable, Callable
logger = logging.getLogger(__name__)
# How long to keep the upstream pump alive after the last subscriber leaves.
# A short grace window absorbs page refreshes and "open camera in new tab"
# without paying a fresh ffmpeg/RTSP handshake (which can take several seconds
# on some firmwares and is the very reconnect cost we are trying to avoid).
_GRACE_SECONDS = 5.0
# Per-subscriber queue depth. Small on purpose: if a viewer can't keep up
# with the printer's frame rate we drop frames for that viewer rather than
# blocking the broadcaster. Live video — old frames have no value.
_SUBSCRIBER_QUEUE_SIZE = 4
# Sentinel pushed to subscriber queues when the upstream pump exits, so each
# subscriber's read loop can break out cleanly instead of hanging on get().
_UPSTREAM_GONE = b""
UpstreamFactory = Callable[[asyncio.Event], AsyncGenerator[bytes, None]]
class MjpegBroadcaster:
"""Single upstream MJPEG stream, fanned out to N subscribers."""
def __init__(self, key: str, factory: UpstreamFactory) -> None:
self._key = key
self._factory = factory
self._subscribers: list[asyncio.Queue[bytes]] = []
self._lock = asyncio.Lock()
self._pump_task: asyncio.Task | None = None
self._grace_task: asyncio.Task | None = None
# Disconnect event passed to the upstream generator so we can ask it to
# stop reconnecting when the last subscriber leaves.
self._upstream_disconnect = asyncio.Event()
self._stopped = False
@property
def key(self) -> str:
return self._key
@property
def subscriber_count(self) -> int:
return len(self._subscribers)
@property
def stopped(self) -> bool:
return self._stopped
async def subscribe(self) -> asyncio.Queue[bytes]:
"""Add a subscriber and ensure the upstream pump is running."""
async with self._lock:
if self._stopped:
raise RuntimeError(f"broadcaster {self._key!r} is stopped")
# Cancel any pending grace-window shutdown — a viewer just rejoined.
if self._grace_task is not None and not self._grace_task.done():
self._grace_task.cancel()
self._grace_task = None
queue: asyncio.Queue[bytes] = asyncio.Queue(maxsize=_SUBSCRIBER_QUEUE_SIZE)
self._subscribers.append(queue)
if self._pump_task is None or self._pump_task.done():
# Reset the disconnect signal in case a previous pump set it.
self._upstream_disconnect = asyncio.Event()
self._pump_task = asyncio.create_task(self._pump(), name=f"camera-fanout-pump-{self._key}")
return queue
async def unsubscribe(self, queue: asyncio.Queue[bytes]) -> int:
"""Remove a subscriber and return the remaining count (atomic).
If this was the last subscriber, schedule grace shutdown.
"""
async with self._lock:
try:
self._subscribers.remove(queue)
except ValueError:
return len(self._subscribers) # Already removed (e.g. force_shutdown)
remaining = len(self._subscribers)
if remaining == 0 and not self._stopped:
# Last subscriber left. Schedule grace-window teardown.
self._grace_task = asyncio.create_task(self._grace_then_stop(), name=f"camera-fanout-grace-{self._key}")
return remaining
async def force_shutdown(self) -> None:
"""Tear down immediately, kick all subscribers. Idempotent."""
pump_task = await self._mark_stopped_locked(notify_subscribers=True)
await self._await_pump_cancellation(pump_task)
async def _grace_then_stop(self) -> None:
try:
await asyncio.sleep(_GRACE_SECONDS)
except asyncio.CancelledError:
return # New subscriber arrived during grace
# Re-check under the lock — a subscriber may have rejoined between
# the sleep finishing and us acquiring the lock.
pump_task: asyncio.Task | None = None
async with self._lock:
if self._subscribers or self._stopped:
return
self._upstream_disconnect.set()
pump_task = self._pump_task
self._pump_task = None
self._grace_task = None
self._stopped = True
await self._await_pump_cancellation(pump_task)
async def _mark_stopped_locked(self, *, notify_subscribers: bool) -> asyncio.Task | None:
"""Mark the broadcaster stopped and detach the pump task.
Caller MUST NOT hold ``self._lock`` (we acquire it here). Returns the
pump task (if any) so the caller can await its cancellation OUTSIDE
the lock — the pump's ``finally`` block needs the lock to wake up
subscribers, so we'd deadlock if we awaited it under the lock.
"""
async with self._lock:
if self._stopped and self._pump_task is None:
return None
self._upstream_disconnect.set()
if notify_subscribers:
for queue in self._subscribers:
try:
queue.put_nowait(_UPSTREAM_GONE)
except asyncio.QueueFull:
pass
self._subscribers.clear()
pump_task = self._pump_task
self._pump_task = None
self._stopped = True
if self._grace_task is not None and not self._grace_task.done():
self._grace_task.cancel()
self._grace_task = None
return pump_task
async def _await_pump_cancellation(self, pump_task: asyncio.Task | None) -> None:
if pump_task is None or pump_task.done():
return
pump_task.cancel()
try:
await pump_task
except (asyncio.CancelledError, Exception):
# Pump exceptions are already logged inside _pump; swallow here so
# teardown can never propagate a stray crash.
pass
async def _pump(self) -> None:
"""Drive the upstream generator and broadcast each chunk."""
try:
async for chunk in self._factory(self._upstream_disconnect):
# Snapshot subscribers under lock so we don't iterate a list
# mutated by subscribe()/unsubscribe() while we are putting.
async with self._lock:
targets = list(self._subscribers)
for queue in targets:
try:
queue.put_nowait(chunk)
except asyncio.QueueFull:
# Slow viewer — drop this frame for them. They'll catch
# up on the next frame. Don't unsubscribe: a brief
# browser stall shouldn't end the stream.
pass
except asyncio.CancelledError:
raise
except Exception:
logger.exception("Camera fan-out pump crashed for %s", self._key)
finally:
# Pump is exiting — wake up any subscribers still hanging on get().
async with self._lock:
for queue in self._subscribers:
try:
queue.put_nowait(_UPSTREAM_GONE)
except asyncio.QueueFull:
pass
# Global registry. Keyed by printer_id (as str) so a chamber-mode printer
# and an RTSP-mode printer can never collide on the same key.
_broadcasters: dict[str, MjpegBroadcaster] = {}
_registry_lock = asyncio.Lock()
async def get_or_create_broadcaster(key: str, factory: UpstreamFactory) -> MjpegBroadcaster:
"""Return the live broadcaster for `key`, creating one if needed.
A broadcaster that has been stopped (force shutdown or grace timeout) is
replaced with a fresh instance — the caller will subscribe to the new one.
"""
async with _registry_lock:
existing = _broadcasters.get(key)
if existing is not None and not existing.stopped:
return existing
new_bc = MjpegBroadcaster(key, factory)
_broadcasters[key] = new_bc
return new_bc
async def shutdown_broadcaster(key: str) -> bool:
"""Force-shutdown the broadcaster for `key`. Returns True if one was running."""
async with _registry_lock:
bc = _broadcasters.pop(key, None)
if bc is None:
return False
await bc.force_shutdown()
return True
async def shutdown_all_broadcasters() -> None:
"""Tear down every broadcaster (for app shutdown)."""
async with _registry_lock:
bcs = list(_broadcasters.values())
_broadcasters.clear()
await asyncio.gather(*(bc.force_shutdown() for bc in bcs), return_exceptions=True)
def active_broadcaster_keys() -> list[str]:
"""Snapshot of keys with a live (non-stopped) broadcaster. For diagnostics."""
return [k for k, bc in _broadcasters.items() if not bc.stopped]
# ---------------------------------------------------------------------------
# AsyncGenerator helper — turns a subscriber queue into an async generator
# that yields MJPEG chunks until the upstream signals it's gone.
# ---------------------------------------------------------------------------
async def iter_subscriber(
broadcaster: MjpegBroadcaster,
queue: asyncio.Queue[bytes],
*,
is_disconnected: Callable[[], Awaitable[bool]] | None = None,
on_unsubscribe: Callable[[int], None] | None = None,
) -> AsyncGenerator[bytes, None]:
"""Yield chunks from a subscriber queue until upstream ends or client leaves.
Always unsubscribes from the broadcaster on exit, even on cancellation.
The optional ``on_unsubscribe`` callback receives the post-unsubscribe
subscriber count — useful for accurate detach-log lines that don't race
with concurrent unsubscribes.
"""
try:
while True:
try:
chunk = await asyncio.wait_for(queue.get(), timeout=30.0)
except asyncio.TimeoutError:
# No frame in 30s — check whether the client is still there.
# If yes, keep waiting; if no, bail out.
if is_disconnected is not None and await is_disconnected():
break
continue
if chunk == _UPSTREAM_GONE:
break
yield chunk
if is_disconnected is not None and await is_disconnected():
break
finally:
remaining = await broadcaster.unsubscribe(queue)
if on_unsubscribe is not None:
try:
on_unsubscribe(remaining)
except Exception:
logger.exception("on_unsubscribe callback raised")