mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-09-30 03:01:21 +02:00
maziggy
7d4dfd5a7d
Native (non-Docker) installs launched uvicorn without --loop asyncio, so uvicorn[standard] auto-selected uvloop. uvloop's SSL layer drops already-received but still-buffered data when the client closes the data connection without a TLS close_notify while the reader is flow-control paused on slow storage. cmd_STOR writes each chunk to disk inside the read loop, so a slow consumer falls behind, the tail is lost, read() returns a clean EOF, and the loop exits with no exception -- the server acked 226 for a file it truncated itself, then archived, queued, and forwarded the corrupt 3MF to the real printer. Fix in two independent layers: 1. Remove the trigger: add --loop asyncio to every native launch path, matching the Dockerfile -- deploy/bambuddy.service, install/install.sh (systemd + launchd), spoolbuddy/install/install.sh, the Windows NSSM service, README, CONTRIBUTING dev command. 2. Defense in depth (loop-independent): cmd_STOR now validates that a received .3mf opens as a ZIP (reads the central directory, no decompression) before replying 226. A truncated/corrupt file is dropped and answered with 426, and on_file_received never runs -- so a broken upload surfaces as an immediate slicer-side send error instead of being archived and pushed to the printer. Scoped to .3mf; other filetypes pass through unchanged.
77 lines
2.7 KiB
Batchfile
77 lines
2.7 KiB
Batchfile
@echo off
|
|
REM Register Bambuddy as a Windows service via NSSM.
|
|
REM
|
|
REM Called from Inno Setup's [Run] section. Arguments:
|
|
REM %1 = install dir (e.g. C:\Program Files\Bambuddy)
|
|
REM %2 = data dir (e.g. C:\ProgramData\Bambuddy)
|
|
REM %3 = port (e.g. 8000)
|
|
REM
|
|
REM If the service already exists (re-install / upgrade), remove and
|
|
REM re-create it so config changes from this build apply.
|
|
|
|
setlocal
|
|
|
|
set "INSTALL_DIR=%~1"
|
|
set "DATA_ROOT=%~2"
|
|
set "PORT=%~3"
|
|
|
|
set "NSSM=%INSTALL_DIR%\bin\nssm.exe"
|
|
set "PYTHON=%INSTALL_DIR%\python\python.exe"
|
|
set "APP_DIR=%INSTALL_DIR%\app"
|
|
set "BIN_DIR=%INSTALL_DIR%\bin"
|
|
set "DATA_DIR=%DATA_ROOT%\data"
|
|
set "LOG_DIR=%DATA_ROOT%\logs"
|
|
|
|
REM Stop and remove any previous registration. Errors are non-fatal —
|
|
REM "service not found" returns non-zero and we want to proceed.
|
|
"%NSSM%" stop Bambuddy 2>nul
|
|
"%NSSM%" remove Bambuddy confirm 2>nul
|
|
|
|
REM Register the service. NSSM wraps uvicorn so Windows treats it as a
|
|
REM proper service (autostart, recovery, supervised restart).
|
|
REM --loop asyncio required: uvloop can truncate VP FTP uploads (#1896).
|
|
"%NSSM%" install Bambuddy "%PYTHON%" "-m uvicorn backend.app.main:app --host 0.0.0.0 --port %PORT% --loop asyncio"
|
|
if errorlevel 1 (
|
|
echo [install-service] nssm install failed
|
|
exit /b 1
|
|
)
|
|
|
|
REM Service configuration
|
|
"%NSSM%" set Bambuddy AppDirectory "%APP_DIR%"
|
|
"%NSSM%" set Bambuddy DisplayName "Bambuddy"
|
|
"%NSSM%" set Bambuddy Description "Bambuddy — local-first Bambu Lab printer manager"
|
|
"%NSSM%" set Bambuddy Start SERVICE_AUTO_START
|
|
|
|
REM Environment: point DATA_DIR + LOG_DIR at ProgramData, prepend our
|
|
REM bin/ to PATH so ffmpeg/ffprobe are found by the shutil.which() lookup
|
|
REM in backend/app/services/layer_timelapse.py.
|
|
"%NSSM%" set Bambuddy AppEnvironmentExtra ^
|
|
"DATA_DIR=%DATA_DIR%" ^
|
|
"LOG_DIR=%LOG_DIR%" ^
|
|
"PORT=%PORT%" ^
|
|
"PATH=%BIN_DIR%;%PATH%"
|
|
|
|
REM Stdout / stderr capture. Rotate at 10MB.
|
|
"%NSSM%" set Bambuddy AppStdout "%LOG_DIR%\service-stdout.log"
|
|
"%NSSM%" set Bambuddy AppStderr "%LOG_DIR%\service-stderr.log"
|
|
"%NSSM%" set Bambuddy AppRotateFiles 1
|
|
"%NSSM%" set Bambuddy AppRotateOnline 1
|
|
"%NSSM%" set Bambuddy AppRotateBytes 10485760
|
|
|
|
REM Run as LocalSystem (default). Required for binding 322/990/8883 if
|
|
REM the user later enables the Virtual Printer feature. Most non-VP
|
|
REM workloads would work as a less-privileged account, but service
|
|
REM identity changes are disruptive — pick the broader one once.
|
|
|
|
REM Start the service. If it fails to start, NSSM exits non-zero and
|
|
REM Inno Setup will surface this to the user.
|
|
"%NSSM%" start Bambuddy
|
|
if errorlevel 1 (
|
|
echo [install-service] nssm start failed — check %LOG_DIR%\service-stderr.log
|
|
exit /b 1
|
|
)
|
|
|
|
echo [install-service] Bambuddy service registered and started on port %PORT%
|
|
endlocal
|
|
exit /b 0
|