Files
bambuddy/backend/tests/integration/test_printers_api.py
T
maziggy 7b39026429 fix: resolve PFUS preset IDs causing slicer slot resets + fill level for new spools
BambuStudio actively resets AMS slots configured with unrecognized PFUS*
(user-local) preset IDs. Replace PFUS* with generic Bambu filament IDs
(e.g. GFL99 for PLA) in both the slot configure and inventory assignment
endpoints. When the slot already has a recognized cloud-synced preset for
the same material, reuse it to preserve K-profile calibration.

Also fix fill level bar not showing for brand new spools (weight_used=0)
by changing the condition from weight_used > 0 to weight_used != null.
2026-02-19 12:54:15 +01:00

1176 lines
48 KiB
Python

"""Integration tests for Printers API endpoints.
Tests the full request/response cycle for /api/v1/printers/ endpoints.
"""
from unittest.mock import MagicMock, patch
import pytest
from httpx import AsyncClient
class TestPrintersAPI:
"""Integration tests for /api/v1/printers/ endpoints."""
# ========================================================================
# List endpoints
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_list_printers_empty(self, async_client: AsyncClient):
"""Verify empty list is returned when no printers exist."""
response = await async_client.get("/api/v1/printers/")
assert response.status_code == 200
assert response.json() == []
@pytest.mark.asyncio
@pytest.mark.integration
async def test_list_printers_with_data(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify list returns existing printers."""
await printer_factory(name="Test Printer")
response = await async_client.get("/api/v1/printers/")
assert response.status_code == 200
data = response.json()
assert len(data) >= 1
assert any(p["name"] == "Test Printer" for p in data)
# ========================================================================
# Create endpoints
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_printer(self, async_client: AsyncClient):
"""Verify printer can be created."""
data = {
"name": "New Printer",
"serial_number": "00M09A111111111",
"ip_address": "192.168.1.100",
"access_code": "12345678",
"is_active": True,
"model": "X1C",
}
response = await async_client.post("/api/v1/printers/", json=data)
assert response.status_code == 200
result = response.json()
assert result["name"] == "New Printer"
assert result["serial_number"] == "00M09A111111111"
assert result["model"] == "X1C"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_printer_with_hostname(self, async_client: AsyncClient):
"""Verify printer can be created with a hostname instead of IP address."""
data = {
"name": "DNS Printer",
"serial_number": "00M09A555555555",
"ip_address": "printer.local",
"access_code": "12345678",
"model": "P1S",
}
response = await async_client.post("/api/v1/printers/", json=data)
assert response.status_code == 200
result = response.json()
assert result["name"] == "DNS Printer"
assert result["ip_address"] == "printer.local"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_printer_with_fqdn(self, async_client: AsyncClient):
"""Verify printer can be created with a fully qualified domain name."""
data = {
"name": "FQDN Printer",
"serial_number": "00M09A666666666",
"ip_address": "my-printer.home.lan",
"access_code": "12345678",
"model": "X1C",
}
response = await async_client.post("/api/v1/printers/", json=data)
assert response.status_code == 200
result = response.json()
assert result["ip_address"] == "my-printer.home.lan"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_printer_invalid_hostname(self, async_client: AsyncClient):
"""Verify invalid hostnames are rejected."""
data = {
"name": "Bad Printer",
"serial_number": "00M09A777777777",
"ip_address": "-invalid",
"access_code": "12345678",
}
response = await async_client.post("/api/v1/printers/", json=data)
assert response.status_code == 422
@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_printer_duplicate_serial(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify duplicate serial number is rejected."""
await printer_factory(serial_number="00M09A222222222")
data = {
"name": "Duplicate Printer",
"serial_number": "00M09A222222222",
"ip_address": "192.168.1.101",
"access_code": "12345678",
}
response = await async_client.post("/api/v1/printers/", json=data)
# Should fail due to duplicate serial
assert response.status_code in [400, 409, 422, 500]
# ========================================================================
# Get single endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_printer(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify single printer can be retrieved."""
printer = await printer_factory(name="Get Test Printer")
response = await async_client.get(f"/api/v1/printers/{printer.id}")
assert response.status_code == 200
result = response.json()
assert result["id"] == printer.id
assert result["name"] == "Get Test Printer"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_printer_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.get("/api/v1/printers/9999")
assert response.status_code == 404
# ========================================================================
# Update endpoints
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_update_printer_name(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify printer name can be updated."""
printer = await printer_factory(name="Original Name")
response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"name": "Updated Name"})
assert response.status_code == 200
assert response.json()["name"] == "Updated Name"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_update_printer_active_status(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify printer active status can be updated."""
printer = await printer_factory(is_active=True)
response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"is_active": False})
assert response.status_code == 200
assert response.json()["is_active"] is False
@pytest.mark.asyncio
@pytest.mark.integration
async def test_update_printer_auto_archive(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify auto_archive setting can be updated."""
printer = await printer_factory(auto_archive=True)
response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"auto_archive": False})
assert response.status_code == 200
assert response.json()["auto_archive"] is False
@pytest.mark.asyncio
@pytest.mark.integration
async def test_update_nonexistent_printer(self, async_client: AsyncClient):
"""Verify updating non-existent printer returns 404."""
response = await async_client.patch("/api/v1/printers/9999", json={"name": "New Name"})
assert response.status_code == 404
# ========================================================================
# Delete endpoints
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_delete_printer(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify printer can be deleted."""
printer = await printer_factory()
printer_id = printer.id
response = await async_client.delete(f"/api/v1/printers/{printer_id}")
assert response.status_code == 200
# Verify deleted
response = await async_client.get(f"/api/v1/printers/{printer_id}")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_delete_nonexistent_printer(self, async_client: AsyncClient):
"""Verify deleting non-existent printer returns 404."""
response = await async_client.delete("/api/v1/printers/9999")
assert response.status_code == 404
# ========================================================================
# Status endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_printer_status(
self, async_client: AsyncClient, printer_factory, mock_printer_manager, db_session
):
"""Verify printer status can be retrieved."""
printer = await printer_factory()
response = await async_client.get(f"/api/v1/printers/{printer.id}/status")
assert response.status_code == 200
result = response.json()
assert "connected" in result
assert "state" in result
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_printer_status_not_found(self, async_client: AsyncClient):
"""Verify 404 for status of non-existent printer."""
response = await async_client.get("/api/v1/printers/9999/status")
assert response.status_code == 404
# ========================================================================
# Test connection endpoint
# ========================================================================
class TestPrinterDataIntegrity:
"""Tests for printer data integrity."""
@pytest.mark.asyncio
@pytest.mark.integration
async def test_printer_stores_all_fields(self, async_client: AsyncClient, printer_factory, db_session):
"""Verify printer stores all fields correctly."""
printer = await printer_factory(
name="Full Test Printer",
serial_number="00M09A444444444",
ip_address="192.168.1.150",
model="P1S",
is_active=True,
auto_archive=False,
)
response = await async_client.get(f"/api/v1/printers/{printer.id}")
assert response.status_code == 200
result = response.json()
assert result["name"] == "Full Test Printer"
assert result["serial_number"] == "00M09A444444444"
assert result["ip_address"] == "192.168.1.150"
assert result["model"] == "P1S"
assert result["is_active"] is True
assert result["auto_archive"] is False
@pytest.mark.asyncio
@pytest.mark.integration
async def test_printer_update_persists(self, async_client: AsyncClient, printer_factory, db_session):
"""CRITICAL: Verify printer updates persist."""
printer = await printer_factory(name="Original", is_active=True)
# Update
await async_client.patch(f"/api/v1/printers/{printer.id}", json={"name": "Updated", "is_active": False})
# Verify persistence
response = await async_client.get(f"/api/v1/printers/{printer.id}")
result = response.json()
assert result["name"] == "Updated"
assert result["is_active"] is False
# ========================================================================
# Refresh status endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_refresh_status_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/refresh-status")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_refresh_status_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify 400 when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.request_status_update.return_value = False
response = await async_client.post(f"/api/v1/printers/{printer.id}/refresh-status")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_refresh_status_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful refresh request."""
printer = await printer_factory(name="Connected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.request_status_update.return_value = True
response = await async_client.post(f"/api/v1/printers/{printer.id}/refresh-status")
assert response.status_code == 200
assert response.json()["status"] == "refresh_requested"
mock_pm.request_status_update.assert_called_once_with(printer.id)
# ========================================================================
# Current print user endpoint (Issue #206)
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_current_print_user_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.get("/api/v1/printers/99999/current-print-user")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_current_print_user_returns_empty_when_no_user(self, async_client: AsyncClient, printer_factory):
"""Verify empty object returned when no user is tracked."""
printer = await printer_factory(name="Test Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_current_print_user.return_value = None
response = await async_client.get(f"/api/v1/printers/{printer.id}/current-print-user")
assert response.status_code == 200
assert response.json() == {}
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_current_print_user_returns_user_info(self, async_client: AsyncClient, printer_factory):
"""Verify user info is returned when tracked."""
printer = await printer_factory(name="Test Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_current_print_user.return_value = {"user_id": 42, "username": "testuser"}
response = await async_client.get(f"/api/v1/printers/{printer.id}/current-print-user")
assert response.status_code == 200
result = response.json()
assert result["user_id"] == 42
assert result["username"] == "testuser"
class TestPrintControlAPI:
"""Integration tests for print control endpoints (stop, pause, resume)."""
# ========================================================================
# Stop print endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_stop_print_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/print/stop")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_stop_print_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/stop")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_stop_print_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful stop print request."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.stop_print.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/stop")
assert response.status_code == 200
assert response.json()["success"] is True
mock_client.stop_print.assert_called_once()
# ========================================================================
# Pause print endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_pause_print_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/print/pause")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_pause_print_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/pause")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_pause_print_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful pause print request."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.pause_print.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/pause")
assert response.status_code == 200
assert response.json()["success"] is True
mock_client.pause_print.assert_called_once()
# ========================================================================
# Resume print endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_resume_print_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/print/resume")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_resume_print_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/resume")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_resume_print_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful resume print request."""
printer = await printer_factory(name="Paused Printer")
mock_client = MagicMock()
mock_client.resume_print.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/resume")
assert response.status_code == 200
assert response.json()["success"] is True
mock_client.resume_print.assert_called_once()
class TestAMSRefreshAPI:
"""Integration tests for AMS slot refresh endpoint."""
@pytest.mark.asyncio
@pytest.mark.integration
async def test_ams_refresh_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/ams/0/slot/0/refresh")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_ams_refresh_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/0/refresh")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_ams_refresh_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful AMS refresh request."""
printer = await printer_factory(name="Printer with AMS")
mock_client = MagicMock()
mock_client.ams_refresh_tray.return_value = (True, "Refreshing AMS 0 tray 1")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/1/refresh")
assert response.status_code == 200
result = response.json()
assert result["success"] is True
mock_client.ams_refresh_tray.assert_called_once_with(0, 1)
@pytest.mark.asyncio
@pytest.mark.integration
async def test_ams_refresh_filament_loaded(self, async_client: AsyncClient, printer_factory):
"""Verify error when filament is loaded (can't refresh while loaded)."""
printer = await printer_factory(name="Printer with AMS")
mock_client = MagicMock()
mock_client.ams_refresh_tray.return_value = (False, "Please unload filament first")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/0/refresh")
assert response.status_code == 400
assert "unload" in response.json()["detail"].lower()
class TestConfigureAMSSlotAPI:
"""Integration tests for AMS slot configure endpoint — tray_info_idx resolution."""
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/0/0/configure",
params={
"tray_info_idx": "GFL99",
"tray_type": "PLA",
"tray_sub_brands": "PLA Basic",
"tray_color": "FF0000FF",
"nozzle_temp_min": 190,
"nozzle_temp_max": 230,
},
)
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_with_gf_id_keeps_it(self, async_client: AsyncClient, printer_factory):
"""Standard Bambu GF* filament IDs are sent as-is."""
printer = await printer_factory(name="H2D")
mock_client = MagicMock()
mock_client.ams_set_filament_setting.return_value = True
mock_client.extrusion_cali_sel.return_value = True
mock_client.request_status_update.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
mock_pm.get_status.return_value = None # No existing state
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/2/3/configure",
params={
"tray_info_idx": "GFL05",
"tray_type": "PLA",
"tray_sub_brands": "PLA Basic",
"tray_color": "FFFFFFFF",
"nozzle_temp_min": 190,
"nozzle_temp_max": 230,
},
)
assert response.status_code == 200
call_kwargs = mock_client.ams_set_filament_setting.call_args
assert call_kwargs.kwargs["tray_info_idx"] == "GFL05"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_pfus_replaced_with_generic(self, async_client: AsyncClient, printer_factory):
"""PFUS* user-local IDs are replaced with generic Bambu IDs."""
printer = await printer_factory(name="H2D")
mock_client = MagicMock()
mock_client.ams_set_filament_setting.return_value = True
mock_client.extrusion_cali_sel.return_value = True
mock_client.request_status_update.return_value = True
mock_status = MagicMock()
mock_status.raw_data = {"ams": {"ams": []}} # No existing tray data
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
mock_pm.get_status.return_value = mock_status
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/2/3/configure",
params={
"tray_info_idx": "PFUS9ac902733670a9",
"tray_type": "PLA",
"tray_sub_brands": "Devil Design PLA",
"tray_color": "FF0000FF",
"nozzle_temp_min": 190,
"nozzle_temp_max": 230,
},
)
assert response.status_code == 200
call_kwargs = mock_client.ams_set_filament_setting.call_args
assert call_kwargs.kwargs["tray_info_idx"] == "GFL99"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_pfus_reuses_existing_slot_id(self, async_client: AsyncClient, printer_factory):
"""When slot already has a recognised preset for same material, reuse it."""
printer = await printer_factory(name="H2D")
mock_client = MagicMock()
mock_client.ams_set_filament_setting.return_value = True
mock_client.extrusion_cali_sel.return_value = True
mock_client.request_status_update.return_value = True
# Simulate slot already configured by slicer with cloud-synced preset
mock_status = MagicMock()
mock_status.raw_data = {
"ams": {
"ams": [
{
"id": 2,
"tray": [
{
"id": 3,
"tray_info_idx": "P4d64437",
"tray_type": "PLA",
"tray_color": "FF0000FF",
}
],
}
]
}
}
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
mock_pm.get_status.return_value = mock_status
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/2/3/configure",
params={
"tray_info_idx": "PFUS9ac902733670a9",
"tray_type": "PLA",
"tray_sub_brands": "Devil Design PLA",
"tray_color": "FF0000FF",
"nozzle_temp_min": 190,
"nozzle_temp_max": 230,
},
)
assert response.status_code == 200
call_kwargs = mock_client.ams_set_filament_setting.call_args
# Should reuse the slicer's P4d64437, not replace with GFL99
assert call_kwargs.kwargs["tray_info_idx"] == "P4d64437"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_pfus_different_material_uses_generic(self, async_client: AsyncClient, printer_factory):
"""When slot has a recognised preset but for DIFFERENT material, use generic."""
printer = await printer_factory(name="H2D")
mock_client = MagicMock()
mock_client.ams_set_filament_setting.return_value = True
mock_client.extrusion_cali_sel.return_value = True
mock_client.request_status_update.return_value = True
# Slot currently has PETG but user is configuring PLA
mock_status = MagicMock()
mock_status.raw_data = {
"ams": {
"ams": [
{
"id": 2,
"tray": [{"id": 3, "tray_info_idx": "GFG99", "tray_type": "PETG", "tray_color": "FFFFFFFF"}],
}
]
}
}
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
mock_pm.get_status.return_value = mock_status
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/2/3/configure",
params={
"tray_info_idx": "PFUS9ac902733670a9",
"tray_type": "PLA",
"tray_sub_brands": "Devil Design PLA",
"tray_color": "FF0000FF",
"nozzle_temp_min": 190,
"nozzle_temp_max": 230,
},
)
assert response.status_code == 200
call_kwargs = mock_client.ams_set_filament_setting.call_args
# Different material → should NOT reuse PETG ID, use generic PLA
assert call_kwargs.kwargs["tray_info_idx"] == "GFL99"
@pytest.mark.asyncio
@pytest.mark.integration
async def test_configure_empty_id_uses_generic(self, async_client: AsyncClient, printer_factory):
"""Empty tray_info_idx (local preset) is replaced with generic."""
printer = await printer_factory(name="H2D")
mock_client = MagicMock()
mock_client.ams_set_filament_setting.return_value = True
mock_client.extrusion_cali_sel.return_value = True
mock_client.request_status_update.return_value = True
mock_status = MagicMock()
mock_status.raw_data = {"ams": {"ams": []}}
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
mock_pm.get_status.return_value = mock_status
response = await async_client.post(
f"/api/v1/printers/{printer.id}/slots/2/3/configure",
params={
"tray_info_idx": "",
"tray_type": "PETG",
"tray_sub_brands": "PETG Basic",
"tray_color": "FFFFFFFF",
"nozzle_temp_min": 220,
"nozzle_temp_max": 260,
},
)
assert response.status_code == 200
call_kwargs = mock_client.ams_set_filament_setting.call_args
assert call_kwargs.kwargs["tray_info_idx"] == "GFG99"
class TestSkipObjectsAPI:
"""Integration tests for skip objects endpoints."""
# ========================================================================
# Get printable objects endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_objects_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.get("/api/v1/printers/99999/print/objects")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_objects_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_objects_empty(self, async_client: AsyncClient, printer_factory):
"""Verify empty objects list when no print is active."""
printer = await printer_factory(name="Idle Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {}
mock_client.state.skipped_objects = []
mock_client.state.state = "IDLE"
mock_client.state.subtask_name = None # Prevent FTP download attempt
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
assert response.status_code == 200
result = response.json()
assert result["objects"] == []
assert result["total"] == 0
assert result["skipped_count"] == 0
assert result["is_printing"] is False
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_objects_with_data(self, async_client: AsyncClient, printer_factory):
"""Verify objects list when print is active."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {100: "Part A", 200: "Part B", 300: "Part C"}
mock_client.state.skipped_objects = [200]
mock_client.state.state = "RUNNING"
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
assert response.status_code == 200
result = response.json()
assert result["total"] == 3
assert result["skipped_count"] == 1
assert result["is_printing"] is True
# Check objects have correct structure
objects_by_id = {obj["id"]: obj for obj in result["objects"]}
assert objects_by_id[100]["name"] == "Part A"
assert objects_by_id[100]["skipped"] is False
assert objects_by_id[200]["name"] == "Part B"
assert objects_by_id[200]["skipped"] is True
assert objects_by_id[300]["name"] == "Part C"
assert objects_by_id[300]["skipped"] is False
# ========================================================================
# Skip objects endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_get_objects_with_positions(self, async_client: AsyncClient, printer_factory):
"""Verify objects list includes position data when available."""
printer = await printer_factory(name="Printing Printer")
# New format with position data
mock_client = MagicMock()
mock_client.state.printable_objects = {
100: {"name": "Part A", "x": 50.0, "y": 100.0},
200: {"name": "Part B", "x": 150.0, "y": 100.0},
}
mock_client.state.skipped_objects = []
mock_client.state.state = "RUNNING"
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
assert response.status_code == 200
result = response.json()
assert result["total"] == 2
# Check objects have position data
objects_by_id = {obj["id"]: obj for obj in result["objects"]}
assert objects_by_id[100]["name"] == "Part A"
assert objects_by_id[100]["x"] == 50.0
assert objects_by_id[100]["y"] == 100.0
assert objects_by_id[200]["name"] == "Part B"
assert objects_by_id[200]["x"] == 150.0
assert objects_by_id[200]["y"] == 100.0
# ========================================================================
# Skip objects endpoint
# ========================================================================
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/print/skip-objects", json=[100])
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100])
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_empty_list(self, async_client: AsyncClient, printer_factory):
"""Verify error when no object IDs provided."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {100: "Part A"}
mock_client.state.skipped_objects = []
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[])
assert response.status_code == 400
assert "no object" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_invalid_id(self, async_client: AsyncClient, printer_factory):
"""Verify error when object ID doesn't exist."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {100: "Part A"}
mock_client.state.skipped_objects = []
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[999])
assert response.status_code == 400
assert "invalid" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful skip objects request."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {100: "Part A", 200: "Part B"}
mock_client.state.skipped_objects = []
mock_client.skip_objects.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100])
assert response.status_code == 200
result = response.json()
assert result["success"] is True
assert 100 in result["skipped_objects"]
mock_client.skip_objects.assert_called_once_with([100])
@pytest.mark.asyncio
@pytest.mark.integration
async def test_skip_objects_multiple(self, async_client: AsyncClient, printer_factory):
"""Verify skipping multiple objects at once."""
printer = await printer_factory(name="Printing Printer")
mock_client = MagicMock()
mock_client.state.printable_objects = {100: "Part A", 200: "Part B", 300: "Part C"}
mock_client.state.skipped_objects = []
mock_client.skip_objects.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100, 200])
assert response.status_code == 200
result = response.json()
assert result["success"] is True
assert 100 in result["skipped_objects"]
assert 200 in result["skipped_objects"]
mock_client.skip_objects.assert_called_once_with([100, 200])
class TestChamberLightAPI:
"""Integration tests for chamber light control endpoint."""
@pytest.mark.asyncio
@pytest.mark.integration
async def test_chamber_light_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/chamber-light?on=true")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_chamber_light_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_chamber_light_on_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful chamber light on request."""
printer = await printer_factory(name="Test Printer")
mock_client = MagicMock()
mock_client.set_chamber_light.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
assert response.status_code == 200
result = response.json()
assert result["success"] is True
assert "on" in result["message"].lower()
mock_client.set_chamber_light.assert_called_once_with(True)
@pytest.mark.asyncio
@pytest.mark.integration
async def test_chamber_light_off_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful chamber light off request."""
printer = await printer_factory(name="Test Printer")
mock_client = MagicMock()
mock_client.set_chamber_light.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=false")
assert response.status_code == 200
result = response.json()
assert result["success"] is True
assert "off" in result["message"].lower()
mock_client.set_chamber_light.assert_called_once_with(False)
@pytest.mark.asyncio
@pytest.mark.integration
async def test_chamber_light_failure(self, async_client: AsyncClient, printer_factory):
"""Verify error handling when chamber light control fails."""
printer = await printer_factory(name="Test Printer")
mock_client = MagicMock()
mock_client.set_chamber_light.return_value = False
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
assert response.status_code == 500
assert "failed" in response.json()["detail"].lower()
class TestClearHMSErrorsAPI:
"""Integration tests for clear HMS errors endpoint."""
@pytest.mark.asyncio
@pytest.mark.integration
async def test_clear_hms_errors_not_found(self, async_client: AsyncClient):
"""Verify 404 for non-existent printer."""
response = await async_client.post("/api/v1/printers/99999/hms/clear")
assert response.status_code == 404
@pytest.mark.asyncio
@pytest.mark.integration
async def test_clear_hms_errors_not_connected(self, async_client: AsyncClient, printer_factory):
"""Verify error when printer is not connected."""
printer = await printer_factory(name="Disconnected Printer")
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = None
response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
assert response.status_code == 400
assert "not connected" in response.json()["detail"].lower()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_clear_hms_errors_success(self, async_client: AsyncClient, printer_factory):
"""Verify successful clear HMS errors request."""
printer = await printer_factory(name="Test Printer")
mock_client = MagicMock()
mock_client.clear_hms_errors.return_value = True
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
assert response.status_code == 200
result = response.json()
assert result["success"] is True
assert "cleared" in result["message"].lower()
mock_client.clear_hms_errors.assert_called_once()
@pytest.mark.asyncio
@pytest.mark.integration
async def test_clear_hms_errors_failure(self, async_client: AsyncClient, printer_factory):
"""Verify error handling when clear HMS errors fails."""
printer = await printer_factory(name="Test Printer")
mock_client = MagicMock()
mock_client.clear_hms_errors.return_value = False
with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
mock_pm.get_client.return_value = mock_client
response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
assert response.status_code == 500
assert "failed" in response.json()["detail"].lower()