mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-09-30 03:01:21 +02:00
maziggy
fdf818e54c
+ ci: shard backend tests 4-way + drop -v for ~3.5x wall-clock speedup Root cause of the 4 CI failures on PR #1514 (all in test_print_start_assigns_printer_id_to_vp_archive.py + test_timelapse_baseline_restart_recovery.py): test_all_modules_importable in test_code_quality.py was deleting backend.app.main from sys.modules and re-importing it via importlib.import_module. That created NEW module-level dicts (_timelapse_baselines, _expected_prints, _active_prints, …) and re-ran root_logger.addHandler — hence the duplicate log lines at the same microsecond in captured stderr. Any sibling test that bound those names via "from backend.app.main import _timelapse_baselines" before the reimport now held a reference to the OLD dict; production code (reached via "from backend.app.main import on_print_start") resolved the symbol through the NEW module instance. Production mutated the new dict, the test read the old one, the assertion saw None / un-mutated mock_archive. Locally with -n 30, xdist load-balanced test_code_quality.py to a different worker process so the collision never happened (which is why the suite was green for me). CI's -n auto = -n 2 on ubuntu-latest made the collision deterministic. Fix: drop the "del sys.modules[name]" step. importlib.import_module already returns the cached module if cached, or runs the import machinery if not — either way, any import-time error surfaces. The "fresh import" framing was theatre; in practice every module in the list is already imported by other tests/fixtures before this test runs, so we were never actually getting a fresh import anyway — just destruction. CI workflow tightening (separate concern, same PR since both touch the test infrastructure): - Dropped -v from the pytest invocation. 5300+ "PASSED foo::bar" lines per worker were eating ~30-60s of stdout I/O on 2-vCPU runners. --tb=short is sufficient for failure context. - Sharded backend-tests into a 4-way matrix via pytest-split (new dev dep). Each shard runs ~1326 tests in ~95s on a 2-vCPU runner; all 4 run in parallel so wall-clock drops from 362s -> ~100s. - fail-fast: false on the matrix so a single failing shard doesn't hide failures in the other three — PRs see the complete failure picture in one push.
23 lines
687 B
Plaintext
23 lines
687 B
Plaintext
# Development and testing dependencies
|
|
pytest>=8.0.0
|
|
pytest-asyncio>=0.23.0
|
|
pytest-cov>=4.1.0
|
|
pytest-xdist>=3.5.0
|
|
pytest-timeout>=2.4.0
|
|
# Test-suite sharding for CI matrix. Splits the test set evenly across N
|
|
# shards via --splits/--group; falls back to test-name hashing on the first
|
|
# run, and uses recorded durations on subsequent runs (.test_durations).
|
|
pytest-split>=0.9.0
|
|
httpx>=0.27.0
|
|
ruff>=0.8.0
|
|
pre-commit>=4.0
|
|
|
|
# Required by pyftpdlib TLS_FTPHandler for mock FTP server tests
|
|
pyOpenSSL>=26.0.0
|
|
|
|
# Security scanning
|
|
bandit[sarif]>=1.7.0
|
|
pip-audit>=2.7.0
|
|
# Secrets scan: gitleaks (Go binary, not a Python package).
|
|
# Install: go install github.com/zricethezav/gitleaks/v8@latest
|