mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-09-30 03:01:21 +02:00
maziggy
ba1394db3e
Two defects, both invisible until you ask the app to stop. Docker never shut down gracefully at all. CMD ["sh","-c","uvicorn ..."] left the shell as PID 1 with uvicorn as its child, and dash does not forward signals, so docker stop SIGTERMed the shell and uvicorn never heard about it. Measured on the shipped image: the full 10s grace period, exit 137, and no "Shutting down" line in the log. Every stop, restart and image update was a hard kill -- no WAL checkpoint, no MQTT disconnect, no virtual-printer teardown. `exec` makes uvicorn PID 1; the rebuilt image now stops in 1s with exit 0 and checkpoints the WAL. Separately, uvicorn's timeout_graceful_shutdown defaults to None -- wait forever for in-flight requests. An MJPEG camera stream is a response that never completes (httptools' connection shutdown() only flips keep_alive on an in-flight cycle, it never closes the transport), so one open camera tile pinned the process until systemd SIGKILLed at 90s. The ordering makes it unfixable from inside the app: uvicorn fires the lifespan shutdown -- the code that tears the streams down -- only after connections drain. All six launchers now pass --timeout-graceful-shutdown 5: Dockerfile, deploy/bambuddy.service, the systemd unit and launchd plist from install/install.sh, the SpoolBuddy installer's unit, and the Windows NSSM registration. On timeout uvicorn cancels the request tasks; the camera generators already unwind cleanly on CancelledError. TimeoutStopSec raised to 30s on the units and stop_grace_period: 30s added to compose, as backstops rather than the mechanism. On Windows NSSM's default 1500ms AppStopMethodConsole was force-killing uvicorn mid-teardown; raised to 15s, with the WM_CLOSE and thread-message stages skipped (uvicorn is a console app with neither a window nor a message loop).
94 lines
3.8 KiB
Batchfile
94 lines
3.8 KiB
Batchfile
@echo off
|
|
REM Register Bambuddy as a Windows service via NSSM.
|
|
REM
|
|
REM Called from Inno Setup's [Run] section. Arguments:
|
|
REM %1 = install dir (e.g. C:\Program Files\Bambuddy)
|
|
REM %2 = data dir (e.g. C:\ProgramData\Bambuddy)
|
|
REM %3 = port (e.g. 8000)
|
|
REM
|
|
REM If the service already exists (re-install / upgrade), remove and
|
|
REM re-create it so config changes from this build apply.
|
|
|
|
setlocal
|
|
|
|
set "INSTALL_DIR=%~1"
|
|
set "DATA_ROOT=%~2"
|
|
set "PORT=%~3"
|
|
|
|
set "NSSM=%INSTALL_DIR%\bin\nssm.exe"
|
|
set "PYTHON=%INSTALL_DIR%\python\python.exe"
|
|
set "APP_DIR=%INSTALL_DIR%\app"
|
|
set "BIN_DIR=%INSTALL_DIR%\bin"
|
|
set "DATA_DIR=%DATA_ROOT%\data"
|
|
set "LOG_DIR=%DATA_ROOT%\logs"
|
|
|
|
REM Stop and remove any previous registration. Errors are non-fatal —
|
|
REM "service not found" returns non-zero and we want to proceed.
|
|
"%NSSM%" stop Bambuddy 2>nul
|
|
"%NSSM%" remove Bambuddy confirm 2>nul
|
|
|
|
REM Register the service. NSSM wraps uvicorn so Windows treats it as a
|
|
REM proper service (autostart, recovery, supervised restart).
|
|
REM --loop asyncio required: uvloop can truncate VP FTP uploads (#1896).
|
|
REM --timeout-graceful-shutdown required: uvicorn otherwise waits forever for
|
|
REM in-flight requests, and an MJPEG camera stream is a response that never
|
|
REM completes — one open camera tile hangs the stop until NSSM force-kills,
|
|
REM skipping the WAL checkpoint and the MQTT / virtual-printer teardown.
|
|
"%NSSM%" install Bambuddy "%PYTHON%" "-m uvicorn backend.app.main:app --host 0.0.0.0 --port %PORT% --loop asyncio --timeout-graceful-shutdown 5"
|
|
if errorlevel 1 (
|
|
echo [install-service] nssm install failed
|
|
exit /b 1
|
|
)
|
|
|
|
REM Service configuration
|
|
"%NSSM%" set Bambuddy AppDirectory "%APP_DIR%"
|
|
"%NSSM%" set Bambuddy DisplayName "Bambuddy"
|
|
"%NSSM%" set Bambuddy Description "Bambuddy — local-first Bambu Lab printer manager"
|
|
"%NSSM%" set Bambuddy Start SERVICE_AUTO_START
|
|
|
|
REM Shutdown behaviour. NSSM's stop sequence is Ctrl-C, then WM_CLOSE, then a
|
|
REM thread message, then TerminateProcess — each with a 1500 ms default wait.
|
|
REM Uvicorn shuts down on the Ctrl-C, but needs longer than 1.5 seconds to
|
|
REM finish: it drains in-flight requests (bounded at 5s by the flag above) and
|
|
REM then runs the app teardown — WAL checkpoint, MQTT disconnect, virtual-
|
|
REM printer stop. At the default timeout Windows force-killed it mid-teardown.
|
|
REM
|
|
REM Skip=6 drops the WM_CLOSE (2) and thread-message (4) methods: uvicorn is a
|
|
REM console app with no window and no message loop, so both were only burning
|
|
REM another 3 seconds before the kill. Ctrl-C is the one that works.
|
|
"%NSSM%" set Bambuddy AppStopMethodSkip 6
|
|
"%NSSM%" set Bambuddy AppStopMethodConsole 15000
|
|
|
|
REM Environment: point DATA_DIR + LOG_DIR at ProgramData, prepend our
|
|
REM bin/ to PATH so ffmpeg/ffprobe are found by the shutil.which() lookup
|
|
REM in backend/app/services/layer_timelapse.py.
|
|
"%NSSM%" set Bambuddy AppEnvironmentExtra ^
|
|
"DATA_DIR=%DATA_DIR%" ^
|
|
"LOG_DIR=%LOG_DIR%" ^
|
|
"PORT=%PORT%" ^
|
|
"PATH=%BIN_DIR%;%PATH%"
|
|
|
|
REM Stdout / stderr capture. Rotate at 10MB.
|
|
"%NSSM%" set Bambuddy AppStdout "%LOG_DIR%\service-stdout.log"
|
|
"%NSSM%" set Bambuddy AppStderr "%LOG_DIR%\service-stderr.log"
|
|
"%NSSM%" set Bambuddy AppRotateFiles 1
|
|
"%NSSM%" set Bambuddy AppRotateOnline 1
|
|
"%NSSM%" set Bambuddy AppRotateBytes 10485760
|
|
|
|
REM Run as LocalSystem (default). Required for binding 322/990/8883 if
|
|
REM the user later enables the Virtual Printer feature. Most non-VP
|
|
REM workloads would work as a less-privileged account, but service
|
|
REM identity changes are disruptive — pick the broader one once.
|
|
|
|
REM Start the service. If it fails to start, NSSM exits non-zero and
|
|
REM Inno Setup will surface this to the user.
|
|
"%NSSM%" start Bambuddy
|
|
if errorlevel 1 (
|
|
echo [install-service] nssm start failed — check %LOG_DIR%\service-stderr.log
|
|
exit /b 1
|
|
)
|
|
|
|
echo [install-service] Bambuddy service registered and started on port %PORT%
|
|
endlocal
|
|
exit /b 0
|