Files
bambuddy/backend/app/services/spool_filament_preset.py
maziggy a7b563334e Configure a spool's filament preset and K profile per nozzle
A slicer preset is bound to a printer model: "Bambu PLA Basic @BBL X1C" is
not the same preset as "@BBL H2C", and Bambu names a nozzle size in it as
well. A spool carried exactly one, which was right until the same spool was
used on a second machine -- the AMS slot on the other one was then
configured with a preset that machine has no profile for. K profiles had
the matching gap from the other side: the tables have always been keyed per
hotend, but the picker could not express it.

spool_filament_preset and its Spoolman twin store the exceptions, keyed
(spool, printer_model, nozzle_diameter). Model rather than printer because
the preset is a property of the model -- "@BBL X1C" is the same preset on
every X1C, and asking per machine would mean picking the identical value
twice. K profiles stay on printer_id, because a K value is measured on one
physical hotend and two machines of the same model legitimately differ.
Resolution is exact (model, diameter) -> (model, "") -> the spool's own
preset, so a spool nobody has configured behaves exactly as it did before.
The form writes one row per nozzle size and never the "" row; that level is
kept for API clients wanting one value to cover a model.

Both halves cover every standard nozzle size rather than the size currently
fitted, because a spool is configured once and nozzles get swapped. The PA
Profile tab becomes a Printers tab: a model list beside a detail pane
holding a preset row per size and a K-profile grid of size by hotend. Each
model is offered only the presets that name it, through the same matcher
the Configure AMS Slot modal filters with, which moves out of that
component into utils/slicerPrinterMatch. Presets whose name identifies no
model -- most user-authored and OrcaSlicer ones -- stay offered everywhere,
as does whatever is already selected, so a saved override cannot vanish
from the control that shows it. Every preset carries an origin badge in the
wording and colours that modal already uses.

Every path that configures a slot now respects both: manual assign in
either inventory mode, RFID auto-assign, the Spoolman tag link, the re-fire
when a slot goes empty to loaded, the re-apply after a calibration-table
refresh, and the re-selection when a Filament Track Switch moves an AMS to
the other nozzle. Which nozzle a slot feeds, and how wide it is, was worked
out independently in seven of those places, each reading nozzles[0] for
every slot on the machine -- correct on a single-nozzle printer and on a
dual-nozzle printer with matching nozzles, wrong the moment two sizes are
fitted. That resolution is now services/slot_nozzle.

Which array entry belongs to which hotend is no longer inferred. Measured
on an H2D fitted with a 0.4 high flow on the left and a 0.6 on the right,
nozzles[0] reads the right hotend, so the array is indexed by extruder id
and the H2/X2 parser's convention is the one that holds. The legacy
parser's opposite convention never governs a real dual-nozzle machine:
every model in DUAL_NOZZLE_MODELS reports device.nozzle.info, and
left_nozzle_diameter appears in no log or wire capture. Two comments that
said otherwise were wrong and are fixed; amsHelpers' code was right all
along and only its comment lied.

Four defects surfaced while wiring it, all pre-existing except the last.
The picker identified a chosen calibration by cali_idx alone, and the
printer numbers its calibration table per nozzle -- on a dual-nozzle
machine the same index exists on both hotends meaning different things, so
saving could persist the other hotend's K value and diameter; SpoolBuddy's
write-tag page carried a verbatim copy and gets the same fix. RFID
auto-assign chose a K profile with no extruder test at all, so a spool
calibrated on both hotends had a coin toss decide which pressure-advance
value the slot got, on the path that runs unattended every time a Bambu
spool is loaded. The Spoolman tag-link path resolved no preset whatsoever,
configuring every linked slot with a generic material id and discarding a
preset set in inventory -- the same defect #1713 fixed on the assign path,
one function over. And an FTS inlet move re-selected K for nozzle 0 rather
than for the nozzle the AMS had just been moved to.

The last one is new here: a per-model override can be a cloud USER preset,
whose PFUS-prefixed id the slicer rejects, and passing it straight into
extrusion_cali_sel would silently lose the K-profile link. Reached the
printer only where such an override exists, which is why nothing in the
suite caught it. printer_safe_filament_id falls through to the spool's own
preset and then the tray's RFID value instead.

Reading a printer's calibration table asks for one nozzle size at a time.
H2-series firmware answers only the first one or two of a concurrent burst
of extrusion_cali_get and silently drops the rest, each dropped request
costing a five-second timeout before its retry: measured at 11 and 23
seconds on an H2C and an H2D for four parallel requests, against roughly
one second in series. An X1C answers all four at once, which is why this
only ever surfaced on dual-diameter printers. Printers themselves are read
in parallel -- separate machines are separate connections.

The Configure AMS Slot dialog opens on the spool's own configured values,
falling back to the slot's last manual configuration and then the tray's
RFID data. The spool form is wider for the two-pane layout, colour, weight,
cost and location move to their own tab in two columns, and a printer card
in expanded view lists every fitted nozzle size rather than the first entry
alone.
2026-08-27 13:03:15 +02:00

128 lines
5.2 KiB
Python

"""Resolve which slicer filament preset a spool should use on a given nozzle.
``Spool.slicer_filament`` is the spool's single, printer-agnostic answer. It is
right until the same spool is used on two printer models, because a cloud or
Orca preset is bound to a model (``@BBL X1C``): assigning that spool to an H2C
writes a slot preset the H2C has no profile for. ``SpoolFilamentPreset`` stores
the per-model exceptions and this module is the only thing that reads them, so
the internal-inventory and Spoolman-inventory assign paths cannot drift apart
the way they did before #1713.
Resolution order, most specific first:
1. (printer_model, nozzle_diameter) -- what the spool form writes, one
row per nozzle size
2. (printer_model, "") -- a whole-model value; the form does
not write these, but the API accepts
them and they still resolve
3. ``Spool.slicer_filament`` -- what the spool carries today
Every step is a plain equality match on stored strings; nothing is inferred
from preset names. A model with no row at all resolves to step 3, which is
exactly the behaviour every install has now, so a spool nobody has configured
per-model behaves identically before and after this feature.
"""
from __future__ import annotations
import logging
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
from backend.app.models.spool_filament_preset import SpoolFilamentPreset, SpoolmanFilamentPreset
logger = logging.getLogger(__name__)
# What ``resolve_*`` returns: (slicer_filament, slicer_filament_name).
PresetPair = tuple[str | None, str | None]
def _pick(
rows: list[SpoolFilamentPreset] | list[SpoolmanFilamentPreset],
printer_model: str | None,
nozzle_diameter: str | None,
fallback: PresetPair,
) -> PresetPair:
"""Apply the cascade to rows already fetched for one spool.
Split out so both spool flavours share it, and so callers that already
hold the rows (the spool form's read path) do not re-query.
"""
model = (printer_model or "").strip()
if not model:
# No model means no way to be more specific than the spool's own value.
# This is the normal answer for a printer that has not reported yet.
return fallback
diameter = (nozzle_diameter or "").strip()
exact: PresetPair | None = None
model_default: PresetPair | None = None
for row in rows:
if row.printer_model != model:
continue
if diameter and row.nozzle_diameter == diameter:
exact = (row.slicer_filament, row.slicer_filament_name)
elif row.nozzle_diameter == "":
model_default = (row.slicer_filament, row.slicer_filament_name)
chosen = exact or model_default
if chosen is None:
return fallback
# A row that exists but carries no preset id is a deliberate "use nothing
# here", not a hole to fall through: the user picked the blank entry for
# this model. Falling back would silently reinstate the value they cleared.
return chosen
def printer_safe_filament_id(*candidates: str | None) -> str:
"""First candidate the printer will accept as a filament id, or "".
``extrusion_cali_sel`` carries a filament id so the printer can link the
calibration index to the slot's filament. A cloud USER preset id
(``PFUS``/``PFCN`` prefix) is not one the slicer accepts -- the assign paths
have refused those for tray_info_idx since #1713, and the same holds here.
This matters now that a per-model override can BE such an id: a user picking
their own cloud preset for a model stores its ``PFUS...`` id, and passing
that straight through would send the printer a value it rejects, silently
losing the K-profile link. Falls through to the next candidate instead --
normally the spool's own preset, then the tray's RFID value.
"""
for candidate in candidates:
value = (candidate or "").strip()
if value and not value.startswith(("PFUS", "PFCN")):
return value
return ""
async def resolve_spool_preset(
db: AsyncSession,
*,
spool_id: int,
printer_model: str | None,
nozzle_diameter: str | None,
fallback_filament: str | None,
fallback_name: str | None,
) -> PresetPair:
"""Cascade for an internal-inventory spool. See the module docstring."""
result = await db.execute(select(SpoolFilamentPreset).where(SpoolFilamentPreset.spool_id == spool_id))
return _pick(list(result.scalars().all()), printer_model, nozzle_diameter, (fallback_filament, fallback_name))
async def resolve_spoolman_preset(
db: AsyncSession,
*,
spoolman_spool_id: int,
printer_model: str | None,
nozzle_diameter: str | None,
fallback_filament: str | None,
fallback_name: str | None,
) -> PresetPair:
"""Cascade for a Spoolman-managed spool. See the module docstring."""
result = await db.execute(
select(SpoolmanFilamentPreset).where(SpoolmanFilamentPreset.spoolman_spool_id == spoolman_spool_id)
)
return _pick(list(result.scalars().all()), printer_model, nozzle_diameter, (fallback_filament, fallback_name))