2 Commits

Include renames

Author	SHA1	Message	Date
maziggy	d5153f1de3	feat(slicer): live progress + filament discovery polish + OrcaSlicer warning ... End-to-end live progress, two correctness fixes, and a UX warning around the upstream OrcaSlicer bugs we discovered while testing. LIVE PROGRESS ============= Wire OrcaSlicer / BambuStudio's --pipe progress channel through the sidecar -> Bambuddy -> persistent toast so a user-initiated slice shows "{name} -- Generating G-code (75%) -- 47s" instead of just elapsed time. The same wiring covers the SliceModal's filament-analysis preview slice (the real slice that fires before profile picking, used to discover which AMS slots an unsliced plate consumes) and the embedded-settings fallback path triggered by Orca's --load-settings segfault on complex H2D models. - Sidecar (orca-slicer-api/bambuddy/profile-resolver, separate commit): switch /slice from execFile to spawn, mkfifo per request, parse the CLI's structured JSON progress events into a per-process ProgressStore, expose GET /slice/progress/:requestId. - Bambuddy backend: slicer_api.slice_with_profiles + slice_without_profiles accept request_id + on_progress, spawn a 1Hz parallel poller that forwards each snapshot via SliceDispatchService.set_progress(job_id, ...) onto the matching SliceJob; GET /slice-jobs/:id includes the latest snapshot on every poll. The 404 from the early-race window (POST fired before sidecar's progressStore.start) is treated as a retry rather than terminal -- otherwise the poller bailed before any progress could ever arrive. - /api/v1/slicer/preview-progress/:requestId proxies the sidecar's progress endpoint for the modal's filament-discovery flow (the /filament-requirements call is server-originated; the browser can't reach the sidecar directly). - Frontend: SliceJobTrackerContext re-renders the persistent toast with the new format when a useful progress frame is present, falls back to elapsed-time-only when the sidecar hasn't emitted yet or doesn't support progress. SliceModal.FilamentAnalysisSpinner generates a per-(source, plate) UUID, polls the proxy at 1Hz, and mirrors the inline spinner contents into a separate persistent toast so the preview slice doesn't feel silent either. CORRECTNESS FIXES ================= - MakerWorld imports were persisting URL-encoded filenames verbatim ("stormtrooper-helmet%20h2d.3mf"). Backend now urllib.parse.unquote s the manifest-supplied name and the URL path-tail fallback before passing to save_3mf_bytes_to_library; frontend defensively decodeURIComponent s in the slice toast / analysis spinner so already-imported rows display cleanly without a backfill migration. - The fallback path's slice_without_profiles call now forwards the same request_id + on_progress as the primary slice_with_profiles call so the toast keeps updating across the segfault -> embedded- settings retry boundary instead of going blank. ORCASLICER WARNING ================== Verified two upstream OrcaSlicer CLI bugs reproduce on the latest nightly (2.4.0-dev, 2026-04-28) with the help of an isolated AppImage extract and a minimal sentinel-value-injected cube fixture: - OrcaSlicer/OrcaSlicer#12426 -- SIGSEGV in update_values_to_printer_extruders_for_multiple_filaments on painted multi-extruder 3MFs (commented on the existing thread, not a new issue) - OrcaSlicer/OrcaSlicer#13386 -- CLI strict-validates parameter values BambuStudio writes by default (solid_infill_filament: 0, tree_support_wall_count: -1, prime_tower_brim_width: -1) and rejects with exit 238, even though Orca's own GUI tolerates them (filed by us alongside this change) Settings -> Workflow -> Slicer card renders an amber inline warning under the preferred-slicer dropdown when orcaslicer is selected, linking both upstream issues and recommending BambuStudio until the fixes land. Option stays pickable -- users who only slice STLs aren't affected by either bug.	2026-04-28 16:36:49 +02:00
maziggy	988c00554e	feat(slicer): multi-color slicing + per-plate filament discovery ... The slice modal previously rendered exactly one filament dropdown and silently truncated multi-color 3MFs to a single profile, producing wrong colours on every multi-filament print. End-to-end fix across sidecar, backend, and frontend. Sidecar (orca-slicer-api / bambuddy/profile-resolver, separate commit): - /slice accepts up to 16 repeated filamentProfile parts; slicing service materializes each and joins paths with `;` for --load-filaments. - /profiles/bundled emits filament_type and filament_colour per leaf so the bundled tier carries metadata into the modal. Bambuddy backend: - SliceRequest gains filament_presets: list[PresetRef]. Validator accepts three shapes (multi-color array, source-aware singular, legacy bare-int id) and lands them all on a populated array before the route handler runs — fully backwards-compatible. - SlicerApiService.slice_with_profiles takes filament_profile_jsons: list[str] and sends one filamentProfile multipart part per profile (in submission order) so the sidecar receives N profiles cleanly. - New service slice_preview runs the sidecar's slice_without_profiles against an unsliced project file's embedded settings, parses the result's slice_info.config, and returns the canonical per-plate filament list. Cached by (kind, source_id, plate_id, content_hash) with LRU eviction at 256 entries, per-key asyncio.Lock prevents thundering-herd; transient sidecar failures are NOT cached so they retry naturally; parse failures ARE cached (deterministic property of the input, no point re-running). - /filament-requirements endpoint chain: slice_info.config (existing, sliced files) → preview-slice (new, unsliced project files) → project_settings.config + painted-face heuristic with 5% noise threshold (sidecar-down fallback). - threemf_tools gains extract_project_filaments_from_3mf and extract_plate_extruder_set_from_3mf — the latter unions object top-level extruder, per-part overrides, and painted-face quadtree leaves (1-E nibbles in paint_color attrs of <triangle> elements inside per-object .model files). - Cloud preset listing no longer fetches per-preset detail (Bambu's rate limit at ~10/sec returns 429 on every request for users with 50+ presets). Unified-listing dedup pass instead backfills metadata cross-tier so a cloud entry that wins dedup over a same-named local entry inherits the local's filament_type / filament_colour. Frontend: - SliceModal multi-step: plate-picker first when the source is a multi-plate 3MF, then preset dropdowns. One filament dropdown per AMS slot the plate actually uses, each pre-picked by metadata match against user's local + standard presets via existing colorsAreSimilar / normalizeColorForCompare utils. - SliceModal-only tier priority is now local → cloud → standard (was cloud → local → standard). Other consumers of /slicer/presets keep the existing cloud-first order. - Submits filament_presets array; backfills the legacy singular filament_preset from the array's first entry for stale-tab compatibility. - i18n keys added across all 8 locales: slice.filamentSlot, slice.tier.{local,cloud,standard}, slice.cloud.{notAuthenticated, expired,unreachable}, slice.noPresetsForSlot, slice.allPresetsRequired (en + de fully translated; six others seeded with English copies pending native translation, matching the project's existing flow). Permissions: no new endpoint paths added. Preview-slice runs inside /filament-requirements (LIBRARY_READ / ARCHIVES_READ) and multi-filament dispatch runs inside POST /slice (LIBRARY_UPLOAD). No auth surface widened. Tests: 6 SliceRequest schema tests for multi-filament + legacy-new precedence; 9 unit tests for slice_preview cache behaviour (LRU eviction with lock cleanup, content-hash invalidation, concurrent thundering-herd guard, no-cache-poison on transient sidecar failure); 15 unit tests for the two new threemf_tools helpers (5 + 10 cases including the 60/40 painted-threshold regression pin); a multi-filament wire-format test pinning the multipart part count + order; 22 frontend SliceModal tests covering plate picker, multi-color render, metadata-aware pre-pick, manual override, and the new tier order.	2026-04-28 12:20:59 +02:00