public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-10-19 15:54:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(inventory): assign to AMS slot on firmwares that never report state=11 (#1322)

Browse Source 
A1 Mini BMCU (01.07.02.00) and P1S Standard AMS (00.00.06.75) always
  report tray.state=3, even for loaded configured slots. The empty-slot
  detection preferred state==11 with tray_type as a fallback only when
  state was absent, so every assign was classified as empty and MQTT
  was skipped — both for "assign to unconfigured slot" and the secondary
  "PETG over a PLA-configured slot won't reconfigure" symptom.

  Empty-slot detection in the assign route and the on_ams_change replay
  now treats the slot as loaded when EITHER state==11 OR tray_type is
  non-empty. Reset-slot case (state=11 + tray_type="") still works
  through the first clause; configured slots on these firmwares now
  work through the second.

  Truly empty unconfigured slots (state!=11 + tray_type="") still hit
  the pending-config path, and the deferred publish now fires when the
  user later configures the slot in Bambu Studio (tray_type goes
  non-empty), since the replay uses the same disjunction.
This commit is contained in:
maziggy
2026-05-14 14:36:57 +02:00
parent 5c17cd4973
commit f45aaea97c
4 changed files with 168 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/api/routes/inventory.py
+17 -11
View File
@@ -1255,17 +1255,23 @@ async def assign_spool(
# inserted later, on_ams_change re-fires the full configuration. This is
# the SpoolBuddy primary workflow: weigh-then-assign before insertion.
#
# Empty-detection: prefer the printer's tray.state when it's reported
# (11=loaded, 9=empty, 10=spool present but filament not in feeder).
# tray_type alone is wrong post-"Reset slot" — that flow clears tray_type
# to "" while leaving filament physically loaded, and the old check
# would then mark it as a pending-config SpoolBuddy assignment, skip
# MQTT, and the slot would stay unconfigured forever because the
# on_ams_change replay only fires on an empty→loaded transition that
# never comes (the slot is already loaded). When state is not reported
# (older firmware), fall back to the tray_type heuristic.
if tray_state is not None:
slot_is_empty = tray_state != 11
# Empty-detection: priority order is the firmware's explicit signals
# first, then a tray_type fallback for firmwares that don't use the full
# state enum meaningfully.
# - state == 9 → empty (firmware says "no spool")
# - state == 10 → empty (firmware says "spool present but no feed")
# - state == 11 → loaded (firmware says "filament in extruder")
# - any other state value, including 3 (A1 Mini BMCU / P1S Standard AMS
# always report 3) or None (older firmwares omit the field), falls
# back to tray_type: configured ⇒ loaded, empty ⇒ empty (#1322).
# The tray_type fallback for state==3 fixes the reported bug. The 9/10
# branch keeps existing behavior intact even if the MQTT relay's
# auto-clearing of tray_type ever fails to fire — the firmware's
# explicit "empty" signal stays authoritative over stale metadata.
if tray_state == 9 or tray_state == 10:
slot_is_empty = True
elif tray_state == 11:
slot_is_empty = False
else:
slot_is_empty = not (fingerprint_type and fingerprint_type.strip())
configured = False