mirror of
https://github.com/maziggy/bambuddy.git
synced 2026-10-20 00:38:38 +02:00
Frontend ESLint Warnings (8 fixed)
┌─────────────────────────┬───────────────────────────────────────────────────────────┐ │ File │ Fix │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ CameraPage.tsx:75 │ Copy imgRef.current to a variable before cleanup │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ useWebSocket.ts:121 │ Add processMessageQueue to useCallback dependencies │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ SpoolmanSettings.tsx:89 │ Add eslint-disable comment (intentional debounce pattern) │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ MQTTDebugModal.tsx:95 │ Wrap logs in useMemo to prevent recreating on each render │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ Layout.tsx:166 │ Wrap navItemsMap and extLinksMap in useMemo │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ KProfilesView.tsx:715 │ Wrap getProfileKey in useCallback │ ├─────────────────────────┼───────────────────────────────────────────────────────────┤ │ GcodeViewer.tsx:171 │ Add eslint-disable comment (intentional behavior) │ └─────────────────────────┴───────────────────────────────────────────────────────────┘ Docker Integration Test Fix The /api/v1/settings endpoint was returning 404 because: 1. The route was defined at /settings/ (with trailing slash) 2. Curl without -L doesn't follow redirects 3. The catch-all route was intercepting API paths Fixes: - Added routes for both with and without trailing slash in settings.py and notification_templates.py - Updated catch-all in main.py to raise proper HTTPException for API routes Test Results - Frontend lint: 0 errors, 0 warnings - TypeScript: No errors - Backend unit tests: 264 passed - Backend integration tests: 309 passed
This commit is contained in:
@@ -168,7 +168,8 @@ export function GcodeViewer({
|
||||
}
|
||||
initRef.current = false;
|
||||
};
|
||||
}, [gcodeUrl, colorsKey]); // Use colorsKey instead of filamentColors
|
||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||
}, [gcodeUrl, colorsKey]); // Intentionally use colorsKey instead of filamentColors, buildVolume rarely changes
|
||||
|
||||
const handleLayerChange = useCallback((layer: number) => {
|
||||
if (!previewRef.current) return;
|
||||
|
||||
Reference in New Issue
Block a user