public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-10-18 03:54:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(oidc): hide the icon buttons on the env-managed provider too

Browse Source 
refresh-icon and remove-icon rendered outside the !provider.is_env_managed
block, and both routes answer 409 for that provider -- so a click could only
ever produce an error toast, which is the reason the comment right below them
gives for hiding everything else. Its icon comes from BAMBUDDY_OIDC_ICON_URL
and is re-applied on every boot.

Reported by maziggy in review of #2625.
This commit is contained in:
Marian
2026-07-30 14:43:23 +00:00
parent d64f5d9651
commit ac2f4d058e
2 changed files with 67 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/OIDCProviderSettings.tsx
+27 -26
View File
@@ -398,35 +398,36 @@ export function OIDCProviderSettings() {
</div>
</div>
<div className="flex items-center gap-2">
{provider.icon_url && (
<Button
variant="secondary"
size="sm"
onClick={() => refreshIconMutation.mutate(provider.id)}
disabled={refreshIconMutation.isPending}
title={t('settings.oidc.refreshIcon')}
data-testid={`refresh-icon-${provider.id}`}
>
<RefreshCw className={`w-4 h-4 ${refreshIconMutation.isPending ? 'animate-spin' : ''}`} />
</Button>
)}
{provider.has_icon && (
<Button
variant="secondary"
size="sm"
onClick={() => removeIconMutation.mutate(provider.id)}
disabled={removeIconMutation.isPending}
title={t('settings.oidc.removeIcon')}
data-testid={`remove-icon-${provider.id}`}
>
<ImageOff className="w-4 h-4" />
</Button>
)}
{/* #2593: startup rewrites the env-managed row from BAMBUDDY_OIDC_*
and the API answers 409, so offering these would promise a
change that cannot land. */}
and the API answers 409, so offering any of these would promise
a change that cannot land -- the icon routes included, where the
click only ever produced an error toast. */}
{!provider.is_env_managed && (
<>
{provider.icon_url && (
<Button
variant="secondary"
size="sm"
onClick={() => refreshIconMutation.mutate(provider.id)}
disabled={refreshIconMutation.isPending}
title={t('settings.oidc.refreshIcon')}
data-testid={`refresh-icon-${provider.id}`}
>
<RefreshCw className={`w-4 h-4 ${refreshIconMutation.isPending ? 'animate-spin' : ''}`} />
</Button>
)}
{provider.has_icon && (
<Button
variant="secondary"
size="sm"
onClick={() => removeIconMutation.mutate(provider.id)}
disabled={removeIconMutation.isPending}
title={t('settings.oidc.removeIcon')}
data-testid={`remove-icon-${provider.id}`}
>
<ImageOff className="w-4 h-4" />
</Button>
)}
<Toggle
checked={provider.is_enabled}
onChange={() => toggleEnabled(provider)}