fix(diagnostic): skip external-storage check on P1S/P1P instead of fail (#2524)

mirror of https://github.com/maziggy/bambuddy.git synced 2026-09-30 03:01:21 +02:00

P1-series printers have a MicroSD slot but no reachable control to enable
"Store sent files on external storage": current P1 firmware (through
01.10.00.00) never publishes support_save_remote_print_file_to_storage, so
the Bambu Studio toggle never renders, and the P1S has no screen — leaving
store_to_sdcard stuck False with no way for the user to change it. The
external_storage check reported a permanently-unresolvable fail.

Add NO_REMOTE_STORAGE_TOGGLE_MODELS (P1S, P1P) + has_remote_storage_toggle(),
kept distinct from the no-slot NO_EXTERNAL_STORAGE_MODELS. When a model has a
slot but no reachable toggle and the option is off, the check now emits skip
with params reason=unsupported_model rather than fail, and overall no longer
escalates. A P1S reporting the option on still passes. Model-scoped and
default-open, so X1/P2S/H2 (where the fail is actionable) are unaffected; if
a future firmware surfaces the capability, drop the model and it reactivates.
The frontend DiagnosticChecklist renders a reason-specific message variant
(external_storage.skip_unsupported_model) so P1 users see an accurate
explanation instead of the generic "needs a live MQTT connection" skip text.
The fix propagates to the support-bundle diagnostic snapshot automatically.

This commit is contained in:

maziggy

2026-07-09 08:43:59 +02:00

parent 5dd0370397

commit 6127e30abf

20 changed files with 190 additions and 22 deletions

static/assets/index-aVVJQik4.js → static/assets/index-CJ6VzpV2.js

+12 -12

View File

File diff suppressed because one or more lines are too long

									
										static/index.html
									
		+1
		-1
	
												View File
												
				@@ -26,7 +26,7 @@

				    <!-- Splash screens for iOS -->

				    <link rel="apple-touch-startup-image" href="/img/android-chrome-512x512.png" />

				    <script type="module" crossorigin src="/assets/index-aVVJQik4.js"></script>

				    <script type="module" crossorigin src="/assets/index-CJ6VzpV2.js"></script>

				    <link rel="stylesheet" crossorigin href="/assets/index-blSspT6K.css">

				  </head>

				  <body>