fix(queue): skip preheat entirely when no loaded filament wants a chamber (issue #3041)

mirror of https://github.com/maziggy/bambuddy.git synced 2026-09-30 03:01:21 +02:00

Preheat & Heat Soak delayed every PLA print by five to seven minutes and
gave nothing back. The filament map correctly derived a chamber target of
0, and the chamber phase correctly skipped -- but the stage then heated
the bed, waited for it, and held the full soak anyway, because the soak
had no idea it was holding for a chamber nobody asked for. The print's
own G-code sets the bed the moment it starts, so the bed phase only moved
the warm-up ahead of the FTP upload instead of overlapping with it.

A 0 that comes out of the filament map now skips the stage before any
command goes out. The one thing the skip still does is put the airduct
flap back to cooling on the models that have one -- an H2D left in
heating mode by the ABS job before it would otherwise cook the PLA that
follows, and that costs one MQTT command and no waiting.

Explicit instructions are untouched. A chamber target of 0 typed into a
print's own override still heats the bed and runs the soak, which is what
the queue documentation has always promised it does, as does forcing a
print's Preheat override to On. Prints that want chamber heat are
unaffected, including the P1S/P1P/A1 tier where the bed and the soak
timer are the whole mechanism.

The existing unit tests all ran with soak_seconds=0, which is why the
production default was never exercised; the PLA test now runs at the real
default and asserts nothing is dispatched and nothing is slept.

Surfaced in the UI on the way through: the Settings hint claimed the
derived 0 skipped "the chamber phase", and the per-print chamber override
field said nothing about a typed 0 meaning bed-only -- a user reaching
for 0 to turn preheat off got the delay instead.

This commit is contained in:

maziggy

2026-09-07 16:38:36 +02:00

parent 9a837d19a1

commit 069ee8fc87

20 changed files with 229 additions and 45 deletions

static/assets/index-DlHDB85v.js → static/assets/index-BbLrhGQ7.js

+15 -15

View File

File diff suppressed because one or more lines are too long

									
										static/index.html
									
		+1
		-1
	
												View File
												
				@@ -26,7 +26,7 @@

				    <!-- Splash screens for iOS -->

				    <link rel="apple-touch-startup-image" href="/img/android-chrome-512x512.png" />

				    <script type="module" crossorigin src="/assets/index-DlHDB85v.js"></script>

				    <script type="module" crossorigin src="/assets/index-BbLrhGQ7.js"></script>

				    <link rel="stylesheet" crossorigin href="/assets/index-ChscM3lF.css">

				  </head>

				  <body>