mirror of
https://github.com/actions-runner-controller/actions-runner-controller.git
synced 2026-09-30 12:13:33 +02:00
Six specs construct an EphemeralRunnerSetReconciler literal and call Reconcile directly instead of going through SetupWithManager, so the APIReader backfill never runs and the field stays nil. Nothing is broken today: those specs either publish patch ID 0 or return via the stale-outdated path, so they never reach the scale-up branch where the reader is consulted. But the next direct-Reconcile spec that exercises scale-up with a non-zero patch ID would fail with "APIReader is not configured" instead of the behaviour it meant to test, and the cause would not be obvious from the failure. Set the field the way SetupWithManager does in production, so the specs exercise the same wiring the real controller has. The helper still errors on a nil reader; falling back to the cached read is the race that fix exists to prevent. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>