actions-runner-controller/controllers/actions.github.com/autoscalingrunnerset_contro...

1083 lines
39 KiB
Go

package actionsgithubcom
import (
"context"
"testing"
"time"
"k8s.io/apimachinery/pkg/api/errors"
"sigs.k8s.io/controller-runtime/pkg/client"
logf "sigs.k8s.io/controller-runtime/pkg/log"
// . "github.com/onsi/ginkgo/v2"
// . "github.com/onsi/gomega"
"github.com/actions/actions-runner-controller/apis/actions.github.com/v1alpha1"
"github.com/actions/actions-runner-controller/github/actions/fake"
"github.com/rentziass/eventually"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
const (
autoscalingRunnerSetTestTimeout = time.Second * 5
autoscalingRunnerSetTestInterval = time.Millisecond * 250
autoscalingRunnerSetTestGitHubToken = "gh_token"
)
func TestAutoscalitRunnerSetReconciler_CreateRunnerScaleSet(t *testing.T) {
t.Parallel()
ctx := context.Background()
eventually := eventually.New(
eventually.WithTimeout(autoscalingRunnerSetTestTimeout),
eventually.WithInterval(autoscalingRunnerSetTestInterval),
)
autoscalingNS, mgr := createNamespace(t)
configSecret := createDefaultSecret(t, autoscalingNS.Name)
controller := &AutoscalingRunnerSetReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: logf.Log,
ControllerNamespace: autoscalingNS.Name,
DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
ActionsClient: fake.NewMultiClient(),
}
err := controller.SetupWithManager(mgr)
require.NoError(t, err, "failed to setup controller")
autoscalingRunnerSet := newAutoscalingRunnerSet(autoscalingNS.Name, configSecret.Name)
err = k8sClient.Create(ctx, autoscalingRunnerSet)
require.NoError(t, err, "failed to create AutoScalingRunnerSet")
startManagers(t, mgr)
// Check if finalizer is added
created := new(v1alpha1.AutoscalingRunnerSet)
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, created)
require.NoError(t, err)
require.Len(t, created.Finalizers, 1)
assert.Equal(t, created.Finalizers[0], autoscalingRunnerSetFinalizerName)
})
// Check if runner scale set is created on service
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, created)
require.NoError(t, err)
require.Contains(t, created.Annotations, runnerScaleSetIdKey)
assert.Equal(t, "1", created.Annotations[runnerScaleSetIdKey])
require.Contains(t, created.Annotations, runnerScaleSetRunnerGroupNameKey)
assert.Equal(t, "testgroup", created.Annotations[runnerScaleSetRunnerGroupNameKey])
})
// Check if ephemeral runner set is created
eventually.Must(t, func(t testing.TB) {
runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
err := k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
require.Len(t, runnerSetList.Items, 1)
})
// Check if listener is created
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, new(v1alpha1.AutoscalingListener))
require.NoError(t, err)
})
// Check if status is updated
runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
err = k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
assert.Len(t, runnerSetList.Items, 1, "Only one EphemeralRunnerSet should be created")
}
func TestAutoscalitRunnerSetReconciler_DeleteRunnerScaleSet(t *testing.T) {
t.Parallel()
ctx := context.Background()
eventually := eventually.New(
eventually.WithTimeout(autoscalingRunnerSetTestTimeout),
eventually.WithInterval(autoscalingRunnerSetTestInterval),
)
autoscalingNS, mgr := createNamespace(t)
configSecret := createDefaultSecret(t, autoscalingNS.Name)
controller := &AutoscalingRunnerSetReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: logf.Log,
ControllerNamespace: autoscalingNS.Name,
DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
ActionsClient: fake.NewMultiClient(),
}
err := controller.SetupWithManager(mgr)
require.NoError(t, err, "failed to setup controller")
autoscalingRunnerSet := newAutoscalingRunnerSet(autoscalingNS.Name, configSecret.Name)
err = k8sClient.Create(ctx, autoscalingRunnerSet)
require.NoError(t, err, "failed to create AutoScalingRunnerSet")
startManagers(t, mgr)
// Wait till the listener is created
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(
ctx,
client.ObjectKey{
Name: scaleSetListenerName(autoscalingRunnerSet),
Namespace: autoscalingRunnerSet.Namespace,
},
new(v1alpha1.AutoscalingListener),
)
require.NoError(t, err)
})
// Delete the AutoScalingRunnerSet
err = k8sClient.Delete(ctx, autoscalingRunnerSet)
require.NoError(t, err, "failed to delete AutoScalingRunnerSet")
// Check if the listener is deleted
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, new(v1alpha1.AutoscalingListener))
require.NotNil(t, err)
assert.True(t, errors.IsNotFound(err))
})
// Check if all the EphemeralRunnerSet is deleted
eventually.Must(t, func(t testing.TB) {
runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
err := k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
assert.Len(t, runnerSetList.Items, 0, "All EphemeralRunnerSet should be deleted")
})
// Check if the AutoScalingRunnerSet is deleted
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, new(v1alpha1.AutoscalingRunnerSet))
require.NotNil(t, err)
assert.True(t, errors.IsNotFound(err))
})
}
func TestAutoscalitRunnerSetReconciler_UpdateRunnerScaleSet(t *testing.T) {
t.Run("It should re-create EphemeralRunnerSet and Listener as needed when updating AutoScalingRunnerSet", func(t *testing.T) {
t.Parallel()
ctx := context.Background()
eventually := eventually.New(
eventually.WithTimeout(autoscalingRunnerSetTestTimeout),
eventually.WithInterval(autoscalingRunnerSetTestInterval),
)
autoscalingNS, mgr := createNamespace(t)
configSecret := createDefaultSecret(t, autoscalingNS.Name)
controller := &AutoscalingRunnerSetReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: logf.Log,
ControllerNamespace: autoscalingNS.Name,
DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
ActionsClient: fake.NewMultiClient(),
}
err := controller.SetupWithManager(mgr)
require.NoError(t, err, "failed to setup controller")
autoscalingRunnerSet := newAutoscalingRunnerSet(autoscalingNS.Name, configSecret.Name)
err = k8sClient.Create(ctx, autoscalingRunnerSet)
require.NoError(t, err, "failed to create AutoScalingRunnerSet")
startManagers(t, mgr)
// Wait till the listener is created
listener := new(v1alpha1.AutoscalingListener)
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, listener)
require.NoError(t, err)
})
runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
err = k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
require.Len(t, runnerSetList.Items, 1)
runnerSet := runnerSetList.Items[0]
// Update the AutoScalingRunnerSet.Spec.Template
// This should trigger re-creation of EphemeralRunnerSet and Listener
patched := autoscalingRunnerSet.DeepCopy()
patched.Spec.Template.Spec.PriorityClassName = "test-priority-class"
err = k8sClient.Patch(ctx, patched, client.MergeFrom(autoscalingRunnerSet))
require.NoError(t, err)
autoscalingRunnerSet = patched.DeepCopy()
// We should create a new EphemeralRunnerSet and delete the old one, eventually, we will have only one EphemeralRunnerSet
eventually.Must(t, func(t testing.TB) {
runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
err := k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
require.Len(t, runnerSetList.Items, 1)
assert.NotEqual(t, runnerSetList.Items[0].Labels[LabelKeyRunnerSpecHash], runnerSet.Labels[LabelKeyRunnerSpecHash])
})
// We should create a new listener
eventually.Must(t, func(t testing.TB) {
listener := new(v1alpha1.AutoscalingListener)
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, listener)
require.NoError(t, err)
assert.NotEqual(t, listener.Spec.EphemeralRunnerSetName, runnerSet.Name)
})
// Only update the Spec for the AutoScalingListener
// This should trigger re-creation of the Listener only
runnerSetList = new(v1alpha1.EphemeralRunnerSetList)
err = k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
require.Len(t, runnerSetList.Items, 1)
runnerSet = runnerSetList.Items[0]
listener = new(v1alpha1.AutoscalingListener)
err = k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, listener)
require.NoError(t, err)
patched = autoscalingRunnerSet.DeepCopy()
min := 10
patched.Spec.MinRunners = &min
err = k8sClient.Patch(ctx, patched, client.MergeFrom(autoscalingRunnerSet))
require.NoError(t, err)
// We should not re-create a new EphemeralRunnerSet
// TODO: make this test more robust/quicker, possibly by finding a way to
// deterministically wait for the patch to be applied
time.Sleep(2 * time.Second)
runnerSetList = new(v1alpha1.EphemeralRunnerSetList)
err = k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
require.NoError(t, err)
require.Len(t, runnerSetList.Items, 1)
require.Equal(t, runnerSetList.Items[0].UID, runnerSet.UID)
// We should only re-create a new listener
eventually.Must(t, func(t testing.TB) {
listener := new(v1alpha1.AutoscalingListener)
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, listener)
require.NoError(t, err)
assert.NotEqual(t, listener.UID, listener.UID)
})
})
t.Run("It should update RunnerScaleSet's runner group on service when it changes", func(t *testing.T) {
t.Parallel()
ctx := context.Background()
eventually := eventually.New(
eventually.WithTimeout(autoscalingRunnerSetTestTimeout),
eventually.WithInterval(autoscalingRunnerSetTestInterval),
)
autoscalingNS, mgr := createNamespace(t)
configSecret := createDefaultSecret(t, autoscalingNS.Name)
controller := &AutoscalingRunnerSetReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Log: logf.Log,
ControllerNamespace: autoscalingNS.Name,
DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
ActionsClient: fake.NewMultiClient(),
}
err := controller.SetupWithManager(mgr)
require.NoError(t, err, "failed to setup controller")
autoscalingRunnerSet := newAutoscalingRunnerSet(autoscalingNS.Name, configSecret.Name)
err = k8sClient.Create(ctx, autoscalingRunnerSet)
require.NoError(t, err, "failed to create AutoScalingRunnerSet")
startManagers(t, mgr)
updated := new(v1alpha1.AutoscalingRunnerSet)
// Wait till the listener is created
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(autoscalingRunnerSet), Namespace: autoscalingRunnerSet.Namespace}, updated)
require.NoError(t, err)
})
patched := autoscalingRunnerSet.DeepCopy()
patched.Spec.RunnerGroup = "testgroup2"
err = k8sClient.Patch(ctx, patched, client.MergeFrom(autoscalingRunnerSet))
require.NoError(t, err)
// Check if AutoScalingRunnerSet has the new runner group in its annotation
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, updated)
require.NoError(t, err)
assert.Equal(t, "testgroup2", updated.Annotations[runnerScaleSetRunnerGroupNameKey])
})
// delete the annotation and it should be re-added
patched = autoscalingRunnerSet.DeepCopy()
delete(patched.Annotations, runnerScaleSetRunnerGroupNameKey)
err = k8sClient.Patch(ctx, patched, client.MergeFrom(autoscalingRunnerSet))
require.NoError(t, err)
// Check if AutoScalingRunnerSet still has the runner group in its annotation
eventually.Must(t, func(t testing.TB) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, updated)
require.NoError(t, err)
assert.Equal(t, "testgroup2", updated.Annotations[runnerScaleSetRunnerGroupNameKey])
})
})
}
// var _ = Describe("Test AutoScalingRunnerSet controller", func() {
// var ctx context.Context
// var mgr ctrl.Manager
// var autoscalingNS *corev1.Namespace
// var autoscalingRunnerSet *v1alpha1.AutoscalingRunnerSet
// var configSecret *corev1.Secret
//
// BeforeEach(func() {
// ctx = context.Background()
// autoscalingNS, mgr = createNamespace(GinkgoT(), k8sClient)
// configSecret = createDefaultSecret(GinkgoT(), k8sClient, autoscalingNS.Name)
//
// controller := &AutoscalingRunnerSetReconciler{
// Client: mgr.GetClient(),
// Scheme: mgr.GetScheme(),
// Log: logf.Log,
// ControllerNamespace: autoscalingNS.Name,
// DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
// ActionsClient: fake.NewMultiClient(),
// }
// err := controller.SetupWithManager(mgr)
// Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
//
// min := 1
// max := 10
// autoscalingRunnerSet = &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "https://github.com/owner/repo",
// GitHubConfigSecret: configSecret.Name,
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err = k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// startManagers(GinkgoT(), mgr)
// })
//
// It("Should update Status on EphemeralRunnerSet status Update", func() {
// ars := new(v1alpha1.AutoscalingRunnerSet)
// Eventually(
// func() (bool, error) {
// err := k8sClient.Get(
// ctx,
// client.ObjectKey{
// Name: autoscalingRunnerSet.Name,
// Namespace: autoscalingRunnerSet.Namespace,
// },
// ars,
// )
// if err != nil {
// return false, err
// }
// return true, nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeTrue(), "AutoscalingRunnerSet should be created")
//
// runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
// Eventually(func() (int, error) {
// err := k8sClient.List(ctx, runnerSetList, client.InNamespace(ars.Namespace))
// if err != nil {
// return 0, err
// }
// return len(runnerSetList.Items), nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(1), "Failed to fetch runner set list")
//
// runnerSet := runnerSetList.Items[0]
// statusUpdate := runnerSet.DeepCopy()
// statusUpdate.Status.CurrentReplicas = 6
// statusUpdate.Status.FailedEphemeralRunners = 1
// statusUpdate.Status.RunningEphemeralRunners = 2
// statusUpdate.Status.PendingEphemeralRunners = 3
//
// desiredStatus := v1alpha1.AutoscalingRunnerSetStatus{
// CurrentRunners: statusUpdate.Status.CurrentReplicas,
// State: "",
// PendingEphemeralRunners: statusUpdate.Status.PendingEphemeralRunners,
// RunningEphemeralRunners: statusUpdate.Status.RunningEphemeralRunners,
// FailedEphemeralRunners: statusUpdate.Status.FailedEphemeralRunners,
// }
//
// err := k8sClient.Status().Patch(ctx, statusUpdate, client.MergeFrom(&runnerSet))
// Expect(err).NotTo(HaveOccurred(), "Failed to patch runner set status")
//
// Eventually(
// func() (v1alpha1.AutoscalingRunnerSetStatus, error) {
// updated := new(v1alpha1.AutoscalingRunnerSet)
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, updated)
// if err != nil {
// return v1alpha1.AutoscalingRunnerSetStatus{}, fmt.Errorf("failed to get AutoScalingRunnerSet: %w", err)
// }
// return updated.Status, nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(desiredStatus), "AutoScalingRunnerSet status should be updated")
// })
// })
//
// var _ = Describe("Test AutoScalingController updates", func() {
// Context("Creating autoscaling runner set with RunnerScaleSetName set", func() {
// var ctx context.Context
// var mgr ctrl.Manager
// var autoscalingNS *corev1.Namespace
// var autoscalingRunnerSet *v1alpha1.AutoscalingRunnerSet
// var configSecret *corev1.Secret
//
// BeforeEach(func() {
// ctx = context.Background()
// autoscalingNS, mgr = createNamespace(GinkgoT(), k8sClient)
// configSecret = createDefaultSecret(GinkgoT(), k8sClient, autoscalingNS.Name)
//
// controller := &AutoscalingRunnerSetReconciler{
// Client: mgr.GetClient(),
// Scheme: mgr.GetScheme(),
// Log: logf.Log,
// ControllerNamespace: autoscalingNS.Name,
// DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
// ActionsClient: fake.NewMultiClient(
// fake.WithDefaultClient(
// fake.NewFakeClient(
// fake.WithUpdateRunnerScaleSet(
// &actions.RunnerScaleSet{
// Id: 1,
// Name: "testset_update",
// RunnerGroupId: 1,
// RunnerGroupName: "testgroup",
// Labels: []actions.Label{{Type: "test", Name: "test"}},
// RunnerSetting: actions.RunnerSetting{},
// CreatedOn: time.Now(),
// RunnerJitConfigUrl: "test.test.test",
// Statistics: nil,
// },
// nil,
// ),
// ),
// nil,
// ),
// ),
// }
// err := controller.SetupWithManager(mgr)
// Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
//
// startManagers(GinkgoT(), mgr)
// })
//
// It("It should be create AutoScalingRunnerSet and has annotation for the RunnerScaleSetName", func() {
// min := 1
// max := 10
// autoscalingRunnerSet = &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "https://github.com/owner/repo",
// GitHubConfigSecret: configSecret.Name,
// MaxRunners: &max,
// MinRunners: &min,
// RunnerScaleSetName: "testset",
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err := k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// // Wait for the AutoScalingRunnerSet to be created with right annotation
// ars := new(v1alpha1.AutoscalingRunnerSet)
// Eventually(
// func() (string, error) {
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, ars)
// if err != nil {
// return "", err
// }
//
// if val, ok := ars.Annotations[runnerScaleSetNameKey]; ok {
// return val, nil
// }
//
// return "", nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(autoscalingRunnerSet.Spec.RunnerScaleSetName), "AutoScalingRunnerSet should have annotation for the RunnerScaleSetName")
//
// update := autoscalingRunnerSet.DeepCopy()
// update.Spec.RunnerScaleSetName = "testset_update"
// err = k8sClient.Patch(ctx, update, client.MergeFrom(autoscalingRunnerSet))
// Expect(err).NotTo(HaveOccurred(), "failed to update AutoScalingRunnerSet")
//
// // Wait for the AutoScalingRunnerSet to be updated with right annotation
// Eventually(
// func() (string, error) {
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, ars)
// if err != nil {
// return "", err
// }
//
// if val, ok := ars.Annotations[runnerScaleSetNameKey]; ok {
// return val, nil
// }
//
// return "", nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(update.Spec.RunnerScaleSetName), "AutoScalingRunnerSet should have a updated annotation for the RunnerScaleSetName")
// })
// })
// })
//
// var _ = Describe("Test AutoscalingController creation failures", func() {
// Context("When autoscaling runner set creation fails on the client", func() {
// var ctx context.Context
// var mgr ctrl.Manager
// var autoscalingNS *corev1.Namespace
//
// BeforeEach(func() {
// ctx = context.Background()
// autoscalingNS, mgr = createNamespace(GinkgoT(), k8sClient)
//
// controller := &AutoscalingRunnerSetReconciler{
// Client: mgr.GetClient(),
// Scheme: mgr.GetScheme(),
// Log: logf.Log,
// ControllerNamespace: autoscalingNS.Name,
// DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
// ActionsClient: fake.NewMultiClient(),
// }
// err := controller.SetupWithManager(mgr)
// Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
//
// startManagers(GinkgoT(), mgr)
// })
//
// It("It should be able to clean up if annotation related to scale set id does not exist", func() {
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "https://github.com/owner/repo",
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err := k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// // wait for the finalizer to be added
// ars := new(v1alpha1.AutoscalingRunnerSet)
// Eventually(
// func() (string, error) {
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, ars)
// if err != nil {
// return "", err
// }
// if len(ars.Finalizers) == 0 {
// return "", nil
// }
// return ars.Finalizers[0], nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(autoscalingRunnerSetFinalizerName), "AutoScalingRunnerSet should have a finalizer")
//
// ars.ObjectMeta.Annotations = make(map[string]string)
// err = k8sClient.Update(ctx, ars)
// Expect(err).NotTo(HaveOccurred(), "Update autoscaling runner set without annotation should be successful")
//
// Eventually(
// func() (bool, error) {
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, ars)
// if err != nil {
// return false, err
// }
// return len(ars.ObjectMeta.Annotations) == 0, nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(true), "Autoscaling runner set should be updated with empty annotations")
//
// err = k8sClient.Delete(ctx, ars)
// Expect(err).NotTo(HaveOccurred(), "Delete autoscaling runner set should be successful")
//
// Eventually(
// func() (bool, error) {
// updated := new(v1alpha1.AutoscalingRunnerSet)
// err := k8sClient.Get(ctx, client.ObjectKey{Name: autoscalingRunnerSet.Name, Namespace: autoscalingRunnerSet.Namespace}, updated)
// if err == nil {
// return false, nil
// }
// if !errors.IsNotFound(err) {
// return false, err
// }
//
// return !controllerutil.ContainsFinalizer(updated, autoscalingRunnerSetFinalizerName), nil
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingRunnerSetTestInterval,
// ).Should(BeEquivalentTo(true), "Finalizer and resource should eventually be deleted")
// })
// })
// })
//
// var _ = Describe("Test Client optional configuration", func() {
// Context("When specifying a proxy", func() {
// var ctx context.Context
// var mgr ctrl.Manager
// var autoscalingNS *corev1.Namespace
// var configSecret *corev1.Secret
// var controller *AutoscalingRunnerSetReconciler
//
// BeforeEach(func() {
// ctx = context.Background()
// autoscalingNS, mgr = createNamespace(GinkgoT(), k8sClient)
// configSecret = createDefaultSecret(GinkgoT(), k8sClient, autoscalingNS.Name)
//
// controller = &AutoscalingRunnerSetReconciler{
// Client: mgr.GetClient(),
// Scheme: mgr.GetScheme(),
// Log: logf.Log,
// ControllerNamespace: autoscalingNS.Name,
// DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
// ActionsClient: actions.NewMultiClient("test", logr.Discard()),
// }
// err := controller.SetupWithManager(mgr)
// Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
//
// startManagers(GinkgoT(), mgr)
// })
//
// It("should be able to make requests to a server using a proxy", func() {
// serverSuccessfullyCalled := false
// proxy := testserver.New(GinkgoT(), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// serverSuccessfullyCalled = true
// w.WriteHeader(http.StatusOK)
// }))
//
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "http://example.com/org/repo",
// GitHubConfigSecret: configSecret.Name,
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Proxy: &v1alpha1.ProxyConfig{
// HTTP: &v1alpha1.ProxyServerConfig{
// Url: proxy.URL,
// },
// },
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err := k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// // wait for server to be called
// Eventually(
// func() (bool, error) {
// return serverSuccessfullyCalled, nil
// },
// autoscalingRunnerSetTestTimeout,
// 1*time.Nanosecond,
// ).Should(BeTrue(), "server was not called")
// })
//
// It("should be able to make requests to a server using a proxy with user info", func() {
// serverSuccessfullyCalled := false
// proxy := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// header := r.Header.Get("Proxy-Authorization")
// Expect(header).NotTo(BeEmpty())
//
// header = strings.TrimPrefix(header, "Basic ")
// decoded, err := base64.StdEncoding.DecodeString(header)
// Expect(err).NotTo(HaveOccurred())
// Expect(string(decoded)).To(Equal("test:password"))
//
// serverSuccessfullyCalled = true
// w.WriteHeader(http.StatusOK)
// }))
// GinkgoT().Cleanup(func() {
// proxy.Close()
// })
//
// secretCredentials := &corev1.Secret{
// ObjectMeta: metav1.ObjectMeta{
// Name: "proxy-credentials",
// Namespace: autoscalingNS.Name,
// },
// Data: map[string][]byte{
// "username": []byte("test"),
// "password": []byte("password"),
// },
// }
//
// err := k8sClient.Create(ctx, secretCredentials)
// Expect(err).NotTo(HaveOccurred(), "failed to create secret credentials")
//
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "http://example.com/org/repo",
// GitHubConfigSecret: configSecret.Name,
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Proxy: &v1alpha1.ProxyConfig{
// HTTP: &v1alpha1.ProxyServerConfig{
// Url: proxy.URL,
// CredentialSecretRef: "proxy-credentials",
// },
// },
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err = k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// // wait for server to be called
// Eventually(
// func() (bool, error) {
// return serverSuccessfullyCalled, nil
// },
// autoscalingRunnerSetTestTimeout,
// 1*time.Nanosecond,
// ).Should(BeTrue(), "server was not called")
// })
// })
//
// Context("When specifying a configmap for root CAs", func() {
// var ctx context.Context
// var mgr ctrl.Manager
// var autoscalingNS *corev1.Namespace
// var configSecret *corev1.Secret
// var rootCAConfigMap *corev1.ConfigMap
// var controller *AutoscalingRunnerSetReconciler
//
// BeforeEach(func() {
// ctx = context.Background()
// autoscalingNS, mgr = createNamespace(GinkgoT(), k8sClient)
// configSecret = createDefaultSecret(GinkgoT(), k8sClient, autoscalingNS.Name)
//
// cert, err := os.ReadFile(filepath.Join(
// "../../",
// "github",
// "actions",
// "testdata",
// "rootCA.crt",
// ))
// Expect(err).NotTo(HaveOccurred(), "failed to read root CA cert")
// rootCAConfigMap = &corev1.ConfigMap{
// ObjectMeta: metav1.ObjectMeta{
// Name: "root-ca-configmap",
// Namespace: autoscalingNS.Name,
// },
// Data: map[string]string{
// "rootCA.crt": string(cert),
// },
// }
// err = k8sClient.Create(ctx, rootCAConfigMap)
// Expect(err).NotTo(HaveOccurred(), "failed to create configmap with root CAs")
//
// controller = &AutoscalingRunnerSetReconciler{
// Client: mgr.GetClient(),
// Scheme: mgr.GetScheme(),
// Log: logf.Log,
// ControllerNamespace: autoscalingNS.Name,
// DefaultRunnerScaleSetListenerImage: "ghcr.io/actions/arc",
// ActionsClient: fake.NewMultiClient(),
// }
// err = controller.SetupWithManager(mgr)
// Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
//
// startManagers(GinkgoT(), mgr)
// })
//
// It("should be able to make requests to a server using root CAs", func() {
// controller.ActionsClient = actions.NewMultiClient("test", logr.Discard())
//
// certsFolder := filepath.Join(
// "../../",
// "github",
// "actions",
// "testdata",
// )
// certPath := filepath.Join(certsFolder, "server.crt")
// keyPath := filepath.Join(certsFolder, "server.key")
//
// serverSuccessfullyCalled := false
// server := testserver.NewUnstarted(GinkgoT(), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// serverSuccessfullyCalled = true
// w.WriteHeader(http.StatusOK)
// }))
// cert, err := tls.LoadX509KeyPair(certPath, keyPath)
// Expect(err).NotTo(HaveOccurred(), "failed to load server cert")
//
// server.TLS = &tls.Config{Certificates: []tls.Certificate{cert}}
// server.StartTLS()
//
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: server.ConfigURLForOrg("my-org"),
// GitHubConfigSecret: configSecret.Name,
// GitHubServerTLS: &v1alpha1.GitHubServerTLSConfig{
// CertificateFrom: &v1alpha1.TLSCertificateSource{
// ConfigMapKeyRef: &corev1.ConfigMapKeySelector{
// LocalObjectReference: corev1.LocalObjectReference{
// Name: rootCAConfigMap.Name,
// },
// Key: "rootCA.crt",
// },
// },
// },
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err = k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// // wait for server to be called
// Eventually(
// func() (bool, error) {
// return serverSuccessfullyCalled, nil
// },
// autoscalingRunnerSetTestTimeout,
// 1*time.Nanosecond,
// ).Should(BeTrue(), "server was not called")
// })
//
// It("it creates a listener referencing the right configmap for TLS", func() {
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "https://github.com/owner/repo",
// GitHubConfigSecret: configSecret.Name,
// GitHubServerTLS: &v1alpha1.GitHubServerTLSConfig{
// CertificateFrom: &v1alpha1.TLSCertificateSource{
// ConfigMapKeyRef: &corev1.ConfigMapKeySelector{
// LocalObjectReference: corev1.LocalObjectReference{
// Name: rootCAConfigMap.Name,
// },
// Key: "rootCA.crt",
// },
// },
// },
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err := k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// Eventually(
// func(g Gomega) {
// listener := new(v1alpha1.AutoscalingListener)
// err := k8sClient.Get(
// ctx,
// client.ObjectKey{
// Name: scaleSetListenerName(autoscalingRunnerSet),
// Namespace: autoscalingRunnerSet.Namespace,
// },
// listener,
// )
// g.Expect(err).NotTo(HaveOccurred(), "failed to get listener")
//
// g.Expect(listener.Spec.GitHubServerTLS).NotTo(BeNil(), "listener does not have TLS config")
// g.Expect(listener.Spec.GitHubServerTLS).To(BeEquivalentTo(autoscalingRunnerSet.Spec.GitHubServerTLS), "listener does not have TLS config")
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingListenerTestInterval,
// ).Should(Succeed(), "tls config is incorrect")
// })
//
// It("it creates an ephemeral runner set referencing the right configmap for TLS", func() {
// min := 1
// max := 10
// autoscalingRunnerSet := &v1alpha1.AutoscalingRunnerSet{
// ObjectMeta: metav1.ObjectMeta{
// Name: "test-asrs",
// Namespace: autoscalingNS.Name,
// },
// Spec: v1alpha1.AutoscalingRunnerSetSpec{
// GitHubConfigUrl: "https://github.com/owner/repo",
// GitHubConfigSecret: configSecret.Name,
// GitHubServerTLS: &v1alpha1.GitHubServerTLSConfig{
// CertificateFrom: &v1alpha1.TLSCertificateSource{
// ConfigMapKeyRef: &corev1.ConfigMapKeySelector{
// LocalObjectReference: corev1.LocalObjectReference{
// Name: rootCAConfigMap.Name,
// },
// Key: "rootCA.crt",
// },
// },
// },
// MaxRunners: &max,
// MinRunners: &min,
// RunnerGroup: "testgroup",
// Template: corev1.PodTemplateSpec{
// Spec: corev1.PodSpec{
// Containers: []corev1.Container{
// {
// Name: "runner",
// Image: "ghcr.io/actions/runner",
// },
// },
// },
// },
// },
// }
//
// err := k8sClient.Create(ctx, autoscalingRunnerSet)
// Expect(err).NotTo(HaveOccurred(), "failed to create AutoScalingRunnerSet")
//
// Eventually(
// func(g Gomega) {
// runnerSetList := new(v1alpha1.EphemeralRunnerSetList)
// err := k8sClient.List(ctx, runnerSetList, client.InNamespace(autoscalingRunnerSet.Namespace))
// g.Expect(err).NotTo(HaveOccurred(), "failed to list EphemeralRunnerSet")
// g.Expect(runnerSetList.Items).To(HaveLen(1), "expected 1 EphemeralRunnerSet to be created")
//
// runnerSet := &runnerSetList.Items[0]
//
// g.Expect(runnerSet.Spec.EphemeralRunnerSpec.GitHubServerTLS).NotTo(BeNil(), "expected EphemeralRunnerSpec.GitHubServerTLS to be set")
// g.Expect(runnerSet.Spec.EphemeralRunnerSpec.GitHubServerTLS).To(BeEquivalentTo(autoscalingRunnerSet.Spec.GitHubServerTLS), "EphemeralRunnerSpec does not have TLS config")
// },
// autoscalingRunnerSetTestTimeout,
// autoscalingListenerTestInterval,
// ).Should(Succeed())
// })
// })
// })