actions-runner-controller/controllers
Yusuke Kuoka 022007078e
Compact excessive error message on runnerreplicaset status update conflict (#350)
We occasionally see logs like the below:

```
2021-02-24T02:48:26.769ZERRORFailed to update runner status{"runnerreplicaset": "testns-244ol/example-runnerdeploy-j5wzf", "error": "Operation cannot be fulfilled on runnerreplicasets.actions.summerwind.dev \"example-runnerdeploy-j5wzf\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/go-logr/zapr.(*zapLogger).Error
/home/runner/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
github.com/summerwind/actions-runner-controller/controllers.(*RunnerReplicaSetReconciler).Reconcile
/home/runner/work/actions-runner-controller/actions-runner-controller/controllers/runnerreplicaset_controller.go:207
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:256
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88
2021-02-24T02:48:26.769ZERRORcontroller-runtime.controllerReconciler error{"controller": "testns-244olrunnerreplicaset", "request": "testns-244ol/example-runnerdeploy-j5wzf", "error": "Operation cannot be fulfilled on runnerreplicasets.actions.summerwind.dev \"example-runnerdeploy-j5wzf\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/go-logr/zapr.(*zapLogger).Error
/home/runner/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88
```

which can be compacted into one-liner, without the useless stack trace, without double-logging the same error from the logger and the controller.
2021-02-25 09:01:02 +09:00
..
testdata Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
autoscaling.go `scale{Up,Down}Adjustment` to add/remove constant number of replicas on scaling (#315) 2021-02-16 17:16:26 +09:00
autoscaling_test.go Fix TotalNumberOfQueuedAndInProgressWorkflowRuns to work with a lot of remaining `completed` jobs (#316) 2021-02-16 18:55:55 +09:00
horizontal_runner_autoscaler_webhook.go Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
horizontal_runner_autoscaler_webhook_on_check_run.go feat: HorizontalRunnerAutoscaler Webhook server (#282) 2021-02-07 17:37:27 +09:00
horizontal_runner_autoscaler_webhook_on_pull_request.go feat: HorizontalRunnerAutoscaler Webhook server (#282) 2021-02-07 17:37:27 +09:00
horizontal_runner_autoscaler_webhook_on_push.go feat: HorizontalRunnerAutoscaler Webhook server (#282) 2021-02-07 17:37:27 +09:00
horizontal_runner_autoscaler_webhook_test.go Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
horizontalrunnerautoscaler_controller.go Fix failure while saving HRA status after running controller for a while (#348) 2021-02-24 11:20:21 +09:00
integration_test.go Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
runner_controller.go Handle offline runners gracefully (#341) 2021-02-22 10:08:04 +09:00
runnerdeployment_controller.go Add integration test for autoscaling on check_run webhook event 2021-02-19 10:33:04 +09:00
runnerdeployment_controller_test.go Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
runnerreplicaset_controller.go Compact excessive error message on runnerreplicaset status update conflict (#350) 2021-02-25 09:01:02 +09:00
runnerreplicaset_controller_test.go Fix panic on webhook for user-owned repository (#344) 2021-02-23 08:05:25 +09:00
suite_test.go feat: HorizontalRunnerAutoscaler Webhook server (#282) 2021-02-07 17:37:27 +09:00
utils.go feat: EKS IAM Roles for Service Accounts for Runner Pods (#226) 2020-12-08 17:56:06 +09:00
utils_test.go feat: EKS IAM Roles for Service Accounts for Runner Pods (#226) 2020-12-08 17:56:06 +09:00