mirror of
https://github.com/actions-runner-controller/actions-runner-controller.git
synced 2026-09-30 21:10:06 +02:00
Nikola JokicandCopilot App
41d05325c2
An outdated runner used to flip the whole scale set into the Outdated
phase permanently, which tears down the listener and switches the scale
set off. That verdict outlived the runner spec it was about: a runner
busy with a job survives the revision cleanup that follows a spec
update, and only reports Outdated once the job finishes. The result was
that a freshly applied fix could be discarded by a runner that never ran
it.
Runners are now stamped with the actionable revision they were built
from. An Outdated runner whose revision is behind the applied revision is
considered stale: it is deleted so the scaling logic replaces it with one
built from the current spec, and it no longer contributes to the set's
phase. A runner at the current revision still marks the set Outdated, so
a genuinely bad spec is still surfaced.
Two supporting fixes:
- patchAppliedActionableRevisionStatus now recomputes the phase in both
directions. It only ever forced Running, so the early-return path
could leave a stale Outdated behind.
- The AutoscalingRunnerSet only tears down on an Outdated set once that
set has applied its current actionable revision. Otherwise a spec
update races the EphemeralRunnerSet controller and the teardown fires
against a phase that predates the update.
Runners created before this change parse to revision 0, which matches
the zero value of AppliedActionableRevision, so they are treated as
current until a revision is actually applied.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
92 lines
3.8 KiB
Go
92 lines
3.8 KiB
Go
package actionsgithubcom
|
|
|
|
import (
|
|
"github.com/actions/actions-runner-controller/logging"
|
|
)
|
|
|
|
const (
|
|
LabelKeyRunnerTemplateHash = "runner-template-hash"
|
|
LabelKeyPodTemplateHash = "pod-template-hash"
|
|
)
|
|
|
|
const (
|
|
EnvVarRunnerJITConfig = "ACTIONS_RUNNER_INPUT_JITCONFIG"
|
|
EnvVarRunnerExtraUserAgent = "GITHUB_ACTIONS_RUNNER_EXTRA_USER_AGENT"
|
|
// Environment variable setting the exit code to return when the runner version is deprecated.
|
|
// This is used by the runner to signal to the controller that it should switch off the scaleset.
|
|
EnvVarRunnerDeprecatedExitCode = "ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE"
|
|
)
|
|
|
|
// Environment variable names used to set proxy variables for containers
|
|
const (
|
|
EnvVarHTTPProxy = "http_proxy"
|
|
EnvVarHTTPSProxy = "https_proxy"
|
|
EnvVarNoProxy = "no_proxy"
|
|
)
|
|
|
|
// Labels applied to resources
|
|
const (
|
|
// Kubernetes labels
|
|
LabelKeyKubernetesPartOf = "app.kubernetes.io/part-of"
|
|
LabelKeyKubernetesComponent = "app.kubernetes.io/component"
|
|
LabelKeyKubernetesVersion = "app.kubernetes.io/version"
|
|
|
|
// Well-known Kubernetes node labels
|
|
LabelKeyKubernetesOS = "kubernetes.io/os"
|
|
|
|
// Github labels
|
|
LabelKeyGitHubScaleSetName = "actions.github.com/scale-set-name"
|
|
LabelKeyGitHubScaleSetNamespace = "actions.github.com/scale-set-namespace"
|
|
LabelKeyGitHubEnterprise = "actions.github.com/enterprise"
|
|
LabelKeyGitHubOrganization = "actions.github.com/organization"
|
|
LabelKeyGitHubRepository = "actions.github.com/repository"
|
|
)
|
|
|
|
// AutoscalingRunnerSetCleanupFinalizerName is a finalizer used to protect resources
|
|
// from deletion while AutoscalingRunnerSet is running
|
|
const AutoscalingRunnerSetCleanupFinalizerName = "actions.github.com/cleanup-protection"
|
|
|
|
const (
|
|
AnnotationKeyGitHubRunnerGroupName = "actions.github.com/runner-group-name"
|
|
AnnotationKeyGitHubRunnerScaleSetName = "actions.github.com/runner-scale-set-name"
|
|
AnnotationKeyPatchID = "actions.github.com/patch-id"
|
|
// AnnotationKeyActionableRevision records the EphemeralRunnerSet
|
|
// Spec.ActionableRevision that was in effect when the runner was created. It
|
|
// lets the set tell apart a runner that reported Outdated against the current
|
|
// runner spec from one that reported it against a spec that has since been
|
|
// updated.
|
|
AnnotationKeyActionableRevision = "actions.github.com/actionable-revision"
|
|
)
|
|
|
|
// Labels applied to listener roles
|
|
const (
|
|
labelKeyListenerName = "auto-scaling-listener-name"
|
|
labelKeyListenerNamespace = "auto-scaling-listener-namespace"
|
|
)
|
|
|
|
// Annotations applied for later cleanup of resources
|
|
const (
|
|
AnnotationKeyManagerRoleBindingName = "actions.github.com/cleanup-manager-role-binding"
|
|
AnnotationKeyManagerRoleName = "actions.github.com/cleanup-manager-role-name"
|
|
AnnotationKeyKubernetesModeRoleName = "actions.github.com/cleanup-kubernetes-mode-role-name"
|
|
AnnotationKeyKubernetesModeRoleBindingName = "actions.github.com/cleanup-kubernetes-mode-role-binding-name"
|
|
AnnotationKeyKubernetesModeServiceAccountName = "actions.github.com/cleanup-kubernetes-mode-service-account-name"
|
|
AnnotationKeyGitHubSecretName = "actions.github.com/cleanup-github-secret-name"
|
|
AnnotationKeyNoPermissionServiceAccountName = "actions.github.com/cleanup-no-permission-service-account-name"
|
|
)
|
|
|
|
// DefaultScaleSetListenerLogLevel is the default log level applied
|
|
const DefaultScaleSetListenerLogLevel = string(logging.LogLevelDebug)
|
|
|
|
// DefaultScaleSetListenerLogFormat is the default log format applied
|
|
const DefaultScaleSetListenerLogFormat = string(logging.LogFormatText)
|
|
|
|
// ownerKey is field selector matching the owner name of a particular resource
|
|
const resourceOwnerKey = ".metadata.controller"
|
|
|
|
// EphemeralRunner pod creation failure reasons
|
|
const (
|
|
ReasonTooManyPodFailures = "TooManyPodFailures"
|
|
ReasonInvalidPodFailure = "InvalidPod"
|
|
)
|