public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: Do not block indefinitely on runner that cannot be deleted due to 403

This commit is contained in:
Yusuke Kuoka 2022-03-13 12:12:01 +00:00
parent 8ca39caff5
commit f153870f5f
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
controllers/runner_graceful_stop.go
View File

@ -120,6 +120,15 @@ func ensureRunnerUnregistration(ctx context.Context, retryDelay time.Duration, l
errRes := &gogithub.ErrorResponse{} errRes := &gogithub.ErrorResponse{}
if errors.As(err, &errRes) { if errors.As(err, &errRes) {
if errRes.Response.StatusCode == 403 {
log.Error(err, "Unable to unregister due to permission error. "+
"Perhaps you've changed the permissions of PAT or GitHub App, or you updated authentication method of ARC in a wrong way? "+
"ARC considers it as already unregistered and continue removing the pod. "+
"You may need to remove the runner on GitHub UI.")
return nil, nil
}
runner, _ := getRunner(ctx, ghClient, enterprise, organization, repository, runner) runner, _ := getRunner(ctx, ghClient, enterprise, organization, repository, runner)
var runnerID int64 var runnerID int64