From dee997b44e84f638e0a6507c6564d0ff901e28de Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Fri, 19 Mar 2021 07:01:24 +0900 Subject: [PATCH 1/2] Fix `Failed to update runner status for Registration` errors Fixes #400 --- api/v1alpha1/runner_types.go | 15 +++++++++------ .../crds/actions.summerwind.dev_runners.yaml | 5 ----- .../crd/bases/actions.summerwind.dev_runners.yaml | 5 ----- 3 files changed, 9 insertions(+), 16 deletions(-) diff --git a/api/v1alpha1/runner_types.go b/api/v1alpha1/runner_types.go index c3fa5b27..99e1dd5e 100644 --- a/api/v1alpha1/runner_types.go +++ b/api/v1alpha1/runner_types.go @@ -121,13 +121,16 @@ func (rs *RunnerSpec) ValidateRepository() error { // RunnerStatus defines the observed state of Runner type RunnerStatus struct { + // +optional Registration RunnerStatusRegistration `json:"registration"` - Phase string `json:"phase"` - Reason string `json:"reason"` - Message string `json:"message"` - - //+optional - LastRegistrationCheckTime *metav1.Time `json:"lastRegistrationCheckTime"` + // +optional + Phase string `json:"phase,omitempty"` + // +optional + Reason string `json:"reason,omitempty"` + // +optional + Message string `json:"message,omitempty"` + // +optional + LastRegistrationCheckTime *metav1.Time `json:"lastRegistrationCheckTime,omitempty"` } // RunnerStatusRegistration contains runner registration status diff --git a/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml b/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml index 0f77c190..86d42c9c 100644 --- a/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml +++ b/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml @@ -1572,11 +1572,6 @@ spec: - expiresAt - token type: object - required: - - message - - phase - - reason - - registration type: object type: object version: v1alpha1 diff --git a/config/crd/bases/actions.summerwind.dev_runners.yaml b/config/crd/bases/actions.summerwind.dev_runners.yaml index 0f77c190..86d42c9c 100644 --- a/config/crd/bases/actions.summerwind.dev_runners.yaml +++ b/config/crd/bases/actions.summerwind.dev_runners.yaml @@ -1572,11 +1572,6 @@ spec: - expiresAt - token type: object - required: - - message - - phase - - reason - - registration type: object type: object version: v1alpha1 From 23a45eaf87f34d300b24eb20b730e27de4f09ccf Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Fri, 19 Mar 2021 08:37:17 +0900 Subject: [PATCH 2/2] Bump chart version --- charts/actions-runner-controller/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/actions-runner-controller/Chart.yaml b/charts/actions-runner-controller/Chart.yaml index b68e248b..1c7b02db 100644 --- a/charts/actions-runner-controller/Chart.yaml +++ b/charts/actions-runner-controller/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.10.2 +version: 0.10.3 home: https://github.com/summerwind/actions-runner-controller