public_git/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git synced 2026-10-19 09:45:04 +02:00
Code Issues Projects Releases Wiki Activity

Reduce ephemeral runner status contention (#4692)

Browse Source
This commit is contained in:
Nikola Jokic
2026-09-29 12:31:31 +02:00
committed by GitHub
parent f858710caa
commit c48f2ca5e9
15 changed files with 244 additions and 258 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/actions.github.com/ephemeralrunner_creation_order_test.go
+15 -7
View File
@@ -37,7 +37,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/interceptor"
)
func TestReconcileDefersRunnerIdentityUntilPodExists(t *testing.T) {
func TestReconcileDefersRunnerIdentityUntilPodReportsStatus(t *testing.T) {
ctx := context.Background()
key := types.NamespacedName{Namespace: "default", Name: "test-runner"}
@@ -73,7 +73,7 @@ func TestReconcileDefersRunnerIdentityUntilPodExists(t *testing.T) {
c := ctrlfake.NewClientBuilder().
WithScheme(scheme).
WithObjects(runner, secret).
WithStatusSubresource(&v1alpha1.EphemeralRunner{}).
WithStatusSubresource(&v1alpha1.EphemeralRunner{}, &corev1.Pod{}).
WithInterceptorFuncs(interceptor.Funcs{
SubResourcePatch: func(ctx context.Context, clt client.Client, subResourceName string, obj client.Object, patch client.Patch, opts ...client.SubResourcePatchOption) error {
if _, ok := obj.(*v1alpha1.EphemeralRunner); ok {
@@ -121,12 +121,20 @@ func TestReconcileDefersRunnerIdentityUntilPodExists(t *testing.T) {
assert.Empty(t, getRunner().Status.RunnerName)
assert.Zero(t, statusPatchAttempts, "the runner identity must not delay Pod creation")
// This is the same state after a controller crash following Pod creation:
// the next reconcile finds the Pod and restores the identity from the JIT
// secret. A transient patch failure returns an error for reconciliation to
// retry without creating another Pod.
// Identity remains deferred until the Pod reports a non-terminal container
// status. A transient failure of that coalesced status patch returns an
// error for reconciliation to retry without creating another Pod.
pod := new(corev1.Pod)
require.NoError(t, c.Get(ctx, key, pod))
pod.Status.Phase = corev1.PodRunning
pod.Status.ContainerStatuses = []corev1.ContainerStatus{{
Name: v1alpha1.EphemeralRunnerContainerName,
State: corev1.ContainerState{Running: &corev1.ContainerStateRunning{}},
}}
require.NoError(t, c.Status().Update(ctx, pod))
_, err = newReconciler().Reconcile(ctx, ctrl.Request{NamespacedName: key})
require.ErrorContains(t, err, "failed to update runner status for RunnerId/RunnerName")
require.ErrorContains(t, err, "failed to update runner status for Phase/Reason/Message/Ready")
assert.Equal(t, 1, podCount())
assert.Zero(t, getRunner().Status.RunnerID)
assert.Empty(t, getRunner().Status.RunnerName)