From b1da3092fb0e25c2583e3479f6c756cff567fff1 Mon Sep 17 00:00:00 2001 From: Moto Ishizawa Date: Sun, 15 Mar 2020 21:55:38 +0900 Subject: [PATCH] Revert test comment --- controllers/runnerdeployment_controller_test.go | 9 +++------ controllers/runnerreplicaset_controller_test.go | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/controllers/runnerdeployment_controller_test.go b/controllers/runnerdeployment_controller_test.go index a0893eca..51a5656d 100644 --- a/controllers/runnerdeployment_controller_test.go +++ b/controllers/runnerdeployment_controller_test.go @@ -131,12 +131,9 @@ var _ = Context("Inside of a new namespace", func() { } { - // We wrap the update in the Eventually block to avoid the below error - // that occurs due to concurrent modification made by the controller - // to update .Status.AvailableReplicas and .Status.ReadyReplicas - // Operation cannot be fulfilled on runnerreplicasets.actions.summerwind.dev - // "example-runnerreplciaset": the object has been modified; please - // apply your changes to the latest version and try again. + // We wrap the update in the Eventually block to avoid the below error that occurs due to concurrent modification + // made by the controller to update .Status.AvailableReplicas and .Status.ReadyReplicas + // Operation cannot be fulfilled on runnersets.actions.summerwind.dev "example-runnerset": the object has been modified; please apply your changes to the latest version and try again Eventually(func() error { var rd actionsv1alpha1.RunnerDeployment diff --git a/controllers/runnerreplicaset_controller_test.go b/controllers/runnerreplicaset_controller_test.go index b96ba57c..13774baa 100644 --- a/controllers/runnerreplicaset_controller_test.go +++ b/controllers/runnerreplicaset_controller_test.go @@ -161,12 +161,9 @@ var _ = Context("Inside of a new namespace", func() { } { - // We wrap the update in the Eventually block to avoid the below error - // that occurs due to concurrent modification made by the controller - // to update .Status.AvailableReplicas and .Status.ReadyReplicas - // Operation cannot be fulfilled on runnerreplicasets.actions.summerwind.dev - // "example-runnerreplicaset": the object has been modified; please apply - // your changes to the latest version and try again. + // We wrap the update in the Eventually block to avoid the below error that occurs due to concurrent modification + // made by the controller to update .Status.AvailableReplicas and .Status.ReadyReplicas + // Operation cannot be fulfilled on runnersets.actions.summerwind.dev "example-runnerset": the object has been modified; please apply your changes to the latest version and try again Eventually(func() error { var rs actionsv1alpha1.RunnerReplicaSet