From a7ef871248fab50a7e776be1c37a500932cfaae7 Mon Sep 17 00:00:00 2001
From: Stewart Thomson <108886656+sthomson-wyn@users.noreply.github.com>
Date: Sun, 2 Apr 2023 20:06:59 -0400
Subject: [PATCH] Check if appID and instID are non-empty before attempting to
 parseInt (#2463)

---
 .../actions.summerwind.net/multi_githubclient.go | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/controllers/actions.summerwind.net/multi_githubclient.go b/controllers/actions.summerwind.net/multi_githubclient.go
index 912a410a..4c96deb6 100644
--- a/controllers/actions.summerwind.net/multi_githubclient.go
+++ b/controllers/actions.summerwind.net/multi_githubclient.go
@@ -285,16 +285,20 @@ func secretDataToGitHubClientConfig(data map[string][]byte) (*github.Config, err
 
 	appID := string(data["github_app_id"])
 
-	conf.AppID, err = strconv.ParseInt(appID, 10, 64)
-	if err != nil {
-		return nil, err
+	if appID != "" {
+		conf.AppID, err = strconv.ParseInt(appID, 10, 64)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	instID := string(data["github_app_installation_id"])
 
-	conf.AppInstallationID, err = strconv.ParseInt(instID, 10, 64)
-	if err != nil {
-		return nil, err
+	if instID != "" {
+		conf.AppInstallationID, err = strconv.ParseInt(instID, 10, 64)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	conf.AppPrivateKey = string(data["github_app_private_key"])