From a46b8aaa7e411fe049ba2223ffb7fc53f70c3433 Mon Sep 17 00:00:00 2001
From: Frank Bernhardt <Frank.Bernhardt@quantum-machines.co>
Date: Sat, 21 Mar 2026 16:12:43 +0100
Subject: [PATCH] feat(chart): make DinD sidecar image configurable via values

Add containerMode.dindImage to allow overriding the hardcoded
docker:dind image in the DinD sidecar container.

This enables users to provide a custom DinD image with pre-configured
daemon.json (e.g., registry mirrors for pull-through caches, insecure
registries) without having to abandon containerMode entirely and
manually define the full pod spec.

Closes #3709
---
 charts/gha-runner-scale-set/templates/_helpers.tpl | 2 +-
 charts/gha-runner-scale-set/values.yaml            | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/charts/gha-runner-scale-set/templates/_helpers.tpl b/charts/gha-runner-scale-set/templates/_helpers.tpl
index 53b1c2b3..5b6dd174 100644
--- a/charts/gha-runner-scale-set/templates/_helpers.tpl
+++ b/charts/gha-runner-scale-set/templates/_helpers.tpl
@@ -110,7 +110,7 @@ volumeMounts:
 {{- end }}
 
 {{- define "gha-runner-scale-set.dind-container" -}}
-image: docker:dind
+image: {{ .Values.containerMode.dindImage | default "docker:dind" }}
 args:
   - dockerd
   - --host=unix:///var/run/docker.sock
diff --git a/charts/gha-runner-scale-set/values.yaml b/charts/gha-runner-scale-set/values.yaml
index 4b4640cf..b05b5629 100644
--- a/charts/gha-runner-scale-set/values.yaml
+++ b/charts/gha-runner-scale-set/values.yaml
@@ -118,6 +118,10 @@ githubConfigSecret:
 ## empty, and configuration should be applied to the template.
 # containerMode:
 #   type: "dind"  ## type can be set to "dind", "kubernetes", or "kubernetes-novolume"
+#   ## Optional: override the default docker:dind image used for the DinD sidecar container.
+#   ## This is useful for using a custom image with pre-configured daemon.json
+#   ## (e.g., registry mirrors, insecure registries) or other customizations.
+#   # dindImage: "docker:dind"
 #   ## the following is required when containerMode.type=kubernetes
 #   kubernetesModeWorkVolumeClaim:
 #     accessModes: ["ReadWriteOnce"]