public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix GET validation for lowercase http methods (#2497) 

Some requests send method in lowercase (verified with curl and as a default for AWS ALB health check requests), but Go HTTP library constant MethodGet is in upper.
This commit is contained in:
argokasper 2023-04-27 07:22:41 +03:00 committed by GitHub
parent 04fb9f4fa1
commit a2d4b95b79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
controllers/actions.summerwind.net/horizontal_runner_autoscaler_webhook.go
View File

@ -115,7 +115,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) Handle(w http.Respons
}() }()
// respond ok to GET / e.g. for health check // respond ok to GET / e.g. for health check
if r.Method == http.MethodGet { if strings.ToUpper(r.Method) == http.MethodGet {
ok = true ok = true
fmt.Fprintln(w, "webhook server is running") fmt.Fprintln(w, "webhook server is running")
return return