From 9890c0592d670a354918f07d6b3aefa84108dabd Mon Sep 17 00:00:00 2001 From: Nikola Jokic Date: Fri, 27 Jun 2025 12:05:43 +0200 Subject: [PATCH] Explicitly requeue during backoff ephemeral runner (#4152) --- .../actions.github.com/ephemeralrunner_controller.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/controllers/actions.github.com/ephemeralrunner_controller.go b/controllers/actions.github.com/ephemeralrunner_controller.go index 5324c036..74138fc7 100644 --- a/controllers/actions.github.com/ephemeralrunner_controller.go +++ b/controllers/actions.github.com/ephemeralrunner_controller.go @@ -201,12 +201,16 @@ func (r *EphemeralRunnerReconciler) Reconcile(ctx context.Context, req ctrl.Requ backoffDuration := failedRunnerBackoff[len(ephemeralRunner.Status.Failures)] nextReconciliation := lastFailure.Add(backoffDuration) if !lastFailure.IsZero() && now.Before(&metav1.Time{Time: nextReconciliation}) { + requeueAfter := nextReconciliation.Sub(now.Time) log.Info("Backing off the next reconciliation due to failure", "lastFailure", lastFailure, "nextReconciliation", nextReconciliation, - "requeueAfter", nextReconciliation.Sub(now.Time), + "requeueAfter", requeueAfter, ) - return ctrl.Result{RequeueAfter: now.Sub(nextReconciliation)}, nil + return ctrl.Result{ + Requeue: true, + RequeueAfter: requeueAfter, + }, nil } secret := new(corev1.Secret)