Merge pull request #182 from callum-tait-pbx/docs/improvements
docs/improvements
This commit is contained in:
commit
8ccf64080c
24
README.md
24
README.md
|
|
@ -37,6 +37,12 @@ There are two ways for actions-runner-controller to authenticate with the GitHub
|
||||||
1. Using GitHub App.
|
1. Using GitHub App.
|
||||||
2. Using Personal Access Token.
|
2. Using Personal Access Token.
|
||||||
|
|
||||||
|
Regardless of which authentication method you use, the same permissions are required, those permissions are:
|
||||||
|
- Repository: Administration (read/write)
|
||||||
|
- Repository: Actions (read)
|
||||||
|
- Organization: Self-hosted runners (read/write)
|
||||||
|
|
||||||
|
|
||||||
**NOTE: It is extremely important to only follow one of the sections below and not both.**
|
**NOTE: It is extremely important to only follow one of the sections below and not both.**
|
||||||
|
|
||||||
### Using GitHub App
|
### Using GitHub App
|
||||||
|
|
@ -76,11 +82,6 @@ $ kubectl create secret generic controller-manager \
|
||||||
--from-file=github_app_private_key=${PRIVATE_KEY_FILE_PATH}
|
--from-file=github_app_private_key=${PRIVATE_KEY_FILE_PATH}
|
||||||
```
|
```
|
||||||
|
|
||||||
The permissions required are:
|
|
||||||
- Repository: Administration (read/write)
|
|
||||||
- Repository: Actions (read)
|
|
||||||
- Organization: Self-hosted runners (read/write)
|
|
||||||
|
|
||||||
### Using Personal Access Token
|
### Using Personal Access Token
|
||||||
|
|
||||||
From an account that has `admin` privileges for the repository, create a [personal access token](https://github.com/settings/tokens) with `repo` scope. This token is used to register a self-hosted runner by *actions-runner-controller*.
|
From an account that has `admin` privileges for the repository, create a [personal access token](https://github.com/settings/tokens) with `repo` scope. This token is used to register a self-hosted runner by *actions-runner-controller*.
|
||||||
|
|
@ -432,6 +433,19 @@ spec:
|
||||||
image: YOUR_CUSTOM_DOCKER_IMAGE
|
image: YOUR_CUSTOM_DOCKER_IMAGE
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Common Errors
|
||||||
|
|
||||||
|
### invalid header field value
|
||||||
|
|
||||||
|
```json
|
||||||
|
2020-11-12T22:17:30.693Z ERROR controller-runtime.controller Reconciler error {"controller": "runner", "request": "actions-runner-system/runner-deployment-dk7q8-dk5c9", "error": "failed to create registration token: Post \"https://api.github.com/orgs/$YOUR_ORG_HERE/actions/runners/registration-token\": net/http: invalid header field value \"Bearer $YOUR_TOKEN_HERE\\n\" for key Authorization"}
|
||||||
|
```
|
||||||
|
|
||||||
|
**Solutions**<br />
|
||||||
|
Your base64'ed PAT token has a new line at the end, it needs to be created without a `\n` added
|
||||||
|
* `echo -n $TOKEN | base64`
|
||||||
|
* Create the secret as described in the docs using the shell and documeneted flags
|
||||||
|
|
||||||
# Alternatives
|
# Alternatives
|
||||||
|
|
||||||
The following is a list of alternative solutions that may better fit you depending on your use-case:
|
The following is a list of alternative solutions that may better fit you depending on your use-case:
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue