public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix tests

This commit is contained in:
Nikola Jokic 2026-05-20 18:40:29 +02:00
parent 9726ceddea
commit 8a91dff8ef
No known key found for this signature in database
GPG Key ID: 419BB425B0E501B0
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
controllers/actions.github.com/autoscalingrunnerset_controller_test.go
View File

@ -309,7 +309,6 @@ var _ = Describe("Test AutoScalingRunnerSet controller", Ordered, func() {
}) })
It("should not churn listener when already referencing latest ERS (no-op stability)", func() { It("should not churn listener when already referencing latest ERS (no-op stability)", func() {
// Setup: Create AutoScalingRunnerSet
min := 1 min := 1
max := 10 max := 10
testARSName := "test-asrs-no-churn" testARSName := "test-asrs-no-churn"
@ -345,7 +344,6 @@ var _ = Describe("Test AutoScalingRunnerSet controller", Ordered, func() {
err := k8sClient.Create(ctx, testARS) err := k8sClient.Create(ctx, testARS)
Expect(err).NotTo(HaveOccurred(), "failed to create test AutoScalingRunnerSet") Expect(err).NotTo(HaveOccurred(), "failed to create test AutoScalingRunnerSet")
// STEP 1: Wait for ERS creation
var latestERSName string var latestERSName string
Eventually( Eventually(
func() (string, error) { func() (string, error) {
@ -393,7 +391,6 @@ var _ = Describe("Test AutoScalingRunnerSet controller", Ordered, func() {
Expect(len(ownedByTestARS)).To(Equal(1), "should have exactly 1 EphemeralRunnerSet owned by test ARS") Expect(len(ownedByTestARS)).To(Equal(1), "should have exactly 1 EphemeralRunnerSet owned by test ARS")
latestERSName = ownedByTestARS[0].Name latestERSName = ownedByTestARS[0].Name
// STEP 2: Wait for listener creation and capture identity
listener := new(v1alpha1.AutoscalingListener) listener := new(v1alpha1.AutoscalingListener)
Eventually( Eventually(
func() (string, error) { func() (string, error) {
@ -413,8 +410,6 @@ var _ = Describe("Test AutoScalingRunnerSet controller", Ordered, func() {
originalUID := listener.UID originalUID := listener.UID
originalResourceVersion := listener.ResourceVersion originalResourceVersion := listener.ResourceVersion
// STEP 3: Verify listener identity remains stable over polling window
// Use Consistently to assert no churn (listener not deleted/recreated)
Consistently( Consistently(
func() (types.UID, error) { func() (types.UID, error) {
currentListener := new(v1alpha1.AutoscalingListener) currentListener := new(v1alpha1.AutoscalingListener)
@ -441,7 +436,6 @@ var _ = Describe("Test AutoScalingRunnerSet controller", Ordered, func() {
autoscalingRunnerSetTestInterval, autoscalingRunnerSetTestInterval,
).Should(Equal(originalResourceVersion), "listener ResourceVersion should remain unchanged (no updates)") ).Should(Equal(originalResourceVersion), "listener ResourceVersion should remain unchanged (no updates)")
// STEP 4: Verify listener still references correct ERS
err = k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(testARS), Namespace: testARSNamespace}, listener) err = k8sClient.Get(ctx, client.ObjectKey{Name: scaleSetListenerName(testARS), Namespace: testARSNamespace}, listener)
Expect(err).NotTo(HaveOccurred(), "failed to get listener") Expect(err).NotTo(HaveOccurred(), "failed to get listener")
Expect(listener.Spec.EphemeralRunnerSetName).To(Equal(latestERSName), "listener should still reference latest ERS") Expect(listener.Spec.EphemeralRunnerSetName).To(Equal(latestERSName), "listener should still reference latest ERS")