From 828d51baf226d31e2b6c97c9d50529b450e39e01 Mon Sep 17 00:00:00 2001 From: Cristian Calin <6627509+cristicalin@users.noreply.github.com> Date: Thu, 3 Nov 2022 15:48:39 +0200 Subject: [PATCH] admissionWebHooks: fix checking for caBundle (#1968) --- charts/actions-runner-controller/templates/webhook_configs.yaml | 2 +- docs/detailed-docs.md | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/charts/actions-runner-controller/templates/webhook_configs.yaml b/charts/actions-runner-controller/templates/webhook_configs.yaml index ec8194d7..2b984b3c 100644 --- a/charts/actions-runner-controller/templates/webhook_configs.yaml +++ b/charts/actions-runner-controller/templates/webhook_configs.yaml @@ -237,7 +237,7 @@ webhooks: resources: - runnerreplicasets sideEffects: None -{{ if not (or .Values.admissionWebHooks.caBundle .Values.certManagerEnabled) }} +{{ if not (or (hasKey .Values.admissionWebHooks "caBundle") .Values.certManagerEnabled) }} --- apiVersion: v1 kind: Secret diff --git a/docs/detailed-docs.md b/docs/detailed-docs.md index d91753b9..2ae0d8db 100644 --- a/docs/detailed-docs.md +++ b/docs/detailed-docs.md @@ -1683,7 +1683,6 @@ $ helm --upgrade install actions-runner-controller/actions-runner-controller \ Set the Helm chart values as follows: ```shell -$ CA_BUNDLE=$(cat path/to/ca.pem | base64) $ helm --upgrade install actions-runner-controller/actions-runner-controller \ certManagerEnabled=false ```