From 6f51f560baa1ab038db1bf5089b522d5372de42c Mon Sep 17 00:00:00 2001 From: apr-1985 Date: Tue, 14 Dec 2021 04:15:12 +0000 Subject: [PATCH] fix: allow GH priv key from env in helm chart (#884) Co-authored-by: Yusuke Kuoka --- charts/actions-runner-controller/templates/deployment.yaml | 6 +++++- charts/actions-runner-controller/values.yaml | 6 ++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/charts/actions-runner-controller/templates/deployment.yaml b/charts/actions-runner-controller/templates/deployment.yaml index 1197550f..3381353a 100644 --- a/charts/actions-runner-controller/templates/deployment.yaml +++ b/charts/actions-runner-controller/templates/deployment.yaml @@ -85,7 +85,11 @@ spec: name: {{ include "actions-runner-controller.secretName" . }} optional: true - name: GITHUB_APP_PRIVATE_KEY - value: /etc/actions-runner-controller/github_app_private_key + valueFrom: + secretKeyRef: + key: github_app_private_key + name: {{ include "actions-runner-controller.secretName" . }} + optional: true {{- end }} {{- range $key, $val := .Values.env }} - name: {{ $key }} diff --git a/charts/actions-runner-controller/values.yaml b/charts/actions-runner-controller/values.yaml index 1b790187..1a1a6724 100644 --- a/charts/actions-runner-controller/values.yaml +++ b/charts/actions-runner-controller/values.yaml @@ -23,6 +23,12 @@ enableLeaderElection: true # Only 1 authentication method can be deployed at a time # Uncomment the configuration you are applying and fill in the details +# +# If authSecret.enabled=true these values are inherited to actions-runner-controller's controller-manager container's env. +# +# Do set authSecret.enabled=false and set env if you want full control over +# the GitHub authn related envvars of the container. +# See https://github.com/actions-runner-controller/actions-runner-controller/pull/937 for more details. authSecret: enabled: true create: false