public_git/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git synced 2026-10-22 06:28:45 +02:00
Code Issues Projects Releases Wiki Activity

Set per-controller reconcile concurrency defaults and remove --default-max-concurrent-reconciles (#4670)

Browse Source
This commit is contained in:
Nikola Jokic
2026-09-21 11:32:52 +02:00
committed by GitHub
parent c2104a0b72
commit 68e4cfeea5
9 changed files with 166 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files
charts/gha-runner-scale-set-controller-experimental/tests/controller_deployment_args_test.yaml
+14 -19
View File
@@ -74,33 +74,31 @@ tests:
path: spec.template.spec.containers[0].args
content: "--listener-metrics-endpoint=/metrics"
- it: should omit every max-concurrent-reconciles flag by default
- it: should render every max-concurrent-reconciles flag by default
release:
name: "test-arc"
namespace: "test-ns"
asserts:
- notContains:
# An exact match, so this pins both the values and the render order.
- equal:
path: spec.template.spec.containers[0].args
content: "--ephemeral-runner-max-concurrent-reconciles=1"
- notContains:
path: spec.template.spec.containers[0].args
content: "--default-max-concurrent-reconciles=1"
- notContains:
path: spec.template.spec.containers[0].args
content: "--autoscaling-runner-set-max-concurrent-reconciles=1"
- notContains:
path: spec.template.spec.containers[0].args
content: "--autoscaling-listener-max-concurrent-reconciles=1"
- notContains:
path: spec.template.spec.containers[0].args
content: "--ephemeral-runner-set-max-concurrent-reconciles=1"
value:
- "--auto-scaling-runner-set-only"
- "--log-level=debug"
- "--log-format=text"
- "--autoscaling-runner-set-max-concurrent-reconciles=2"
- "--autoscaling-listener-max-concurrent-reconciles=2"
- "--ephemeral-runner-set-max-concurrent-reconciles=2"
- "--ephemeral-runner-max-concurrent-reconciles=4"
- "--listener-metrics-addr=0"
- "--listener-metrics-endpoint="
- "--metrics-addr=0"
- it: should include every max-concurrent-reconciles flag when configured
set:
controller:
manager:
config:
defaultMaxConcurrentReconciles: 4
autoscalingRunnerSetMaxConcurrentReconciles: 3
autoscalingListenerMaxConcurrentReconciles: 5
ephemeralRunnerSetMaxConcurrentReconciles: 6
@@ -109,9 +107,6 @@ tests:
name: "test-arc"
namespace: "test-ns"
asserts:
- contains:
path: spec.template.spec.containers[0].args
content: "--default-max-concurrent-reconciles=4"
- contains:
path: spec.template.spec.containers[0].args
content: "--autoscaling-runner-set-max-concurrent-reconciles=3"