From d44cc390968273d7f190f0a63177295971250964 Mon Sep 17 00:00:00 2001 From: Markus Blaschke Date: Mon, 15 Jan 2024 13:38:46 +0100 Subject: [PATCH 1/4] Update deployment.yaml --- .../templates/deployment.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/charts/actions-runner-controller/templates/deployment.yaml b/charts/actions-runner-controller/templates/deployment.yaml index 3490f989..9fb64930 100644 --- a/charts/actions-runner-controller/templates/deployment.yaml +++ b/charts/actions-runner-controller/templates/deployment.yaml @@ -148,6 +148,15 @@ spec: {{- toYaml .Values.resources | nindent 12 }} securityContext: {{- toYaml .Values.securityContext | nindent 12 }} + {{- if .Values.startupProbe }} + startupProbe: {{ .Values.startupProbe }} + {{- end }} + {{- if .Values.livenessProbe }} + livenessProbe: {{ .Values.livenessProbe }} + {{- end }} + {{- if .Values.readinessProbe }} + readinessProbe: {{ .Values.readinessProbe }} + {{- end }} volumeMounts: {{- if .Values.authSecret.enabled }} - mountPath: "/etc/actions-runner-controller" @@ -180,6 +189,9 @@ spec: {{- toYaml .Values.securityContext | nindent 12 }} {{- end }} terminationGracePeriodSeconds: 10 + {{- if .Values.minReadySeconds }} + minReadySeconds: {{ .Values.minReadySeconds }} + {{- end }} volumes: {{- if .Values.authSecret.enabled }} - name: secret From 73b5b6ce7062978bfa75149a2e790b56a03d2c05 Mon Sep 17 00:00:00 2001 From: Markus Blaschke Date: Mon, 15 Jan 2024 13:40:29 +0100 Subject: [PATCH 2/4] Update values.yaml --- charts/actions-runner-controller/values.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/charts/actions-runner-controller/values.yaml b/charts/actions-runner-controller/values.yaml index 25da1515..33efd81c 100644 --- a/charts/actions-runner-controller/values.yaml +++ b/charts/actions-runner-controller/values.yaml @@ -141,6 +141,13 @@ tolerations: [] affinity: {} +minReadySeconds: 10 + +# Probes +startupProbe: {} +livenessProbe: {} +readinessProbe: {} + # Only one of minAvailable or maxUnavailable can be set podDisruptionBudget: enabled: false From ba3a4dfd930fe58fd82f596a853c20240052606f Mon Sep 17 00:00:00 2001 From: Markus Blaschke Date: Tue, 23 Jan 2024 12:25:27 +0100 Subject: [PATCH 3/4] fix wrong yaml --- charts/actions-runner-controller/templates/deployment.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/actions-runner-controller/templates/deployment.yaml b/charts/actions-runner-controller/templates/deployment.yaml index 9fb64930..a742faa3 100644 --- a/charts/actions-runner-controller/templates/deployment.yaml +++ b/charts/actions-runner-controller/templates/deployment.yaml @@ -149,13 +149,13 @@ spec: securityContext: {{- toYaml .Values.securityContext | nindent 12 }} {{- if .Values.startupProbe }} - startupProbe: {{ .Values.startupProbe }} + startupProbe: {{ toYaml .Values.startupProbe | nindent 12 }} {{- end }} {{- if .Values.livenessProbe }} - livenessProbe: {{ .Values.livenessProbe }} + livenessProbe: {{ toYaml .Values.livenessProbe | nindent 12 }} {{- end }} {{- if .Values.readinessProbe }} - readinessProbe: {{ .Values.readinessProbe }} + readinessProbe: {{ toYaml .Values.readinessProbe | nindent 12 }} {{- end }} volumeMounts: {{- if .Values.authSecret.enabled }} From c302fe79901bb2243e60ae213be803f0b4471d48 Mon Sep 17 00:00:00 2001 From: Markus Blaschke Date: Tue, 5 Mar 2024 17:36:30 +0100 Subject: [PATCH 4/4] fix minReadySeconds --- charts/actions-runner-controller/templates/deployment.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/actions-runner-controller/templates/deployment.yaml b/charts/actions-runner-controller/templates/deployment.yaml index a742faa3..84f72ef7 100644 --- a/charts/actions-runner-controller/templates/deployment.yaml +++ b/charts/actions-runner-controller/templates/deployment.yaml @@ -10,6 +10,9 @@ spec: selector: matchLabels: {{- include "actions-runner-controller.selectorLabels" . | nindent 6 }} + {{- with .Values.minReadySeconds }} + minReadySeconds: {{ . }} + {{- end }} template: metadata: {{- with .Values.podAnnotations }} @@ -189,9 +192,6 @@ spec: {{- toYaml .Values.securityContext | nindent 12 }} {{- end }} terminationGracePeriodSeconds: 10 - {{- if .Values.minReadySeconds }} - minReadySeconds: {{ .Values.minReadySeconds }} - {{- end }} volumes: {{- if .Values.authSecret.enabled }} - name: secret