Update Metric Types and typos (#1719)
* Update valid options in metrics types * FIX: Typos * FIX: Update metric types in helm chart
This commit is contained in:
		
							parent
							
								
									72ca998266
								
							
						
					
					
						commit
						538e2783d7
					
				|  | @ -133,7 +133,7 @@ type ScaleTargetRef struct { | ||||||
| 
 | 
 | ||||||
| type MetricSpec struct { | type MetricSpec struct { | ||||||
| 	// Type is the type of metric to be used for autoscaling.
 | 	// Type is the type of metric to be used for autoscaling.
 | ||||||
| 	// The only supported Type is TotalNumberOfQueuedAndInProgressWorkflowRuns
 | 	// It can be TotalNumberOfQueuedAndInProgressWorkflowRuns or PercentageRunnersBusy.
 | ||||||
| 	Type string `json:"type,omitempty"` | 	Type string `json:"type,omitempty"` | ||||||
| 
 | 
 | ||||||
| 	// RepositoryNames is the list of repository names to be used for calculating the metric.
 | 	// RepositoryNames is the list of repository names to be used for calculating the metric.
 | ||||||
|  | @ -173,7 +173,7 @@ type MetricSpec struct { | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
| // ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule.
 | // ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule.
 | ||||||
| // A schedule can optionally be recurring, so that the correspoding override happens every day, week, month, or year.
 | // A schedule can optionally be recurring, so that the corresponding override happens every day, week, month, or year.
 | ||||||
| type ScheduledOverride struct { | type ScheduledOverride struct { | ||||||
| 	// StartTime is the time at which the first override starts.
 | 	// StartTime is the time at which the first override starts.
 | ||||||
| 	StartTime metav1.Time `json:"startTime"` | 	StartTime metav1.Time `json:"startTime"` | ||||||
|  |  | ||||||
|  | @ -33,7 +33,7 @@ type RunnerDeploymentSpec struct { | ||||||
| 
 | 
 | ||||||
| 	// EffectiveTime is the time the upstream controller requested to sync Replicas.
 | 	// EffectiveTime is the time the upstream controller requested to sync Replicas.
 | ||||||
| 	// It is usually populated by the webhook-based autoscaler via HRA.
 | 	// It is usually populated by the webhook-based autoscaler via HRA.
 | ||||||
| 	// The value is inherited to RunnerRepicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated.
 | 	// The value is inherited to RunnerReplicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated.
 | ||||||
| 	//
 | 	//
 | ||||||
| 	// +optional
 | 	// +optional
 | ||||||
| 	// +nullable
 | 	// +nullable
 | ||||||
|  |  | ||||||
|  | @ -102,7 +102,7 @@ spec: | ||||||
|                         description: ScaleUpThreshold is the percentage of busy runners greater than which will trigger the hpa to scale runners up. |                         description: ScaleUpThreshold is the percentage of busy runners greater than which will trigger the hpa to scale runners up. | ||||||
|                         type: string |                         type: string | ||||||
|                       type: |                       type: | ||||||
|                         description: Type is the type of metric to be used for autoscaling. The only supported Type is TotalNumberOfQueuedAndInProgressWorkflowRuns |                         description: Type is the type of metric to be used for autoscaling. It can be TotalNumberOfQueuedAndInProgressWorkflowRuns or PercentageRunnersBusy. | ||||||
|                         type: string |                         type: string | ||||||
|                     type: object |                     type: object | ||||||
|                   type: array |                   type: array | ||||||
|  | @ -180,7 +180,7 @@ spec: | ||||||
|                 scheduledOverrides: |                 scheduledOverrides: | ||||||
|                   description: ScheduledOverrides is the list of ScheduledOverride. It can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. The earlier a scheduled override is, the higher it is prioritized. |                   description: ScheduledOverrides is the list of ScheduledOverride. It can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. The earlier a scheduled override is, the higher it is prioritized. | ||||||
|                   items: |                   items: | ||||||
|                     description: ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. A schedule can optionally be recurring, so that the correspoding override happens every day, week, month, or year. |                     description: ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. A schedule can optionally be recurring, so that the corresponding override happens every day, week, month, or year. | ||||||
|                     properties: |                     properties: | ||||||
|                       endTime: |                       endTime: | ||||||
|                         description: EndTime is the time at which the first override ends. |                         description: EndTime is the time at which the first override ends. | ||||||
|  |  | ||||||
|  | @ -49,7 +49,7 @@ spec: | ||||||
|               description: RunnerDeploymentSpec defines the desired state of RunnerDeployment |               description: RunnerDeploymentSpec defines the desired state of RunnerDeployment | ||||||
|               properties: |               properties: | ||||||
|                 effectiveTime: |                 effectiveTime: | ||||||
|                   description: EffectiveTime is the time the upstream controller requested to sync Replicas. It is usually populated by the webhook-based autoscaler via HRA. The value is inherited to RunnerRepicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated. |                   description: EffectiveTime is the time the upstream controller requested to sync Replicas. It is usually populated by the webhook-based autoscaler via HRA. The value is inherited to RunnerReplicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated. | ||||||
|                   format: date-time |                   format: date-time | ||||||
|                   nullable: true |                   nullable: true | ||||||
|                   type: string |                   type: string | ||||||
|  |  | ||||||
|  | @ -102,7 +102,7 @@ spec: | ||||||
|                         description: ScaleUpThreshold is the percentage of busy runners greater than which will trigger the hpa to scale runners up. |                         description: ScaleUpThreshold is the percentage of busy runners greater than which will trigger the hpa to scale runners up. | ||||||
|                         type: string |                         type: string | ||||||
|                       type: |                       type: | ||||||
|                         description: Type is the type of metric to be used for autoscaling. The only supported Type is TotalNumberOfQueuedAndInProgressWorkflowRuns |                         description: Type is the type of metric to be used for autoscaling. It can be TotalNumberOfQueuedAndInProgressWorkflowRuns or PercentageRunnersBusy. | ||||||
|                         type: string |                         type: string | ||||||
|                     type: object |                     type: object | ||||||
|                   type: array |                   type: array | ||||||
|  | @ -180,7 +180,7 @@ spec: | ||||||
|                 scheduledOverrides: |                 scheduledOverrides: | ||||||
|                   description: ScheduledOverrides is the list of ScheduledOverride. It can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. The earlier a scheduled override is, the higher it is prioritized. |                   description: ScheduledOverrides is the list of ScheduledOverride. It can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. The earlier a scheduled override is, the higher it is prioritized. | ||||||
|                   items: |                   items: | ||||||
|                     description: ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. A schedule can optionally be recurring, so that the correspoding override happens every day, week, month, or year. |                     description: ScheduledOverride can be used to override a few fields of HorizontalRunnerAutoscalerSpec on schedule. A schedule can optionally be recurring, so that the corresponding override happens every day, week, month, or year. | ||||||
|                     properties: |                     properties: | ||||||
|                       endTime: |                       endTime: | ||||||
|                         description: EndTime is the time at which the first override ends. |                         description: EndTime is the time at which the first override ends. | ||||||
|  |  | ||||||
|  | @ -49,7 +49,7 @@ spec: | ||||||
|               description: RunnerDeploymentSpec defines the desired state of RunnerDeployment |               description: RunnerDeploymentSpec defines the desired state of RunnerDeployment | ||||||
|               properties: |               properties: | ||||||
|                 effectiveTime: |                 effectiveTime: | ||||||
|                   description: EffectiveTime is the time the upstream controller requested to sync Replicas. It is usually populated by the webhook-based autoscaler via HRA. The value is inherited to RunnerRepicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated. |                   description: EffectiveTime is the time the upstream controller requested to sync Replicas. It is usually populated by the webhook-based autoscaler via HRA. The value is inherited to RunnerReplicaSet(s) and used to prevent ephemeral runners from unnecessarily recreated. | ||||||
|                   format: date-time |                   format: date-time | ||||||
|                   nullable: true |                   nullable: true | ||||||
|                   type: string |                   type: string | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue