From 4eb038eaa1ec2cfed9f00e5fdd343ebc06090b81 Mon Sep 17 00:00:00 2001 From: Nikola Jokic Date: Fri, 21 Jun 2024 12:11:29 +0200 Subject: [PATCH] Bump node actions (#3569) --- .../execute-assert-arc-e2e/action.yaml | 6 ++--- .github/actions/setup-arc-e2e/action.yaml | 6 ++--- .../setup-docker-environment/action.yaml | 8 +++---- .github/workflows/arc-publish-chart.yaml | 12 +++++----- .github/workflows/arc-publish.yaml | 6 ++--- .github/workflows/arc-release-runners.yaml | 4 ++-- .../arc-update-runners-scheduled.yaml | 6 ++--- .github/workflows/arc-validate-chart.yaml | 8 +++---- .github/workflows/arc-validate-runners.yaml | 4 ++-- .github/workflows/gha-e2e-tests.yaml | 18 +++++++-------- .github/workflows/gha-publish-chart.yaml | 22 +++++++++---------- .github/workflows/gha-validate-chart.yaml | 12 +++++----- .github/workflows/global-publish-canary.yaml | 14 ++++++------ .github/workflows/global-run-codeql.yaml | 4 ++-- .../global-run-first-interaction.yaml | 2 +- .github/workflows/go.yaml | 18 +++++++-------- docs/adrs/2023-03-17-workflow-improvements.md | 2 +- testing/workflow.go | 2 +- 18 files changed, 77 insertions(+), 77 deletions(-) diff --git a/.github/actions/execute-assert-arc-e2e/action.yaml b/.github/actions/execute-assert-arc-e2e/action.yaml index 90a18bc0..6aac8268 100644 --- a/.github/actions/execute-assert-arc-e2e/action.yaml +++ b/.github/actions/execute-assert-arc-e2e/action.yaml @@ -47,7 +47,7 @@ runs: -d '{"ref": "main", "inputs": { "arc_name": "${{inputs.arc-name}}" } }' - name: Fetch workflow run & job ids - uses: actions/github-script@v6 + uses: actions/github-script@v7 id: query_workflow with: script: | @@ -128,7 +128,7 @@ runs: - name: Wait for workflow to start running if: inputs.wait-to-running == 'true' && inputs.wait-to-finish == 'false' - uses: actions/github-script@v6 + uses: actions/github-script@v7 with: script: | function sleep(ms) { @@ -156,7 +156,7 @@ runs: - name: Wait for workflow to finish successfully if: inputs.wait-to-finish == 'true' - uses: actions/github-script@v6 + uses: actions/github-script@v7 with: script: | // Wait 5 minutes and make sure the workflow run we triggered completed with result 'success' diff --git a/.github/actions/setup-arc-e2e/action.yaml b/.github/actions/setup-arc-e2e/action.yaml index b0dcb06d..0cccd465 100644 --- a/.github/actions/setup-arc-e2e/action.yaml +++ b/.github/actions/setup-arc-e2e/action.yaml @@ -27,7 +27,7 @@ runs: using: "composite" steps: - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v2 + uses: docker/setup-buildx-action@v3 with: # Pinning v0.9.1 for Buildx and BuildKit v0.10.6 # BuildKit v0.11 which has a bug causing intermittent @@ -36,7 +36,7 @@ runs: driver-opts: image=moby/buildkit:v0.10.6 - name: Build controller image - uses: docker/build-push-action@v3 + uses: docker/build-push-action@v5 with: file: Dockerfile platforms: linux/amd64 @@ -56,7 +56,7 @@ runs: - name: Get configure token id: config-token - uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db + uses: peter-murray/workflow-application-token-action@dc0413987a085fa17d19df9e47d4677cf81ffef3 with: application_id: ${{ inputs.app-id }} application_private_key: ${{ inputs.app-pk }} diff --git a/.github/actions/setup-docker-environment/action.yaml b/.github/actions/setup-docker-environment/action.yaml index 2418fdd4..f083ff07 100644 --- a/.github/actions/setup-docker-environment/action.yaml +++ b/.github/actions/setup-docker-environment/action.yaml @@ -24,23 +24,23 @@ runs: shell: bash - name: Set up QEMU - uses: docker/setup-qemu-action@v2 + uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v2 + uses: docker/setup-buildx-action@v3 with: version: latest - name: Login to DockerHub if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' && inputs.password != '' }} - uses: docker/login-action@v2 + uses: docker/login-action@v3 with: username: ${{ inputs.username }} password: ${{ inputs.password }} - name: Login to GitHub Container Registry if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' && inputs.ghcr_password != '' }} - uses: docker/login-action@v2 + uses: docker/login-action@v3 with: registry: ghcr.io username: ${{ inputs.ghcr_username }} diff --git a/.github/workflows/arc-publish-chart.yaml b/.github/workflows/arc-publish-chart.yaml index 41e5c5b0..1057362f 100644 --- a/.github/workflows/arc-publish-chart.yaml +++ b/.github/workflows/arc-publish-chart.yaml @@ -40,12 +40,12 @@ jobs: publish-chart: ${{ steps.publish-chart-step.outputs.publish }} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up Helm - uses: azure/setup-helm@v3.4 + uses: azure/setup-helm@v4.2 with: version: ${{ env.HELM_VERSION }} @@ -58,7 +58,7 @@ jobs: run: helm template --values charts/.ci/values-kube-score.yaml charts/* | ./kube-score score - --ignore-test pod-networkpolicy --ignore-test deployment-has-poddisruptionbudget --ignore-test deployment-has-host-podantiaffinity --ignore-test container-security-context --ignore-test pod-probes --ignore-test container-image-tag --enable-optional-test container-security-context-privileged --enable-optional-test container-security-context-readonlyrootfilesystem # python is a requirement for the chart-testing action below (supports yamllint among other tests) - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: '3.11' @@ -134,7 +134,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 @@ -145,7 +145,7 @@ jobs: - name: Get Token id: get_workflow_token - uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db + uses: peter-murray/workflow-application-token-action@dc0413987a085fa17d19df9e47d4677cf81ffef3 with: application_id: ${{ secrets.ACTIONS_ACCESS_APP_ID }} application_private_key: ${{ secrets.ACTIONS_ACCESS_PK }} @@ -184,7 +184,7 @@ jobs: # this workaround is intended to move the index.yaml to the target repo # where the github pages are hosted - name: Checkout target repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: ${{ env.CHART_TARGET_ORG }}/${{ env.CHART_TARGET_REPO }} path: ${{ env.CHART_TARGET_REPO }} diff --git a/.github/workflows/arc-publish.yaml b/.github/workflows/arc-publish.yaml index 6a83f2a9..37d67e9f 100644 --- a/.github/workflows/arc-publish.yaml +++ b/.github/workflows/arc-publish.yaml @@ -39,9 +39,9 @@ jobs: if: ${{ !startsWith(github.event.inputs.release_tag_name, 'gha-runner-scale-set-') }} steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' @@ -73,7 +73,7 @@ jobs: - name: Get Token id: get_workflow_token - uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db + uses: peter-murray/workflow-application-token-action@dc0413987a085fa17d19df9e47d4677cf81ffef3 with: application_id: ${{ secrets.ACTIONS_ACCESS_APP_ID }} application_private_key: ${{ secrets.ACTIONS_ACCESS_PK }} diff --git a/.github/workflows/arc-release-runners.yaml b/.github/workflows/arc-release-runners.yaml index 253793ab..55ced306 100644 --- a/.github/workflows/arc-release-runners.yaml +++ b/.github/workflows/arc-release-runners.yaml @@ -28,7 +28,7 @@ jobs: name: Trigger Build and Push of Runner Images runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Get runner version id: versions run: | @@ -39,7 +39,7 @@ jobs: - name: Get Token id: get_workflow_token - uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db + uses: peter-murray/workflow-application-token-action@dc0413987a085fa17d19df9e47d4677cf81ffef3 with: application_id: ${{ secrets.ACTIONS_ACCESS_APP_ID }} application_private_key: ${{ secrets.ACTIONS_ACCESS_PK }} diff --git a/.github/workflows/arc-update-runners-scheduled.yaml b/.github/workflows/arc-update-runners-scheduled.yaml index bce555c4..5c540531 100644 --- a/.github/workflows/arc-update-runners-scheduled.yaml +++ b/.github/workflows/arc-update-runners-scheduled.yaml @@ -21,7 +21,7 @@ jobs: container_hooks_current_version: ${{ steps.container_hooks_versions.outputs.container_hooks_current_version }} container_hooks_latest_version: ${{ steps.container_hooks_versions.outputs.container_hooks_latest_version }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Get runner current and latest versions id: runner_versions @@ -64,7 +64,7 @@ jobs: echo "CONTAINER_HOOKS_CURRENT_VERSION=${{ needs.check_versions.outputs.container_hooks_current_version }}" echo "CONTAINER_HOOKS_LATEST_VERSION=${{ needs.check_versions.outputs.container_hooks_latest_version }}" - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: PR Name id: pr_name @@ -119,7 +119,7 @@ jobs: PR_NAME: ${{ needs.check_pr.outputs.pr_name }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: New branch run: git checkout -b update-runner-"$(date +%Y-%m-%d)" diff --git a/.github/workflows/arc-validate-chart.yaml b/.github/workflows/arc-validate-chart.yaml index dc04eab4..f38a3fc3 100644 --- a/.github/workflows/arc-validate-chart.yaml +++ b/.github/workflows/arc-validate-chart.yaml @@ -40,13 +40,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up Helm - # Using https://github.com/Azure/setup-helm/releases/tag/v3.5 - uses: azure/setup-helm@5119fcb9089d432beecbf79bb2c7915207344b78 + # Using https://github.com/Azure/setup-helm/releases/tag/v4.2 + uses: azure/setup-helm@fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 with: version: ${{ env.HELM_VERSION }} @@ -67,7 +67,7 @@ jobs: --enable-optional-test container-security-context-readonlyrootfilesystem # python is a requirement for the chart-testing action below (supports yamllint among other tests) - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: '3.11' diff --git a/.github/workflows/arc-validate-runners.yaml b/.github/workflows/arc-validate-runners.yaml index 562320f6..9d559c37 100644 --- a/.github/workflows/arc-validate-runners.yaml +++ b/.github/workflows/arc-validate-runners.yaml @@ -24,7 +24,7 @@ jobs: name: runner / shellcheck runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: shellcheck uses: reviewdog/action-shellcheck@v1 with: @@ -45,7 +45,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Run tests run: | diff --git a/.github/workflows/gha-e2e-tests.yaml b/.github/workflows/gha-e2e-tests.yaml index 0e8b244e..5452804b 100644 --- a/.github/workflows/gha-e2e-tests.yaml +++ b/.github/workflows/gha-e2e-tests.yaml @@ -33,7 +33,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -122,7 +122,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -213,7 +213,7 @@ jobs: env: WORKFLOW_FILE: arc-test-dind-workflow.yaml steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -303,7 +303,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-kubernetes-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -402,7 +402,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -503,7 +503,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -598,7 +598,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-workflow.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -718,7 +718,7 @@ jobs: env: WORKFLOW_FILE: "arc-test-sleepy-matrix.yaml" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{github.head_ref}} @@ -888,7 +888,7 @@ jobs: env: WORKFLOW_FILE: arc-test-workflow.yaml steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ github.head_ref }} diff --git a/.github/workflows/gha-publish-chart.yaml b/.github/workflows/gha-publish-chart.yaml index 8d893e02..251af8e8 100644 --- a/.github/workflows/gha-publish-chart.yaml +++ b/.github/workflows/gha-publish-chart.yaml @@ -45,7 +45,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # If inputs.ref is empty, it'll resolve to the default branch ref: ${{ inputs.ref }} @@ -72,10 +72,10 @@ jobs: echo "repository_owner=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT - name: Set up QEMU - uses: docker/setup-qemu-action@v2 + uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v2 + uses: docker/setup-buildx-action@v3 with: # Pinning v0.9.1 for Buildx and BuildKit v0.10.6 # BuildKit v0.11 which has a bug causing intermittent @@ -84,14 +84,14 @@ jobs: driver-opts: image=moby/buildkit:v0.10.6 - name: Login to GitHub Container Registry - uses: docker/login-action@v2 + uses: docker/login-action@v3 with: registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} - name: Build & push controller image - uses: docker/build-push-action@v3 + uses: docker/build-push-action@v5 with: file: Dockerfile platforms: linux/amd64,linux/arm64 @@ -121,7 +121,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # If inputs.ref is empty, it'll resolve to the default branch ref: ${{ inputs.ref }} @@ -140,8 +140,8 @@ jobs: echo "repository_owner=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT - name: Set up Helm - # Using https://github.com/Azure/setup-helm/releases/tag/v3.5 - uses: azure/setup-helm@5119fcb9089d432beecbf79bb2c7915207344b78 + # Using https://github.com/Azure/setup-helm/releases/tag/v4.2 + uses: azure/setup-helm@fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 with: version: ${{ env.HELM_VERSION }} @@ -169,7 +169,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # If inputs.ref is empty, it'll resolve to the default branch ref: ${{ inputs.ref }} @@ -188,8 +188,8 @@ jobs: echo "repository_owner=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT - name: Set up Helm - # Using https://github.com/Azure/setup-helm/releases/tag/v3.5 - uses: azure/setup-helm@5119fcb9089d432beecbf79bb2c7915207344b78 + # Using https://github.com/Azure/setup-helm/releases/tag/v4.2 + uses: azure/setup-helm@fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 with: version: ${{ env.HELM_VERSION }} diff --git a/.github/workflows/gha-validate-chart.yaml b/.github/workflows/gha-validate-chart.yaml index ab6735ec..91304702 100644 --- a/.github/workflows/gha-validate-chart.yaml +++ b/.github/workflows/gha-validate-chart.yaml @@ -36,13 +36,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Set up Helm - # Using https://github.com/Azure/setup-helm/releases/tag/v3.5 - uses: azure/setup-helm@5119fcb9089d432beecbf79bb2c7915207344b78 + # Using https://github.com/Azure/setup-helm/releases/tag/v4.2 + uses: azure/setup-helm@fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 with: version: ${{ env.HELM_VERSION }} @@ -63,7 +63,7 @@ jobs: --enable-optional-test container-security-context-readonlyrootfilesystem # python is a requirement for the chart-testing action below (supports yamllint among other tests) - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: '3.11' @@ -84,13 +84,13 @@ jobs: ct lint --config charts/.ci/ct-config-gha.yaml - name: Set up docker buildx - uses: docker/setup-buildx-action@v2 + uses: docker/setup-buildx-action@v3 if: steps.list-changed.outputs.changed == 'true' with: version: latest - name: Build controller image - uses: docker/build-push-action@v3 + uses: docker/build-push-action@v5 if: steps.list-changed.outputs.changed == 'true' with: file: Dockerfile diff --git a/.github/workflows/global-publish-canary.yaml b/.github/workflows/global-publish-canary.yaml index 11a89d5b..ba4796a9 100644 --- a/.github/workflows/global-publish-canary.yaml +++ b/.github/workflows/global-publish-canary.yaml @@ -55,11 +55,11 @@ jobs: TARGET_REPO: actions-runner-controller steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Get Token id: get_workflow_token - uses: peter-murray/workflow-application-token-action@8e1ba3bf1619726336414f1014e37f17fbadf1db + uses: peter-murray/workflow-application-token-action@dc0413987a085fa17d19df9e47d4677cf81ffef3 with: application_id: ${{ secrets.ACTIONS_ACCESS_APP_ID }} application_private_key: ${{ secrets.ACTIONS_ACCESS_PK }} @@ -90,10 +90,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Login to GitHub Container Registry - uses: docker/login-action@v2 + uses: docker/login-action@v3 with: registry: ghcr.io username: ${{ github.actor }} @@ -110,16 +110,16 @@ jobs: echo "repository_owner=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT - name: Set up QEMU - uses: docker/setup-qemu-action@v2 + uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v2 + uses: docker/setup-buildx-action@v3 with: version: latest # Unstable builds - run at your own risk - name: Build and Push - uses: docker/build-push-action@v3 + uses: docker/build-push-action@v5 with: context: . file: ./Dockerfile diff --git a/.github/workflows/global-run-codeql.yaml b/.github/workflows/global-run-codeql.yaml index 1e634b73..99692156 100644 --- a/.github/workflows/global-run-codeql.yaml +++ b/.github/workflows/global-run-codeql.yaml @@ -25,10 +25,10 @@ jobs: security-events: write steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Install Go - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version-file: go.mod diff --git a/.github/workflows/global-run-first-interaction.yaml b/.github/workflows/global-run-first-interaction.yaml index ce1139a5..2cde7a32 100644 --- a/.github/workflows/global-run-first-interaction.yaml +++ b/.github/workflows/global-run-first-interaction.yaml @@ -11,7 +11,7 @@ jobs: check_for_first_interaction: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/first-interaction@main with: repo-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/go.yaml b/.github/workflows/go.yaml index 8f2da6cc..40112c2c 100644 --- a/.github/workflows/go.yaml +++ b/.github/workflows/go.yaml @@ -29,8 +29,8 @@ jobs: fmt: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' cache: false @@ -42,13 +42,13 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' cache: false - name: golangci-lint - uses: golangci/golangci-lint-action@v3 + uses: golangci/golangci-lint-action@v6 with: only-new-issues: true version: v1.55.2 @@ -56,8 +56,8 @@ jobs: generate: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' cache: false @@ -69,8 +69,8 @@ jobs: test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 with: go-version-file: 'go.mod' - run: make manifests diff --git a/docs/adrs/2023-03-17-workflow-improvements.md b/docs/adrs/2023-03-17-workflow-improvements.md index f85bd9b9..d19c77db 100644 --- a/docs/adrs/2023-03-17-workflow-improvements.md +++ b/docs/adrs/2023-03-17-workflow-improvements.md @@ -42,7 +42,7 @@ eliminate some duplication: `-coverprofile` flags: while `-short` is used to skip [old ARC E2E tests](https://github.com/actions/actions-runner-controller/blob/master/test/e2e/e2e_test.go#L85-L87), `-coverprofile` is adding to the test time without really giving us any value - in return. We should also start using `actions/setup-go@v4` to take advantage + in return. We should also start using `actions/setup-go@v5` to take advantage of caching (it would speed up our tests by a lot) or enable it on `v3` if we have a strong reason not to upgrade. We should keep ignoring our E2E tests too as those will be run elsewhere (either use `Short` there too or ignoring the diff --git a/testing/workflow.go b/testing/workflow.go index 34c85d17..0da276d5 100644 --- a/testing/workflow.go +++ b/testing/workflow.go @@ -1,7 +1,7 @@ package testing const ( - ActionsCheckout = "actions/checkout@v3" + ActionsCheckout = "actions/checkout@v4" ) type Workflow struct {