From 3f331e9a3965f38fc98f452571735e0469de8c6d Mon Sep 17 00:00:00 2001 From: Rob Bos Date: Sun, 26 Sep 2021 07:34:55 +0200 Subject: [PATCH] Fixing capitalization and a typo (#838) * Fixing capitalization and a typo * typo * Typo * Update controllers/autoscaling.go * Update controllers/autoscaling.go Co-authored-by: Yusuke Kuoka --- CONTRIBUTING.md | 2 +- controllers/autoscaling.go | 4 ++-- controllers/runner_pod_controller.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4b3dd189..ab454258 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ Depending on what you are patching depends on how you should go about it. Below are some guides on how to test patches locally as well as develop the controller and runners. -When sumitting a PR for a change please provide evidence that your change works as we still need to work on improving the CI of the project. Some resources are provided for helping achieve this, see this guide for details. +When submitting a PR for a change please provide evidence that your change works as we still need to work on improving the CI of the project. Some resources are provided for helping achieve this, see this guide for details. #### Running an End to End Test diff --git a/controllers/autoscaling.go b/controllers/autoscaling.go index 28358ebc..ea9e9c68 100644 --- a/controllers/autoscaling.go +++ b/controllers/autoscaling.go @@ -76,7 +76,7 @@ func (r *HorizontalRunnerAutoscalerReconciler) suggestDesiredReplicas(st scaleTa return nil, nil } else if numMetrics > 2 { - return nil, fmt.Errorf("Too many autoscaling metrics configured: It must be 0 to 2, but got %d", numMetrics) + return nil, fmt.Errorf("too many autoscaling metrics configured: It must be 0 to 2, but got %d", numMetrics) } primaryMetric := metrics[0] @@ -93,7 +93,7 @@ func (r *HorizontalRunnerAutoscalerReconciler) suggestDesiredReplicas(st scaleTa case v1alpha1.AutoscalingMetricTypePercentageRunnersBusy: suggested, err = r.suggestReplicasByPercentageRunnersBusy(st, hra, primaryMetric) default: - return nil, fmt.Errorf("validting autoscaling metrics: unsupported metric type %q", primaryMetric) + return nil, fmt.Errorf("validating autoscaling metrics: unsupported metric type %q", primaryMetric) } if err != nil { diff --git a/controllers/runner_pod_controller.go b/controllers/runner_pod_controller.go index 0489faed..eac7bcef 100644 --- a/controllers/runner_pod_controller.go +++ b/controllers/runner_pod_controller.go @@ -50,7 +50,7 @@ type RunnerPodReconciler struct { } const ( - // This names requires at leaset one slash to work. + // This names requires at least one slash to work. // See https://github.com/google/knative-gcp/issues/378 runnerPodFinalizerName = "actions.summerwind.dev/runner-pod"