From 3f02153257ed975b1a9b7da68edcd1520aca8b41 Mon Sep 17 00:00:00 2001 From: Moto Ishizawa Date: Fri, 31 Jan 2020 22:47:53 +0900 Subject: [PATCH] Ignore pods being deleted --- controllers/runner_controller.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/controllers/runner_controller.go b/controllers/runner_controller.go index f7ae154d..13630976 100644 --- a/controllers/runner_controller.go +++ b/controllers/runner_controller.go @@ -103,6 +103,10 @@ func (r *RunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { log.Info("Created a runner pod", "repository", runner.Spec.Repository) } else { + if !pod.ObjectMeta.DeletionTimestamp.IsZero() { + return ctrl.Result{}, err + } + newPod, err := r.newPod(runner) if err != nil { log.Error(err, "could not create pod") @@ -120,7 +124,7 @@ func (r *RunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { return ctrl.Result{}, err } - if err := r.Delete(ctx, &pod, client.PropagationPolicy(metav1.DeletePropagationBackground)); err != nil { + if err := r.Delete(ctx, &pod); err != nil { log.Error(err, "failed to delete pod resource") return ctrl.Result{}, err }