From 1b98c8f811e03e5d4867b3673f5633bd559fa065 Mon Sep 17 00:00:00 2001 From: Callum Tait Date: Sat, 14 Nov 2020 11:19:16 +0000 Subject: [PATCH 1/3] refactor: adding explicit sync-period flag --- config/default/manager_auth_proxy_patch.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/config/default/manager_auth_proxy_patch.yaml b/config/default/manager_auth_proxy_patch.yaml index 61cb5e7c..a98595ef 100644 --- a/config/default/manager_auth_proxy_patch.yaml +++ b/config/default/manager_auth_proxy_patch.yaml @@ -23,3 +23,4 @@ spec: args: - "--metrics-addr=127.0.0.1:8080" - "--enable-leader-election" + - "--sync-period=10m" From 04dde518f0a890e7297dbea434f873143d03f38b Mon Sep 17 00:00:00 2001 From: Callum Tait Date: Sat, 14 Nov 2020 11:22:09 +0000 Subject: [PATCH 2/3] docs: adding mroe detail for sync period config --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fbcb9ffc..160fa95e 100644 --- a/README.md +++ b/README.md @@ -235,7 +235,7 @@ spec: - summerwind/actions-runner-controller ``` -Please also note that the sync period is set to 10 minutes by default and it's configurable via `--sync-period` flag. +The scale out performance is controlled via the manager containers startup `--sync-period` argument. The default value is 10 minutes to prevent unconfigured deployements rate limiting themselves from the GitHub API. The period can be customised in the `config/default/manager_auth_proxy_patch.yaml` patch for those that are building the solution via the kustomize setup. Additionally, the autoscaling feature has an anti-flapping option that prevents periodic loop of scaling up and down. By default, it doesn't scale down until the grace period of 10 minutes passes after a scale up. The grace period can be configured by setting `scaleDownDelaySecondsAfterScaleUp`: From c623ce07657621b005a90bcebe5d53e31d8c2d13 Mon Sep 17 00:00:00 2001 From: Callum Tait Date: Sat, 14 Nov 2020 12:32:14 +0000 Subject: [PATCH 3/3] =?UTF-8?q?docs:=20spelling=20=F0=9F=99=83?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 160fa95e..937b7647 100644 --- a/README.md +++ b/README.md @@ -235,7 +235,7 @@ spec: - summerwind/actions-runner-controller ``` -The scale out performance is controlled via the manager containers startup `--sync-period` argument. The default value is 10 minutes to prevent unconfigured deployements rate limiting themselves from the GitHub API. The period can be customised in the `config/default/manager_auth_proxy_patch.yaml` patch for those that are building the solution via the kustomize setup. +The scale out performance is controlled via the manager containers startup `--sync-period` argument. The default value is 10 minutes to prevent unconfigured deployments rate limiting themselves from the GitHub API. The period can be customised in the `config/default/manager_auth_proxy_patch.yaml` patch for those that are building the solution via the kustomize setup. Additionally, the autoscaling feature has an anti-flapping option that prevents periodic loop of scaling up and down. By default, it doesn't scale down until the grace period of 10 minutes passes after a scale up. The grace period can be configured by setting `scaleDownDelaySecondsAfterScaleUp`: