chore: adding Helm app version back (#412)
* chore: adding Helm app version back * chore: removing redundant values entry * chore: bumping to newer version * chore: bumping app version to latest Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
This commit is contained in:
		
							parent
							
								
									37c2a62fa8
								
							
						
					
					
						commit
						3b2d2c052e
					
				|  | @ -0,0 +1,8 @@ | ||||||
|  | # Contributing | ||||||
|  | 
 | ||||||
|  | ### Helm Verison Bumps | ||||||
|  | 
 | ||||||
|  | **Chart Version :** When bumping the chart version follow semantic versioning https://semver.org/<br /> | ||||||
|  | **App Version :** When bumping the app version you will also need to bump the chart verison too. Again, follow semantic verisoning when bumping the chart. | ||||||
|  | 
 | ||||||
|  | To determine if you need tp bump the MAJOR, MINOR or PATCH versions you will need to review the changes between the previous app version and the new app verison and / or ask for a maintainer to advise. | ||||||
|  | @ -25,7 +25,7 @@ ToC: | ||||||
|   - [Using EKS IAM role for service accounts](#using-eks-iam-role-for-service-accounts) |   - [Using EKS IAM role for service accounts](#using-eks-iam-role-for-service-accounts) | ||||||
|   - [Software installed in the runner image](#software-installed-in-the-runner-image) |   - [Software installed in the runner image](#software-installed-in-the-runner-image) | ||||||
|   - [Common errors](#common-errors) |   - [Common errors](#common-errors) | ||||||
| - [Developing](#developing) | - [Contributing](#contributing) | ||||||
| 
 | 
 | ||||||
| ## Motivation | ## Motivation | ||||||
| 
 | 
 | ||||||
|  | @ -748,7 +748,9 @@ Your base64'ed PAT token has a new line at the end, it needs to be created witho | ||||||
| * `echo -n $TOKEN | base64` | * `echo -n $TOKEN | base64` | ||||||
| * Create the secret as described in the docs using the shell and documeneted flags | * Create the secret as described in the docs using the shell and documeneted flags | ||||||
| 
 | 
 | ||||||
| # Developing | # Contributing | ||||||
|  | 
 | ||||||
|  | For more details about any requirements or process, please check out [Getting Started with Contributing](CONTRIBUTING.md). | ||||||
| 
 | 
 | ||||||
| **The Controller**<br /> | **The Controller**<br /> | ||||||
| If you'd like to modify the controller to fork or contribute, I'd suggest using the following snippet for running | If you'd like to modify the controller to fork or contribute, I'd suggest using the following snippet for running | ||||||
|  |  | ||||||
|  | @ -15,7 +15,10 @@ type: application | ||||||
| # This is the chart version. This version number should be incremented each time you make changes | # This is the chart version. This version number should be incremented each time you make changes | ||||||
| # to the chart and its templates, including the app version. | # to the chart and its templates, including the app version. | ||||||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||||||
| version: 0.10.5 | version: 0.11.0 | ||||||
|  | 
 | ||||||
|  | # Used as the default manager tag value when no tag property is provided in the values.yaml | ||||||
|  | appVersion: 0.18.2 | ||||||
| 
 | 
 | ||||||
| home: https://github.com/summerwind/actions-runner-controller | home: https://github.com/summerwind/actions-runner-controller | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -65,7 +65,7 @@ spec: | ||||||
|         - name: {{ $key }} |         - name: {{ $key }} | ||||||
|           value: {{ $val | quote }} |           value: {{ $val | quote }} | ||||||
|         {{- end }} |         {{- end }} | ||||||
|         image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" |         image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default (cat "v" .Chart.AppVersion | replace " " "") }}" | ||||||
|         name: manager |         name: manager | ||||||
|         imagePullPolicy: {{ .Values.image.pullPolicy }} |         imagePullPolicy: {{ .Values.image.pullPolicy }} | ||||||
|         ports: |         ports: | ||||||
|  |  | ||||||
|  | @ -47,7 +47,7 @@ spec: | ||||||
|         - name: {{ $key }} |         - name: {{ $key }} | ||||||
|           value: {{ $val | quote }} |           value: {{ $val | quote }} | ||||||
|         {{- end }} |         {{- end }} | ||||||
|         image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" |         image: "{{ .Values.image.repository }}:{{ .Values.image.tag  | default (cat "v" .Chart.AppVersion | replace " " "") }}" | ||||||
|         name: github-webhook-server |         name: github-webhook-server | ||||||
|         imagePullPolicy: {{ .Values.image.pullPolicy }} |         imagePullPolicy: {{ .Values.image.pullPolicy }} | ||||||
|         ports: |         ports: | ||||||
|  |  | ||||||
|  | @ -22,7 +22,6 @@ authSecret: | ||||||
| 
 | 
 | ||||||
| image: | image: | ||||||
|   repository: summerwind/actions-runner-controller |   repository: summerwind/actions-runner-controller | ||||||
|   tag: "v0.17.0" |  | ||||||
|   dindSidecarRepositoryAndTag: "docker:dind" |   dindSidecarRepositoryAndTag: "docker:dind" | ||||||
|   pullPolicy: IfNotPresent |   pullPolicy: IfNotPresent | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue