From 3ae9f09532a4cc06f55497997117f9e16a27f750 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Sun, 27 Nov 2022 11:13:56 +0900 Subject: [PATCH] e2e: Do honor the runner graceful stop timeout also in the dockerd sidecar prestop hook (#2044) The runner graceful stop timeout has never been propagated to the dind sidecar due to configuration error in E2E. This fixes it, so that we can verify that the dind sidecar prestop can respect the graceful stop timeout. Related to #1759 --- acceptance/testdata/runnerdeploy.envsubst.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acceptance/testdata/runnerdeploy.envsubst.yaml b/acceptance/testdata/runnerdeploy.envsubst.yaml index 17ce69e6..8de7ff48 100644 --- a/acceptance/testdata/runnerdeploy.envsubst.yaml +++ b/acceptance/testdata/runnerdeploy.envsubst.yaml @@ -78,6 +78,9 @@ spec: value: "3" dockerMTU: 1400 + dockerEnv: + - name: RUNNER_GRACEFUL_STOP_TIMEOUT + value: "${RUNNER_GRACEFUL_STOP_TIMEOUT}" # Fix the following no space left errors with rootless-dind runners that can happen while running buildx build: # ------