public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

logging: improve logs for scaling

This commit is contained in:
Felipe Galindo Sanchez 2022-02-23 08:29:13 -08:00
parent 7156ce040e
commit 3abecd0f19
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
controllers/horizontal_runner_autoscaler_webhook.go
View File

@ -351,9 +351,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) findHRAsByKey(ctx con
return nil, err return nil, err
} }
for _, d := range hraList.Items { hras = append(hras, hraList.Items...)
hras = append(hras, d)
}
} }
return hras, nil return hras, nil
@ -791,7 +789,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) tryScale(ctx context.
} }
autoscaler.Log.Info( autoscaler.Log.Info(
"Patching hra for capacityReservations update", fmt.Sprintf("Patching hra %s for capacityReservations update", target.HorizontalRunnerAutoscaler.Name),
"before", target.HorizontalRunnerAutoscaler.Spec.CapacityReservations, "before", target.HorizontalRunnerAutoscaler.Spec.CapacityReservations,
"after", copy.Spec.CapacityReservations, "after", copy.Spec.CapacityReservations,
) )
@ -829,6 +827,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) SetupWithManager(mgr
hra := rawObj.(*v1alpha1.HorizontalRunnerAutoscaler) hra := rawObj.(*v1alpha1.HorizontalRunnerAutoscaler)
if hra.Spec.ScaleTargetRef.Name == "" { if hra.Spec.ScaleTargetRef.Name == "" {
autoscaler.Log.V(1).Info(fmt.Sprintf("scale target ref name not set for hra %s", hra.Name))
return nil return nil
} }

4
controllers/runnerreplicaset_controller.go
View File

@ -155,7 +155,7 @@ func (r *RunnerReplicaSetReconciler) Reconcile(ctx context.Context, req ctrl.Req
if current > desired { if current > desired {
n := current - desired n := current - desired
log.V(0).Info(fmt.Sprintf("Deleting %d runners", n), "desired", desired, "current", current, "ready", ready) log.V(0).Info(fmt.Sprintf("Deleting %d runners from RunnerReplicaSet %s", n, req.NamespacedName), "desired", desired, "current", current, "ready", ready)
// get runners that are currently offline/not busy/timed-out to register // get runners that are currently offline/not busy/timed-out to register
var deletionCandidates []v1alpha1.Runner var deletionCandidates []v1alpha1.Runner
@ -233,7 +233,7 @@ func (r *RunnerReplicaSetReconciler) Reconcile(ctx context.Context, req ctrl.Req
} }
r.Recorder.Event(&rs, corev1.EventTypeNormal, "RunnerDeleted", fmt.Sprintf("Deleted runner '%s'", deletionCandidates[i].Name)) r.Recorder.Event(&rs, corev1.EventTypeNormal, "RunnerDeleted", fmt.Sprintf("Deleted runner '%s'", deletionCandidates[i].Name))
log.Info("Deleted runner") log.Info(fmt.Sprintf("Deleted runner %s", deletionCandidates[i].Name))
} }
} else if desired > current { } else if desired > current {
n := desired - current n := desired - current