From 35af24cf03f70f7d8737bbc1e5b38a4317b4f414 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Tue, 4 Oct 2022 20:29:51 +0900 Subject: [PATCH] Enhnace log-related fields in the bug report form (#1838) Both fields can be useless when the reporter thought only one or two lines of the respective logs are relevant and it turned out we had to see another line later. To avoid such a situation I'd like to change the field labels to include `Whole` so that it looks like `Whole Runner Pod Logs`, and ask to not omit the logs in the field description. --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 81a95e75..e921e0ed 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -137,8 +137,8 @@ body: - type: textarea id: controller-logs attributes: - label: Controller Logs - description: "NEVER EVER OMIT THIS! Include logs from `actions-runner-controller`'s controller-manager pod" + label: Whole Controller Logs + description: "NEVER EVER OMIT THIS! Include logs from `actions-runner-controller`'s controller-manager pod. Don't omit the parts you think irrelevant!" render: shell placeholder: | PROVIDE THE LOGS VIA A GIST LINK (https://gist.github.com/), NOT DIRECTLY IN THIS TEXT AREA @@ -157,11 +157,11 @@ body: - type: textarea id: runner-pod-logs attributes: - label: Runner Pod Logs - description: "Include logs from runner pod(s)" + label: Whole Runner Pod Logs + description: "Include logs from runner pod(s). Please don't omit the parts you think irrelevant!" render: shell placeholder: | - PROVIDE THE LOGS VIA A GIST LINK (https://gist.github.com/), NOT DIRECTLY IN THIS TEXT AREA + PROVIDE THE WHOLE LOGS VIA A GIST LINK (https://gist.github.com/), NOT DIRECTLY IN THIS TEXT AREA To grab the runner pod logs: @@ -173,6 +173,8 @@ body: kubectl -n $NS logs $POD_NAME -c runner > runnerpod_runner.log kubectl -n $NS logs $POD_NAME -c docker > runnerpod_docker.log + + If any of the containers are getting terminated immediately, try adding `--previous` to the kubectl-logs command to obtain logs emitted before the termination. validations: required: true - type: textarea