From 319962a30a2eb9d1e5f8f7d3ab91cd83c32ca71a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20Fern=C3=A1ndez?=
 <7312236+fernandezcuesta@users.noreply.github.com>
Date: Fri, 7 Mar 2025 13:49:02 +0100
Subject: [PATCH] fixup

---
 charts/gha-runner-scale-set/templates/kube_mode_role.yaml     | 4 ++++
 .../templates/kube_mode_serviceaccount.yaml                   | 1 +
 2 files changed, 5 insertions(+)

diff --git a/charts/gha-runner-scale-set/templates/kube_mode_role.yaml b/charts/gha-runner-scale-set/templates/kube_mode_role.yaml
index df11a1f6..038307c1 100644
--- a/charts/gha-runner-scale-set/templates/kube_mode_role.yaml
+++ b/charts/gha-runner-scale-set/templates/kube_mode_role.yaml
@@ -6,6 +6,9 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   name: {{ include "gha-runner-scale-set.kubeModeRoleName" . }}
+  namespace: {{ include "gha-runner-scale-set.namespace" . }}
+  labels:
+    {{- with .Values.labels }}
     {{- toYaml . | nindent 4 }}
     {{- end }}
     {{- if $hasCustomResourceMeta }}
@@ -23,6 +26,7 @@ metadata:
     {{- toYaml . | nindent 4 }}
     {{- end }}
     {{- end }}
+  finalizers:
     - actions.github.com/cleanup-protection
 rules:
 - apiGroups: [""]
diff --git a/charts/gha-runner-scale-set/templates/kube_mode_serviceaccount.yaml b/charts/gha-runner-scale-set/templates/kube_mode_serviceaccount.yaml
index 446ab568..5286ff50 100644
--- a/charts/gha-runner-scale-set/templates/kube_mode_serviceaccount.yaml
+++ b/charts/gha-runner-scale-set/templates/kube_mode_serviceaccount.yaml
@@ -5,6 +5,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: {{ include "gha-runner-scale-set.kubeModeServiceAccountName" . }}
+  namespace: {{ include "gha-runner-scale-set.namespace" . }}
   {{- if or .Values.annotations $hasCustomResourceMeta }}
   annotations:
     {{- with .Values.annotations }}