public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply naming convention to workflows (#2581) 

Co-authored-by: John Sudol <24583161+johnsudol@users.noreply.github.com>
This commit is contained in:
Bassem Dghaidi 2023-05-15 14:31:18 +02:00 committed by GitHub
parent 8a5fb6ccb7
commit 30355f742b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
15 changed files with 34 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/publish-chart.yaml → .github/workflows/arc-publish-chart.yaml vendored
View File

@ -1,4 +1,4 @@
name: Publish Helm Chart name: Publish ARC Helm Charts
# Revert to https://github.com/actions-runner-controller/releases#releases # Revert to https://github.com/actions-runner-controller/releases#releases
# for details on why we use this approach # for details on why we use this approach
@ -8,7 +8,7 @@ on:
- master - master
paths: paths:
- 'charts/**' - 'charts/**'
- '.github/workflows/publish-chart.yaml' - '.github/workflows/arc-publish-chart.yaml'
- '!charts/actions-runner-controller/docs/**' - '!charts/actions-runner-controller/docs/**'
- '!charts/gha-runner-scale-set-controller/**' - '!charts/gha-runner-scale-set-controller/**'
- '!charts/gha-runner-scale-set/**' - '!charts/gha-runner-scale-set/**'
@ -171,6 +171,7 @@ jobs:
--owner "$(echo ${{ github.repository }} | cut -d '/' -f 1)" \ --owner "$(echo ${{ github.repository }} | cut -d '/' -f 1)" \
--git-repo "$(echo ${{ github.repository }} | cut -d '/' -f 2)" \ --git-repo "$(echo ${{ github.repository }} | cut -d '/' -f 2)" \
--index-path ${{ github.workspace }}/index.yaml \ --index-path ${{ github.workspace }}/index.yaml \
--token ${{ secrets.GITHUB_TOKEN }} \
--push \ --push \
--pages-branch 'gh-pages' \ --pages-branch 'gh-pages' \
--pages-index-path 'index.yaml' --pages-index-path 'index.yaml'

2
.github/workflows/publish-arc.yaml → .github/workflows/arc-publish.yaml vendored
View File

@ -1,4 +1,4 @@
name: Publish ARC name: Publish ARC Image
# Revert to https://github.com/actions-runner-controller/releases#releases # Revert to https://github.com/actions-runner-controller/releases#releases
# for details on why we use this approach # for details on why we use this approach

4
.github/workflows/release-runners.yaml → .github/workflows/arc-release-runners.yaml vendored
View File

@ -1,4 +1,4 @@
name: Release Runner Images name: Release ARC Runner Images
# Revert to https://github.com/actions-runner-controller/releases#releases # Revert to https://github.com/actions-runner-controller/releases#releases
# for details on why we use this approach # for details on why we use this approach
@ -10,7 +10,7 @@ on:
- 'master' - 'master'
paths: paths:
- 'runner/VERSION' - 'runner/VERSION'
- '.github/workflows/release-runners.yaml' - '.github/workflows/arc-release-runners.yaml'
env: env:
# Safeguard to prevent pushing images to registeries after build # Safeguard to prevent pushing images to registeries after build

2
.github/workflows/update-runners.yaml → .github/workflows/arc-update-runners-scheduled.yaml vendored
View File

@ -1,6 +1,6 @@
# This workflows polls releases from actions/runner and in case of a new one it # This workflows polls releases from actions/runner and in case of a new one it
# updates files containing runner version and opens a pull request. # updates files containing runner version and opens a pull request.
name: Update runners name: Runner Updates Check (Scheduled Job)
on: on:
schedule: schedule:

4
.github/workflows/validate-chart.yaml → .github/workflows/arc-validate-chart.yaml vendored
View File

@ -6,7 +6,7 @@ on:
- master - master
paths: paths:
- 'charts/**' - 'charts/**'
- '.github/workflows/validate-chart.yaml' - '.github/workflows/arc-validate-chart.yaml'
- '!charts/actions-runner-controller/docs/**' - '!charts/actions-runner-controller/docs/**'
- '!**.md' - '!**.md'
- '!charts/gha-runner-scale-set-controller/**' - '!charts/gha-runner-scale-set-controller/**'
@ -14,7 +14,7 @@ on:
push: push:
paths: paths:
- 'charts/**' - 'charts/**'
- '.github/workflows/validate-chart.yaml' - '.github/workflows/arc-validate-chart.yaml'
- '!charts/actions-runner-controller/docs/**' - '!charts/actions-runner-controller/docs/**'
- '!**.md' - '!**.md'
- '!charts/gha-runner-scale-set-controller/**' - '!charts/gha-runner-scale-set-controller/**'

2
.github/workflows/validate-runners.yaml → .github/workflows/arc-validate-runners.yaml vendored
View File

@ -1,4 +1,4 @@
name: Validate Runners name: Validate ARC Runners
on: on:
pull_request: pull_request:

2
.github/workflows/e2e-test-linux-vm.yaml → .github/workflows/gha-e2e-tests.yaml vendored
View File

@ -1,4 +1,4 @@
name: CI ARC E2E Linux VM Test name: (gha) E2E Tests
on: on:
push: push:

4
.github/workflows/publish-runner-scale-set.yaml → .github/workflows/gha-publish-chart.yaml vendored
View File

@ -1,4 +1,4 @@
name: Publish Runner Scale Set Controller Charts name: (gha) Publish Helm Charts
on: on:
workflow_dispatch: workflow_dispatch:
@ -101,7 +101,7 @@ jobs:
- name: Job summary - name: Job summary
run: | run: |
echo "The [publish-runner-scale-set.yaml](https://github.com/actions/actions-runner-controller/blob/main/.github/workflows/publish-runner-scale-set.yaml) workflow run was completed successfully!" >> $GITHUB_STEP_SUMMARY echo "The [gha-publish-chart.yaml](https://github.com/actions/actions-runner-controller/blob/main/.github/workflows/gha-publish-chart.yaml) workflow run was completed successfully!" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY
echo "**Parameters:**" >> $GITHUB_STEP_SUMMARY echo "**Parameters:**" >> $GITHUB_STEP_SUMMARY
echo "- Ref: ${{ steps.resolve_parameters.outputs.resolvedRef }}" >> $GITHUB_STEP_SUMMARY echo "- Ref: ${{ steps.resolve_parameters.outputs.resolvedRef }}" >> $GITHUB_STEP_SUMMARY

6
.github/workflows/validate-gha-chart.yaml → .github/workflows/gha-validate-chart.yaml vendored
View File

@ -1,4 +1,4 @@
name: Validate Helm Chart (gha-runner-scale-set-controller and gha-runner-scale-set) name: (gha) Validate Helm Charts
on: on:
pull_request: pull_request:
@ -6,13 +6,13 @@ on:
- master - master
paths: paths:
- 'charts/**' - 'charts/**'
- '.github/workflows/validate-gha-chart.yaml' - '.github/workflows/gha-validate-chart.yaml'
- '!charts/actions-runner-controller/**' - '!charts/actions-runner-controller/**'
- '!**.md' - '!**.md'
push: push:
paths: paths:
- 'charts/**' - 'charts/**'
- '.github/workflows/validate-gha-chart.yaml' - '.github/workflows/gha-validate-chart.yaml'
- '!charts/actions-runner-controller/**' - '!charts/actions-runner-controller/**'
- '!**.md' - '!**.md'
workflow_dispatch: workflow_dispatch:

26
.github/workflows/publish-canary.yaml → .github/workflows/global-publish-canary.yaml vendored
View File

@ -1,4 +1,4 @@
name: Publish Canary Image name: Publish Canary Images
# Revert to https://github.com/actions-runner-controller/releases#releases # Revert to https://github.com/actions-runner-controller/releases#releases
# for details on why we use this approach # for details on why we use this approach
@ -11,19 +11,19 @@ on:
- '.github/actions/**' - '.github/actions/**'
- '.github/ISSUE_TEMPLATE/**' - '.github/ISSUE_TEMPLATE/**'
- '.github/workflows/e2e-test-dispatch-workflow.yaml' - '.github/workflows/e2e-test-dispatch-workflow.yaml'
- '.github/workflows/e2e-test-linux-vm.yaml' - '.github/workflows/gha-e2e-tests.yaml'
- '.github/workflows/publish-arc.yaml' - '.github/workflows/arc-publish.yaml'
- '.github/workflows/publish-chart.yaml' - '.github/workflows/arc-publish-chart.yaml'
- '.github/workflows/publish-runner-scale-set.yaml' - '.github/workflows/gha-publish-chart.yaml'
- '.github/workflows/release-runners.yaml' - '.github/workflows/arc-release-runners.yaml'
- '.github/workflows/run-codeql.yaml' - '.github/workflows/global-run-codeql.yaml'
- '.github/workflows/run-first-interaction.yaml' - '.github/workflows/global-run-first-interaction.yaml'
- '.github/workflows/run-stale.yaml' - '.github/workflows/global-run-stale.yaml'
- '.github/workflows/update-runners.yaml' - '.github/workflows/arc-update-runners-scheduled.yaml'
- '.github/workflows/validate-arc.yaml' - '.github/workflows/validate-arc.yaml'
- '.github/workflows/validate-chart.yaml' - '.github/workflows/arc-validate-chart.yaml'
- '.github/workflows/validate-gha-chart.yaml' - '.github/workflows/gha-validate-chart.yaml'
- '.github/workflows/validate-runners.yaml' - '.github/workflows/arc-validate-runners.yaml'
- '.github/dependabot.yml' - '.github/dependabot.yml'
- '.github/RELEASE_NOTE_TEMPLATE.md' - '.github/RELEASE_NOTE_TEMPLATE.md'
- 'runner/**' - 'runner/**'

0
.github/workflows/run-codeql.yaml → .github/workflows/global-run-codeql.yaml vendored
View File

2
.github/workflows/run-first-interaction.yaml → .github/workflows/global-run-first-interaction.yaml vendored
View File

@ -1,4 +1,4 @@
name: first-interaction name: First Interaction
on: on:
issues: issues:

0
.github/workflows/run-stale.yaml → .github/workflows/global-run-stale.yaml vendored
View File

4
docs/adrs/2023-02-02-automate-runner-updates.md
View File

@ -10,7 +10,7 @@ When a new [runner](https://github.com/actions/runner) version is released, new
images need to be built in images need to be built in
[actions-runner-controller/releases](https://github.com/actions-runner-controller/releases). [actions-runner-controller/releases](https://github.com/actions-runner-controller/releases).
This is currently started by the This is currently started by the
[release-runners](https://github.com/actions/actions-runner-controller/blob/master/.github/workflows/release-runners.yaml) [release-runners](https://github.com/actions/actions-runner-controller/blob/master/.github/workflows/arc-release-runners.yaml)
workflow, although this only starts when the set of file containing the runner workflow, although this only starts when the set of file containing the runner
version is updated (and this is currently done manually). version is updated (and this is currently done manually).
@ -19,7 +19,7 @@ version is updated (and this is currently done manually).
We can have another workflow running on a cadence (hourly seems sensible) and checking for new runner We can have another workflow running on a cadence (hourly seems sensible) and checking for new runner
releases, creating a PR updating `RUNNER_VERSION` in: releases, creating a PR updating `RUNNER_VERSION` in:
- `.github/workflows/release-runners.yaml` - `.github/workflows/arc-release-runners.yaml`
- `Makefile` - `Makefile`
- `runner/Makefile` - `runner/Makefile`
- `test/e2e/e2e_test.go` - `test/e2e/e2e_test.go`

2
docs/adrs/2023-03-17-workflow-improvements.md
View File

@ -26,7 +26,7 @@ At the moment we have three workflows that validate Go code:
- [Validate ARC](https://github.com/actions/actions-runner-controller/blob/01e9dd3/.github/workflows/validate-arc.yaml): - [Validate ARC](https://github.com/actions/actions-runner-controller/blob/01e9dd3/.github/workflows/validate-arc.yaml):
this is a bit of a catch-all workflow, other than Go tests this also validates this is a bit of a catch-all workflow, other than Go tests this also validates
Kubernetes manifests, runs `go generate`, `go fmt` and `go vet` Kubernetes manifests, runs `go generate`, `go fmt` and `go vet`
- [Run CodeQL](https://github.com/actions/actions-runner-controller/blob/a095f0b66aad5fbc8aa8d7032f3299233e4c84d2/.github/workflows/run-codeql.yaml) - [Run CodeQL](https://github.com/actions/actions-runner-controller/blob/master/.github/workflows/global-run-codeql.yaml)
### Proposal ### Proposal