public_git/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git synced 2026-09-30 20:12:15 +02:00
Code Issues Projects Releases Wiki Activity

Fix listener replacement loop for empty collections (#4682)

Browse Source
This commit is contained in:
Nikola Jokic
2026-09-24 13:12:12 +02:00
committed by GitHub
parent 0528d1c4cc
commit 2fb29e06e5
4 changed files with 425 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/actions.github.com/helpers.go
+1 -1
View File
@@ -134,7 +134,7 @@ func ephemeralRunnerSetOutdatedForAppliedRevision(ephemeralRunnerSet *v1alpha1.E
// The cost of DeepDerivative is that it ignores empty values on the desired side,
// so a field being *removed* is invisible to it. For everything sourced from the
// user-facing template that is harmless: the AutoscalingRunnerSet controller
// compares the whole AutoscalingListener spec with cmp.Equal and deletes the
// compares the AutoscalingListener spec with Semantic.DeepEqual and deletes the
// listener outright, which takes the pod with it. Container ports are the
// exception, because they come from the --listener-metrics-addr controller flag
// rather than from any resource, so disabling metrics would otherwise leave the