public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert "chore: support app ids as int or strings (#869)" (#883) 

* Revert "chore: support app ids as int or strings (#869)"

This reverts commit 0a3d2b686e.

* docs: adding some comments to the code

* docs: adding comment to the chart values
This commit is contained in:
apr-1985 2021-10-17 23:23:31 +01:00 committed by GitHub
parent 0401b2d786
commit 271a4dcd9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
charts/actions-runner-controller/templates/manager_secrets.yaml
View File

@ -13,10 +13,12 @@ metadata:
type: Opaque type: Opaque
data: data:
{{- if .Values.authSecret.github_app_id }} {{- if .Values.authSecret.github_app_id }}
github_app_id: {{ .Values.authSecret.github_app_id | int | toString | b64enc }} # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example
github_app_id: {{ .Values.authSecret.github_app_id | toString | b64enc }}
{{- end }} {{- end }}
{{- if .Values.authSecret.github_app_installation_id }} {{- if .Values.authSecret.github_app_installation_id }}
github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | int | toString | b64enc }} # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example
github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | toString | b64enc }}
{{- end }} {{- end }}
{{- if .Values.authSecret.github_app_private_key }} {{- if .Values.authSecret.github_app_private_key }}
github_app_private_key: {{ .Values.authSecret.github_app_private_key | toString | b64enc }} github_app_private_key: {{ .Values.authSecret.github_app_private_key | toString | b64enc }}

3
charts/actions-runner-controller/values.yaml
View File

@ -27,7 +27,8 @@ authSecret:
create: false create: false
name: "controller-manager" name: "controller-manager"
annotations: {} annotations: {}
### GitHub App Configuration ### GitHub Apps Configuration
## NOTE: IDs MUST be strings, use quotes
#github_app_id: "" #github_app_id: ""
#github_app_installation_id: "" #github_app_installation_id: ""
#github_app_private_key: | #github_app_private_key: |